From 09c85796a651dc31a4b20bed80a7a866c186b963 Mon Sep 17 00:00:00 2001 From: Alex Voinea Date: Sat, 23 Sep 2023 20:25:12 +0200 Subject: [PATCH] No need to mask the CGRAM data before sending --- Firmware/lcd.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Firmware/lcd.cpp b/Firmware/lcd.cpp index 0fc507384..320c69979 100644 --- a/Firmware/lcd.cpp +++ b/Firmware/lcd.cpp @@ -395,7 +395,7 @@ void lcd_createChar_P(uint8_t location, const CustomCharacter *char_p) "swap __tmp_reg__" "\n\t" // swap the nibbles "mov %0, __tmp_reg__" "\n\t" // copy row data to temp - "andi %0, 0xF" "\n\t" // mask lower nibble + // "andi %0, 0xF" "\n\t" // mask lower nibble - Not needed since bits 7-5 of the CGRAM are don't care, so they can contain garbage "ror %1" "\n\t" // consume LSB of colByte and push it to the carry "rol %0" "\n\t" // insert the column LSB from carry "st %a3+, %0" "\n\t" // push the generated row data to the output