From 1bf33bd1aad1a829b0c80d83efc1128638a351de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 4 Aug 2023 10:12:21 +0000 Subject: [PATCH] Fix a bug where Load filament menu disappears Kudos to @3d-gussner for finding the issue Steps to reproduce: 1. reset printer 2. select Load filament 3. go back to main 4. LCD menu is very limited 5. To get all menus back select 6. Preheat 7. back to main This commit is my proposed fix. When eFilamentAction is equal to FilamentAction::Load we must reset it to FilamentAction::None when the Back button in Load Filament is selected Change in memory: Flash: -26 bytes SRAM: 0 bytes --- Firmware/ultralcd.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/Firmware/ultralcd.cpp b/Firmware/ultralcd.cpp index 37a948bc1..c3b55f681 100644 --- a/Firmware/ultralcd.cpp +++ b/Firmware/ultralcd.cpp @@ -1833,13 +1833,8 @@ switch(eFilamentAction) void mFilamentBack() { - if (eFilamentAction == FilamentAction::AutoLoad || - eFilamentAction == FilamentAction::Preheat || - eFilamentAction == FilamentAction::Lay1Cal) - { - // filament action has been cancelled - eFilamentAction = FilamentAction::None; - } + // filament action has been cancelled + eFilamentAction = FilamentAction::None; } void mFilamentItem(uint16_t nTemp, uint16_t nTempBed)