josh
/
Prusa-Firmware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Drop sound feedback in lcd_v2_calibration 

Drop the sound feedback in lcd_v2_calibration
when switching to lcd_generic_preheat_menu

If a single filament setup (no MMU) has filament loaded, it will jump
immediately to lcd_generic_preheat_menu
this created double feedback.

Let's just drop the feedback since the transition
between menus is very fast.

Change in memory:
Flash: -8 bytes
This commit is contained in:
Guðni Már Gilbert 2023-04-22 15:28:27 +00:00
parent b8f8348e77
commit 3509791943
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Firmware/ultralcd.cpp
View File

@ -3639,10 +3639,7 @@ void lcd_v2_calibration() {
lcd_consume_click(); lcd_consume_click();
for (uint_least8_t i = 0; i < 20; i++) { //wait max. 2s for (uint_least8_t i = 0; i < 20; i++) { //wait max. 2s
delay_keep_alive(100); delay_keep_alive(100);
if (LCD_CLICKED) { if (lcd_clicked()) {
// Click event is consumed below when
// rendering the preheat menu. We use this
// to check whether a audio feedback should be shown
break; break;
} }
} }
@ -3654,12 +3651,7 @@ void lcd_v2_calibration() {
#endif //FILAMENT_SENSOR #endif //FILAMENT_SENSOR
eFilamentAction = FilamentAction::Lay1Cal; eFilamentAction = FilamentAction::Lay1Cal;
menu_goto(lcd_generic_preheat_menu, 0, true);
// Produce feedback if the LCD knob was not clicked
// Note for non-MMU setups there is a 2 second timeout in case
// the user does not click the knob, in such a case we want feedback
// since the firmware is changing the menu silently.
menu_goto(lcd_generic_preheat_menu, 0, true, !lcd_clicked());
} }
void lcd_wizard() { void lcd_wizard() {