From 6b8a5bc3ac5c35ab038f7696a4c53bd09e2cd506 Mon Sep 17 00:00:00 2001 From: Marek Bel Date: Tue, 16 Jul 2019 17:31:56 +0200 Subject: [PATCH 1/3] Fix compiler warnings sketch/tmc2130.cpp:146:42: warning: default argument given for parameter 1 of 'void tmc2130_init(bool)' [-fpermissive] sketch/tmc2130.cpp:146:24: warning: unused parameter 'bSupressFlag' [-Wunused-parameter] --- Firmware/tmc2130.cpp | 7 +++++-- Firmware/tmc2130.h | 4 ++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Firmware/tmc2130.cpp b/Firmware/tmc2130.cpp index f9dee3be9..15188fc42 100755 --- a/Firmware/tmc2130.cpp +++ b/Firmware/tmc2130.cpp @@ -142,8 +142,11 @@ uint16_t __tcoolthrs(uint8_t axis) } return 0; } - -void tmc2130_init(bool bSupressFlag=false) +#ifdef PSU_Delta +void tmc2130_init(bool bSupressFlag) +#else +void tmc2130_init() +#endif { // DBG(_n("tmc2130_init(), mode=%S\n"), tmc2130_mode?_n("STEALTH"):_n("NORMAL")); WRITE(X_TMC2130_CS, HIGH); diff --git a/Firmware/tmc2130.h b/Firmware/tmc2130.h index a1d160f05..ed4c0d7c0 100644 --- a/Firmware/tmc2130.h +++ b/Firmware/tmc2130.h @@ -51,7 +51,11 @@ typedef struct extern tmc2130_chopper_config_t tmc2130_chopper_config[4]; //initialize tmc2130 +#ifdef PSU_Delta extern void tmc2130_init(bool bSupressFlag=false); +#else +extern void tmc2130_init(); +#endif //check diag pins (called from stepper isr) extern void tmc2130_st_isr(); //update stall guard (called from st_synchronize inside the loop) From cee875fc6aef5b388c28d9244849298aa1128a7e Mon Sep 17 00:00:00 2001 From: Marek Bel Date: Tue, 16 Jul 2019 17:40:28 +0200 Subject: [PATCH 2/3] Fix compiler warnings: warning: enumeration value '_None' not handled in switch [-Wswitch] warning: enumeration value '_Undef' not handled in switch [-Wswitch] --- Firmware/util.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Firmware/util.cpp b/Firmware/util.cpp index b2105e929..fc6b0f0b5 100644 --- a/Firmware/util.cpp +++ b/Firmware/util.cpp @@ -393,6 +393,9 @@ switch(oCheckMode) lcd_show_fullscreen_message_and_wait_P(_i("Nozzle diameter doesn't match! Print is aborted, press the knob.")); lcd_print_stop(); break; + case ClCheckMode::_None: + case ClCheckMode::_Undef: + break; } bSettings=false; // flag ('fake parameter') for 'lcd_checking_menu()' function menu_submenu(lcd_checking_menu); @@ -419,6 +422,9 @@ switch(oCheckModel) lcd_show_fullscreen_message_and_wait_P(_i("Printer model doesn't match! Print is aborted, press the knob.")); lcd_print_stop(); break; + case ClCheckModel::_None: + case ClCheckModel::_Undef: + break; } } @@ -462,6 +468,9 @@ switch(oCheckVersion) lcd_show_fullscreen_message_and_wait_P(_i("FW version doesn't match! Print is aborted, press the knob.")); lcd_print_stop(); break; + case ClCheckVersion::_None: + case ClCheckVersion::_Undef: + break; } } @@ -488,6 +497,9 @@ switch(oCheckGcode) lcd_show_fullscreen_message_and_wait_P(_i("G-code level doesn't match! Print is aborted, press the knob.")); lcd_print_stop(); break; + case ClCheckGcode::_None: + case ClCheckGcode::_Undef: + break; } } @@ -547,6 +559,9 @@ switch(oCheckModel) lcd_show_fullscreen_message_and_wait_P(_i("Printer model doesn't match! Print is aborted, press the knob.")); lcd_print_stop(); break; + case ClCheckModel::_None: + case ClCheckModel::_Undef: + break; } } From 3e292fd6b0cd61801d6e5457f78b8e72d72ccbf6 Mon Sep 17 00:00:00 2001 From: Marek Bel Date: Tue, 16 Jul 2019 18:16:05 +0200 Subject: [PATCH 3/3] Fix compiler warnings: sketch/Marlin.h:178:17: warning: extra tokens at end of #undef directive sketch/Marlin.h:181:24: warning: extra tokens at end of #undef directive sketch/Marlin.h:182:0: warning: "enable_z" redefined --- Firmware/Marlin.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Firmware/Marlin.h b/Firmware/Marlin.h index 35cfe651d..a44346619 100755 --- a/Firmware/Marlin.h +++ b/Firmware/Marlin.h @@ -173,14 +173,14 @@ void manage_inactivity(bool ignore_stepper_queue=false); #endif #ifdef PSU_Delta -void init_force_z(); -void check_force_z(); -#undef disable_z() -#define disable_z() disable_force_z() -void disable_force_z(); -#undef enable_disable_z() -#define enable_z() enable_force_z() -void enable_force_z(); + void init_force_z(); + void check_force_z(); + #undef disable_z + #define disable_z() disable_force_z() + void disable_force_z(); + #undef enable_z + #define enable_z() enable_force_z() + void enable_force_z(); #endif // PSU_Delta