From 6187b7eecf5e7d9fa20a4bc5b835a0aa991f3683 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 28 Apr 2023 18:25:16 +0000 Subject: [PATCH] optimisation: use disable_heater() in more places Change in memory: Flash: -84 bytes SRAM: 0 bytes --- Firmware/Marlin_main.cpp | 6 ++---- Firmware/Prusa_farm.cpp | 4 +--- Firmware/power_panic.cpp | 6 ++---- Firmware/ultralcd.cpp | 9 +++------ 4 files changed, 8 insertions(+), 17 deletions(-) diff --git a/Firmware/Marlin_main.cpp b/Firmware/Marlin_main.cpp index 7c06981f7..adaea92b1 100644 --- a/Firmware/Marlin_main.cpp +++ b/Firmware/Marlin_main.cpp @@ -3102,8 +3102,7 @@ bool gcode_M45(bool onlyZ, int8_t verbosity_level) // Only Z calibration? if (!onlyZ) { - setTargetBed(0); - setTargetHotend(0); + disable_heater(); eeprom_adjust_bed_reset(); //reset bed level correction } @@ -9291,8 +9290,7 @@ static void handleSafetyTimer() } else if (safetyTimer.expired(farm_mode?FARM_DEFAULT_SAFETYTIMER_TIME_ms:safetytimer_inactive_time)) { - setTargetBed(0); - setTargetHotend(0); + disable_heater(); lcd_show_fullscreen_message_and_wait_P(_i("Heating disabled by safety timer."));////MSG_BED_HEATING_SAFETY_DISABLED c=20 r=4 } } diff --git a/Firmware/Prusa_farm.cpp b/Firmware/Prusa_farm.cpp index 88a3ba481..032f2d109 100644 --- a/Firmware/Prusa_farm.cpp +++ b/Firmware/Prusa_farm.cpp @@ -163,9 +163,7 @@ static void trace() { } void serial_read_stream() { - - setTargetHotend(0); - setTargetBed(0); + disable_heater(); lcd_clear(); lcd_puts_P(PSTR(" Upload in progress")); diff --git a/Firmware/power_panic.cpp b/Firmware/power_panic.cpp index adf3a033d..0bf2f1960 100644 --- a/Firmware/power_panic.cpp +++ b/Firmware/power_panic.cpp @@ -78,8 +78,7 @@ void uvlo_() { } // Stop all heaters before continuing - setTargetHotend(0); - setTargetBed(0); + disable_heater(); // Fetch data not included in a partial back-up if (!sd_print_saved_in_ram) { @@ -233,8 +232,7 @@ static void uvlo_tiny() { #endif //TMC2130 // Stop all heaters - setTargetHotend(0); - setTargetBed(0); + disable_heater(); // When power is interrupted on the _first_ recovery an attempt can be made to raise the // extruder, causing the Z position to change. Similarly, when recovering, the Z position is diff --git a/Firmware/ultralcd.cpp b/Firmware/ultralcd.cpp index be066530f..a6c9d1373 100644 --- a/Firmware/ultralcd.cpp +++ b/Firmware/ultralcd.cpp @@ -1030,8 +1030,7 @@ static void lcd_move_menu_axis(); static void lcd_cooldown() { - setTargetHotend(0); - setTargetBed(0); + disable_heater(); fanSpeed = 0; lcd_return_to_status(); } @@ -2712,8 +2711,7 @@ void pid_extruder() #ifdef PINDA_THERMISTOR bool lcd_wait_for_pinda(float temp) { - setTargetHotend(0); - setTargetBed(0); + disable_heater(); LongTimer pinda_timeout; pinda_timeout.start(); bool target_temp_reached = true; @@ -2744,8 +2742,7 @@ void lcd_wait_for_heater() { } void lcd_wait_for_cool_down() { - setTargetHotend(0); - setTargetBed(0); + disable_heater(); uint8_t fanSpeedBckp = fanSpeed; fanSpeed = 255; while ((degHotend(0)>MAX_HOTEND_TEMP_CALIBRATION) || (degBed() > MAX_BED_TEMP_CALIBRATION)) {