From 66bb9bcfe4ad86b10290a8cd0bb94c512fb76185 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Mon, 27 Feb 2023 20:15:28 +0000 Subject: [PATCH] optimisation: lcd_temp_cal_show_result result is boolean so always update the EEPROM Change in memory: Flash: -20 bytes SRAM: 0 bytes --- Firmware/ultralcd.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/Firmware/ultralcd.cpp b/Firmware/ultralcd.cpp index cea59aaf6..a299dc0b9 100644 --- a/Firmware/ultralcd.cpp +++ b/Firmware/ultralcd.cpp @@ -3223,17 +3223,16 @@ void lcd_temp_cal_show_result(bool result) { disable_e2(); setTargetBed(0); //set bed target temperature back to 0 - if (result == true) { - eeprom_update_byte((uint8_t*)EEPROM_CALIBRATION_STATUS_PINDA, 1); + // Store boolean result + eeprom_update_byte((uint8_t*)EEPROM_CALIBRATION_STATUS_PINDA, result); + eeprom_update_byte((uint8_t*)EEPROM_TEMP_CAL_ACTIVE, result); + + if (result) { SERIAL_ECHOLNPGM("PINDA calibration done. Continue with pressing the knob."); lcd_show_fullscreen_message_and_wait_P(_T(MSG_PINDA_CALIBRATION_DONE)); - eeprom_update_byte((unsigned char *)EEPROM_TEMP_CAL_ACTIVE, 1); - } - else { - eeprom_update_byte((uint8_t*)EEPROM_CALIBRATION_STATUS_PINDA, 0); + } else { SERIAL_ECHOLNPGM("PINDA calibration failed. Continue with pressing the knob."); lcd_show_fullscreen_message_and_wait_P(_i("PINDA calibration failed"));////MSG_PINDA_CAL_FAILED c=20 r=4 - eeprom_update_byte((unsigned char *)EEPROM_TEMP_CAL_ACTIVE, 0); } lcd_update_enable(true); lcd_update(2);