josh
/
Prusa-Firmware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PFW-1354 Fix slow button processing (#37) 

* Fix MK3S buttons being processed too slowly

After a button is selected on the MK3S MMU error screen, we need to process it before asking for another MMU Query.

Because the MMU Query will make the Error screen return and overwrite the status screen

* Add back CheckUserInput for ButtonPushed event
This commit is contained in:
Guðni Már Gilbert 2022-07-09 15:06:25 +00:00 committed by D.R.racer
parent d420b20bd9
commit 6b7a018f9b
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Firmware/mmu2.cpp
View File

@ -678,6 +678,7 @@ void MMU2::manage_response(const bool move_axes, const bool turn_off_nozzle) {
}
StepStatus MMU2::LogicStep() {
CheckUserInput(); // Process any buttons before proceeding with another MMU Query
StepStatus ss = logic.Step();
switch (ss) {
case Finished:
@ -686,27 +687,23 @@ StepStatus MMU2::LogicStep() {
break;
case CommandError:
ReportError(logic.Error(), ErrorSourceMMU);
CheckUserInput();
break;
case CommunicationTimeout:
state = xState::Connecting;
ReportError(ErrorCode::MMU_NOT_RESPONDING, ErrorSourcePrinter);
CheckUserInput();
break;
case ProtocolError:
state = xState::Connecting;
ReportError(ErrorCode::PROTOCOL_ERROR, ErrorSourcePrinter);
CheckUserInput();
break;
case VersionMismatch:
StopKeepPowered();
ReportError(ErrorCode::VERSION_MISMATCH, ErrorSourcePrinter);
CheckUserInput();
break;
case ButtonPushed:
lastButton = logic.Button();
LogEchoEvent("MMU Button pushed");
CheckUserInput();
CheckUserInput(); // Process the button immediately
break;
default:
break;