From b735c3d040c46b95f7634d630ff4ea0e411999e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Sun, 19 Feb 2023 21:39:22 +0000 Subject: [PATCH] optimisation: extract common code into SETTINGS_FANS_CHECK Implement it as a function instead of preprocessor macro this allows us to control inlining Change in memory: Flash: -34 bytes SRAM: 0 bytes --- Firmware/ultralcd.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Firmware/ultralcd.cpp b/Firmware/ultralcd.cpp index cd86a3388..37eb99bf9 100644 --- a/Firmware/ultralcd.cpp +++ b/Firmware/ultralcd.cpp @@ -4211,6 +4211,10 @@ static void SETTINGS_SILENT_MODE() { } } +void SETTINGS_FANS_CHECK() { + MENU_ITEM_TOGGLE_P(_T(MSG_FANS_CHECK), fans_check_enabled ? _T(MSG_ON) : _T(MSG_OFF), lcd_set_fan_check); +} + #ifndef MMU_FORCE_STEALTH_MODE #define SETTINGS_MMU_MODE \ do\ @@ -4557,7 +4561,7 @@ static void lcd_settings_menu() MENU_ITEM_FUNCTION_P(PSTR("Reset MMU"), mmu_reset); } - MENU_ITEM_TOGGLE_P(_T(MSG_FANS_CHECK), fans_check_enabled ? _T(MSG_ON) : _T(MSG_OFF), lcd_set_fan_check); + SETTINGS_FANS_CHECK(); SETTINGS_SILENT_MODE(); if(!farm_mode) @@ -5528,7 +5532,7 @@ static void lcd_tune_menu() SETTINGS_CUTTER; } - MENU_ITEM_TOGGLE_P(_T(MSG_FANS_CHECK), fans_check_enabled ? _T(MSG_ON) : _T(MSG_OFF), lcd_set_fan_check); + SETTINGS_FANS_CHECK(); SETTINGS_SILENT_MODE(); SETTINGS_MMU_MODE; SETTINGS_SOUND;