Explicitly using Buttons namespace

This change sync the code a little bit with the 32-bit FW

No change in memory
This commit is contained in:
gudnimg 2023-09-03 12:33:11 +00:00
parent 4c53163068
commit e0269d6f6a
3 changed files with 28 additions and 28 deletions

View File

@ -241,7 +241,7 @@ bool MMU2::RetryIfPossible(uint16_t ec) {
if (logic.RetryAttempts()) { if (logic.RetryAttempts()) {
SetButtonResponse(ButtonOperations::Retry); SetButtonResponse(ButtonOperations::Retry);
// check, that Retry is actually allowed on that operation // check, that Retry is actually allowed on that operation
if (ButtonAvailable(ec) != NoButton) { if (ButtonAvailable(ec) != Buttons::NoButton) {
logic.SetInAutoRetry(true); logic.SetInAutoRetry(true);
SERIAL_ECHOLNPGM("RetryButtonPressed"); SERIAL_ECHOLNPGM("RetryButtonPressed");
// We don't decrement until the button is acknowledged by the MMU. // We don't decrement until the button is acknowledged by the MMU.
@ -733,9 +733,9 @@ void MMU2::CheckUserInput() {
} }
switch (btn) { switch (btn) {
case Left: case Buttons::Left:
case Middle: case Buttons::Middle:
case Right: case Buttons::Right:
SERIAL_ECHOPGM("CheckUserInput-btnLMR "); SERIAL_ECHOPGM("CheckUserInput-btnLMR ");
SERIAL_ECHOLN(btn); SERIAL_ECHOLN(btn);
ResumeHotendTemp(); // Recover the hotend temp before we attempt to do anything else... ResumeHotendTemp(); // Recover the hotend temp before we attempt to do anything else...
@ -757,22 +757,22 @@ void MMU2::CheckUserInput() {
break; break;
} }
break; break;
case TuneMMU: case Buttons::TuneMMU:
Tune(); Tune();
break; break;
case Load: case Buttons::Load:
case Eject: case Buttons::Eject:
// High level operation // High level operation
setPrinterButtonOperation(btn); setPrinterButtonOperation(btn);
break; break;
case ResetMMU: case Buttons::ResetMMU:
Reset(ResetPin); // we cannot do power cycle on the MK3 Reset(ResetPin); // we cannot do power cycle on the MK3
// ... but mmu2_power.cpp knows this and triggers a soft-reset instead. // ... but mmu2_power.cpp knows this and triggers a soft-reset instead.
break; break;
case DisableMMU: case Buttons::DisableMMU:
Stop(); // Poweroff handles updating the EEPROM shutoff. Stop(); // Poweroff handles updating the EEPROM shutoff.
break; break;
case StopPrint: case Buttons::StopPrint:
// @@TODO not sure if we shall handle this high level operation at this spot // @@TODO not sure if we shall handle this high level operation at this spot
break; break;
default: default:

View File

@ -186,7 +186,7 @@ struct ResetOnExit {
Buttons ButtonPressed(uint16_t ec) { Buttons ButtonPressed(uint16_t ec) {
if (buttonSelectedOperation == ButtonOperations::NoOperation) { if (buttonSelectedOperation == ButtonOperations::NoOperation) {
return NoButton; // no button return Buttons::NoButton; // no button
} }
ResetOnExit ros; // clear buttonSelectedOperation on exit from this call ResetOnExit ros; // clear buttonSelectedOperation on exit from this call
@ -214,7 +214,7 @@ Buttons ButtonAvailable(uint16_t ec) {
switch (buttonSelectedOperation) { switch (buttonSelectedOperation) {
// may be allow move selector right and left in the future // may be allow move selector right and left in the future
case ButtonOperations::Retry: // "Repeat action" case ButtonOperations::Retry: // "Repeat action"
return Middle; return Buttons::Middle;
default: default:
break; break;
} }
@ -224,9 +224,9 @@ Buttons ButtonAvailable(uint16_t ec) {
switch (buttonSelectedOperation) { switch (buttonSelectedOperation) {
// may be allow move selector right and left in the future // may be allow move selector right and left in the future
case ButtonOperations::Tune: // Tune Stallguard threshold case ButtonOperations::Tune: // Tune Stallguard threshold
return TuneMMU; return Buttons::TuneMMU;
case ButtonOperations::Retry: // "Repeat action" case ButtonOperations::Retry: // "Repeat action"
return Middle; return Buttons::Middle;
default: default:
break; break;
} }
@ -235,7 +235,7 @@ Buttons ButtonAvailable(uint16_t ec) {
case ERR_SYSTEM_FILAMENT_EJECTED: case ERR_SYSTEM_FILAMENT_EJECTED:
switch (buttonSelectedOperation) { switch (buttonSelectedOperation) {
case ButtonOperations::Continue: // User solved the serious mechanical problem by hand - there is no other way around case ButtonOperations::Continue: // User solved the serious mechanical problem by hand - there is no other way around
return Middle; return Buttons::Middle;
default: default:
break; break;
} }
@ -243,9 +243,9 @@ Buttons ButtonAvailable(uint16_t ec) {
case ERR_SYSTEM_FILAMENT_CHANGE: case ERR_SYSTEM_FILAMENT_CHANGE:
switch (buttonSelectedOperation) { switch (buttonSelectedOperation) {
case ButtonOperations::Load: case ButtonOperations::Load:
return Load; return Buttons::Load;
case ButtonOperations::Eject: case ButtonOperations::Eject:
return Eject; return Buttons::Eject;
default: default:
break; break;
} }
@ -255,9 +255,9 @@ Buttons ButtonAvailable(uint16_t ec) {
case ERR_TEMPERATURE_WARNING_TMC_IDLER_TOO_HOT: case ERR_TEMPERATURE_WARNING_TMC_IDLER_TOO_HOT:
switch (buttonSelectedOperation) { switch (buttonSelectedOperation) {
case ButtonOperations::Continue: // "Continue" case ButtonOperations::Continue: // "Continue"
return Left; return Buttons::Left;
case ButtonOperations::ResetMMU: // "Reset MMU" case ButtonOperations::ResetMMU: // "Reset MMU"
return ResetMMU; return Buttons::ResetMMU;
default: default:
break; break;
} }
@ -292,7 +292,7 @@ Buttons ButtonAvailable(uint16_t ec) {
case ERR_ELECTRICAL_MMU_MCU_ERROR: case ERR_ELECTRICAL_MMU_MCU_ERROR:
switch (buttonSelectedOperation) { switch (buttonSelectedOperation) {
case ButtonOperations::ResetMMU: // "Reset MMU" case ButtonOperations::ResetMMU: // "Reset MMU"
return ResetMMU; return Buttons::ResetMMU;
default: default:
break; break;
} }
@ -302,9 +302,9 @@ Buttons ButtonAvailable(uint16_t ec) {
case ERR_SYSTEM_FW_UPDATE_NEEDED: case ERR_SYSTEM_FW_UPDATE_NEEDED:
switch (buttonSelectedOperation) { switch (buttonSelectedOperation) {
case ButtonOperations::DisableMMU: // "Disable" case ButtonOperations::DisableMMU: // "Disable"
return DisableMMU; return Buttons::DisableMMU;
case ButtonOperations::ResetMMU: // "ResetMMU" case ButtonOperations::ResetMMU: // "ResetMMU"
return ResetMMU; return Buttons::ResetMMU;
default: default:
break; break;
} }
@ -312,9 +312,9 @@ Buttons ButtonAvailable(uint16_t ec) {
case ERR_SYSTEM_FILAMENT_ALREADY_LOADED: case ERR_SYSTEM_FILAMENT_ALREADY_LOADED:
switch (buttonSelectedOperation) { switch (buttonSelectedOperation) {
case ButtonOperations::Unload: // "Unload" case ButtonOperations::Unload: // "Unload"
return Left; return Buttons::Left;
case ButtonOperations::Continue: // "Proceed/Continue" case ButtonOperations::Continue: // "Proceed/Continue"
return Right; return Buttons::Right;
default: default:
break; break;
} }
@ -323,9 +323,9 @@ Buttons ButtonAvailable(uint16_t ec) {
case ERR_SYSTEM_INVALID_TOOL: case ERR_SYSTEM_INVALID_TOOL:
switch (buttonSelectedOperation) { switch (buttonSelectedOperation) {
case ButtonOperations::StopPrint: // "Stop print" case ButtonOperations::StopPrint: // "Stop print"
return StopPrint; return Buttons::StopPrint;
case ButtonOperations::ResetMMU: // "Reset MMU" case ButtonOperations::ResetMMU: // "Reset MMU"
return ResetMMU; return Buttons::ResetMMU;
default: default:
break; break;
} }
@ -335,7 +335,7 @@ Buttons ButtonAvailable(uint16_t ec) {
break; break;
} }
return NoButton; return Buttons::NoButton;
} }
void SetButtonResponse(ButtonOperations rsp){ void SetButtonResponse(ButtonOperations rsp){

View File

@ -532,7 +532,7 @@ ProtocolLogic::ProtocolLogic(MMU2Serial *uart, uint8_t extraLoadDistance, uint8_
, uart(uart) , uart(uart)
, errorCode(ErrorCode::OK) , errorCode(ErrorCode::OK)
, progressCode(ProgressCode::OK) , progressCode(ProgressCode::OK)
, buttonCode(NoButton) , buttonCode(Buttons::NoButton)
, lastFSensor((uint8_t)WhereIsFilament()) , lastFSensor((uint8_t)WhereIsFilament())
, regIndex(0) , regIndex(0)
, retryAttempts(MAX_RETRIES) , retryAttempts(MAX_RETRIES)