From 4935191335cd4f30db9e9dd82c535c3c4449a583 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 21 Apr 2023 18:43:21 +0000 Subject: [PATCH 1/9] Cleanup remove unused macros enable_e1 enable_e2 disable_e1 disable_e2 The firmware doesn't support multiple extruders No change in memory --- Firmware/Marlin.h | 32 -------------------------------- Firmware/Marlin_main.cpp | 22 ++++------------------ Firmware/planner.cpp | 7 +------ Firmware/ultralcd.cpp | 4 ---- 4 files changed, 5 insertions(+), 60 deletions(-) diff --git a/Firmware/Marlin.h b/Firmware/Marlin.h index d198d406f..c05a27261 100755 --- a/Firmware/Marlin.h +++ b/Firmware/Marlin.h @@ -181,21 +181,6 @@ void manage_inactivity(bool ignore_stepper_queue=false); #define disable_z() disable_force_z() #endif // PSU_Delta - -//#if defined(Z_ENABLE_PIN) && Z_ENABLE_PIN > -1 -//#ifdef Z_DUAL_STEPPER_DRIVERS -//#define enable_z() { WRITE(Z_ENABLE_PIN, Z_ENABLE_ON); WRITE(Z2_ENABLE_PIN, Z_ENABLE_ON); } -//#define disable_z() { WRITE(Z_ENABLE_PIN,!Z_ENABLE_ON); WRITE(Z2_ENABLE_PIN,!Z_ENABLE_ON); axis_known_position[Z_AXIS] = false; } -//#else -//#define enable_z() WRITE(Z_ENABLE_PIN, Z_ENABLE_ON) -//#define disable_z() { WRITE(Z_ENABLE_PIN,!Z_ENABLE_ON); axis_known_position[Z_AXIS] = false; } -//#endif -//#else -//#define enable_z() ; -//#define disable_z() ; -//#endif - - #if defined(E0_ENABLE_PIN) && (E0_ENABLE_PIN > -1) #define enable_e0() WRITE(E0_ENABLE_PIN, E_ENABLE_ON) #define disable_e0() WRITE(E0_ENABLE_PIN,!E_ENABLE_ON) @@ -204,23 +189,6 @@ void manage_inactivity(bool ignore_stepper_queue=false); #define disable_e0() /* nothing */ #endif -#if (EXTRUDERS > 1) && defined(E1_ENABLE_PIN) && (E1_ENABLE_PIN > -1) - #define enable_e1() WRITE(E1_ENABLE_PIN, E_ENABLE_ON) - #define disable_e1() WRITE(E1_ENABLE_PIN,!E_ENABLE_ON) -#else - #define enable_e1() /* nothing */ - #define disable_e1() /* nothing */ -#endif - -#if (EXTRUDERS > 2) && defined(E2_ENABLE_PIN) && (E2_ENABLE_PIN > -1) - #define enable_e2() WRITE(E2_ENABLE_PIN, E_ENABLE_ON) - #define disable_e2() WRITE(E2_ENABLE_PIN,!E_ENABLE_ON) -#else - #define enable_e2() /* nothing */ - #define disable_e2() /* nothing */ -#endif - - enum AxisEnum {X_AXIS=0, Y_AXIS=1, Z_AXIS=2, E_AXIS=3, X_HEAD=4, Y_HEAD=5}; #define X_AXIS_MASK 1 #define Y_AXIS_MASK 2 diff --git a/Firmware/Marlin_main.cpp b/Firmware/Marlin_main.cpp index 0bdd2b4a5..67e8e86a8 100644 --- a/Firmware/Marlin_main.cpp +++ b/Firmware/Marlin_main.cpp @@ -5269,8 +5269,6 @@ void process_commands() enable_y(); enable_z(); enable_e0(); - enable_e1(); - enable_e2(); break; #ifdef SDSUPPORT @@ -6275,22 +6273,16 @@ Sigma_Exit: { st_synchronize(); disable_e0(); - disable_e1(); - disable_e2(); finishAndDisableSteppers(); } else { st_synchronize(); - if (code_seen('X')) disable_x(); - if (code_seen('Y')) disable_y(); - if (code_seen('Z')) disable_z(); + if (code_seen('X')) disable_x(); + if (code_seen('Y')) disable_y(); + if (code_seen('Z')) disable_z(); #if ((E0_ENABLE_PIN != X_ENABLE_PIN) && (E1_ENABLE_PIN != Y_ENABLE_PIN)) // Only enable on boards that have seperate ENABLE_PINS - if (code_seen('E')) { - disable_e0(); - disable_e1(); - disable_e2(); - } + if (code_seen('E')) disable_e0(); #endif } } @@ -9370,8 +9362,6 @@ void manage_inactivity(bool ignore_stepper_queue/*=false*/) //default argument s disable_y(); disable_z(); disable_e0(); - disable_e1(); - disable_e2(); } } } @@ -9459,8 +9449,6 @@ void kill(const char *full_screen_message) { disable_y(); poweroff_z(); disable_e0(); - disable_e1(); - disable_e2(); SERIAL_ERROR_START; SERIAL_ERRORLNRPGM(PSTR("Printer halted. kill() called!")); @@ -9571,8 +9559,6 @@ void finishAndDisableSteppers() disable_y(); disable_z(); disable_e0(); - disable_e1(); - disable_e2(); #ifndef LA_NOCOMPAT // Steppers are disabled both when a print is stopped and also via M84 (which is additionally diff --git a/Firmware/planner.cpp b/Firmware/planner.cpp index 46b679793..001b2137b 100644 --- a/Firmware/planner.cpp +++ b/Firmware/planner.cpp @@ -554,12 +554,7 @@ void check_axes_activity() if((DISABLE_X) && (x_active == 0)) disable_x(); if((DISABLE_Y) && (y_active == 0)) disable_y(); if((DISABLE_Z) && (z_active == 0)) disable_z(); - if((DISABLE_E) && (e_active == 0)) - { - disable_e0(); - disable_e1(); - disable_e2(); - } + if((DISABLE_E) && (e_active == 0)) disable_e0(); #if defined(FAN_PIN) && FAN_PIN > -1 #ifdef FAN_KICKSTART_TIME static unsigned long fan_kick_end; diff --git a/Firmware/ultralcd.cpp b/Firmware/ultralcd.cpp index 62eb16971..83239aa9d 100644 --- a/Firmware/ultralcd.cpp +++ b/Firmware/ultralcd.cpp @@ -3188,8 +3188,6 @@ void lcd_temp_cal_show_result(bool result) { disable_y(); disable_z(); disable_e0(); - disable_e1(); - disable_e2(); setTargetBed(0); //set bed target temperature back to 0 // Store boolean result @@ -4947,8 +4945,6 @@ void unload_filament(float unloadLength) //disable extruder steppers so filament can be removed disable_e0(); - disable_e1(); - disable_e2(); _delay(100); Sound_MakeSound(e_SOUND_TYPE_StandardPrompt); From f539b406113eba44470b4a2bfeb446b9b243c358 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 21 Apr 2023 18:55:25 +0000 Subject: [PATCH 2/9] Remove more EXTRUDERS > 1 code --- Firmware/temperature.cpp | 159 +-------------------------------------- 1 file changed, 4 insertions(+), 155 deletions(-) diff --git a/Firmware/temperature.cpp b/Firmware/temperature.cpp index 58e6d1e6f..06b455bd4 100755 --- a/Firmware/temperature.cpp +++ b/Firmware/temperature.cpp @@ -797,48 +797,6 @@ void soft_pwm_init() } #endif //MAXTEMP -#if (EXTRUDERS > 1) && defined(HEATER_1_MINTEMP) - minttemp[1] = HEATER_1_MINTEMP; - while(analog2temp(minttemp_raw[1], 1) < HEATER_1_MINTEMP) { -#if HEATER_1_RAW_LO_TEMP < HEATER_1_RAW_HI_TEMP - minttemp_raw[1] += OVERSAMPLENR; -#else - minttemp_raw[1] -= OVERSAMPLENR; -#endif - } -#endif // MINTEMP 1 -#if (EXTRUDERS > 1) && defined(HEATER_1_MAXTEMP) - maxttemp[1] = HEATER_1_MAXTEMP; - while(analog2temp(maxttemp_raw[1], 1) > HEATER_1_MAXTEMP) { -#if HEATER_1_RAW_LO_TEMP < HEATER_1_RAW_HI_TEMP - maxttemp_raw[1] -= OVERSAMPLENR; -#else - maxttemp_raw[1] += OVERSAMPLENR; -#endif - } -#endif //MAXTEMP 1 - -#if (EXTRUDERS > 2) && defined(HEATER_2_MINTEMP) - minttemp[2] = HEATER_2_MINTEMP; - while(analog2temp(minttemp_raw[2], 2) < HEATER_2_MINTEMP) { -#if HEATER_2_RAW_LO_TEMP < HEATER_2_RAW_HI_TEMP - minttemp_raw[2] += OVERSAMPLENR; -#else - minttemp_raw[2] -= OVERSAMPLENR; -#endif - } -#endif //MINTEMP 2 -#if (EXTRUDERS > 2) && defined(HEATER_2_MAXTEMP) - maxttemp[2] = HEATER_2_MAXTEMP; - while(analog2temp(maxttemp_raw[2], 2) > HEATER_2_MAXTEMP) { -#if HEATER_2_RAW_LO_TEMP < HEATER_2_RAW_HI_TEMP - maxttemp_raw[2] -= OVERSAMPLENR; -#else - maxttemp_raw[2] += OVERSAMPLENR; -#endif - } -#endif //MAXTEMP 2 - #ifdef BED_MINTEMP while(analog2tempBed(bed_minttemp_raw) < BED_MINTEMP) { #if HEATER_BED_RAW_LO_TEMP < HEATER_BED_RAW_HI_TEMP @@ -1228,14 +1186,6 @@ FORCE_INLINE static void soft_pwm_core() WRITE(HEATER_1_PIN,1); #endif } else WRITE(HEATER_0_PIN,0); -#if EXTRUDERS > 1 - soft_pwm_1 = soft_pwm[1]; - if(soft_pwm_1 > 0) WRITE(HEATER_1_PIN,1); else WRITE(HEATER_1_PIN,0); -#endif -#if EXTRUDERS > 2 - soft_pwm_2 = soft_pwm[2]; - if(soft_pwm_2 > 0) WRITE(HEATER_2_PIN,1); else WRITE(HEATER_2_PIN,0); -#endif } #if defined(HEATER_BED_PIN) && HEATER_BED_PIN > -1 @@ -1272,13 +1222,6 @@ FORCE_INLINE static void soft_pwm_core() #endif } -#if EXTRUDERS > 1 - if(soft_pwm_1 < pwm_count) WRITE(HEATER_1_PIN,0); -#endif -#if EXTRUDERS > 2 - if(soft_pwm_2 < pwm_count) WRITE(HEATER_2_PIN,0); -#endif - #if 0 // @@DR #if defined(HEATER_BED_PIN) && HEATER_BED_PIN > -1 if (soft_pwm_b < (pwm_count & ((1 << HEATER_BED_SOFT_PWM_BITS) - 1))){ @@ -1333,59 +1276,7 @@ FORCE_INLINE static void soft_pwm_core() #endif } } - -#if EXTRUDERS > 1 - // EXTRUDER 1 - soft_pwm_1 = soft_pwm[1]; - if (soft_pwm_1 > 0) { - // turn ON heather only if the minimum time is up - if (state_timer_heater_1 == 0) { - // if change state set timer - if (state_heater_1 == 0) { - state_timer_heater_1 = MIN_STATE_TIME; - } - state_heater_1 = 1; - WRITE(HEATER_1_PIN, 1); - } - } else { - // turn OFF heather only if the minimum time is up - if (state_timer_heater_1 == 0) { - // if change state set timer - if (state_heater_1 == 1) { - state_timer_heater_1 = MIN_STATE_TIME; - } - state_heater_1 = 0; - WRITE(HEATER_1_PIN, 0); - } - } -#endif - -#if EXTRUDERS > 2 - // EXTRUDER 2 - soft_pwm_2 = soft_pwm[2]; - if (soft_pwm_2 > 0) { - // turn ON heather only if the minimum time is up - if (state_timer_heater_2 == 0) { - // if change state set timer - if (state_heater_2 == 0) { - state_timer_heater_2 = MIN_STATE_TIME; - } - state_heater_2 = 1; - WRITE(HEATER_2_PIN, 1); - } - } else { - // turn OFF heather only if the minimum time is up - if (state_timer_heater_2 == 0) { - // if change state set timer - if (state_heater_2 == 1) { - state_timer_heater_2 = MIN_STATE_TIME; - } - state_heater_2 = 0; - WRITE(HEATER_2_PIN, 0); - } - } -#endif - + #if defined(HEATER_BED_PIN) && HEATER_BED_PIN > -1 // BED soft_pwm_b = soft_pwm_bed; @@ -1428,37 +1319,7 @@ FORCE_INLINE static void soft_pwm_core() #endif } } - -#if EXTRUDERS > 1 - // EXTRUDER 1 - if (soft_pwm_1 < slow_pwm_count) { - // turn OFF heather only if the minimum time is up - if (state_timer_heater_1 == 0) { - // if change state set timer - if (state_heater_1 == 1) { - state_timer_heater_1 = MIN_STATE_TIME; - } - state_heater_1 = 0; - WRITE(HEATER_1_PIN, 0); - } - } -#endif - -#if EXTRUDERS > 2 - // EXTRUDER 2 - if (soft_pwm_2 < slow_pwm_count) { - // turn OFF heather only if the minimum time is up - if (state_timer_heater_2 == 0) { - // if change state set timer - if (state_heater_2 == 1) { - state_timer_heater_2 = MIN_STATE_TIME; - } - state_heater_2 = 0; - WRITE(HEATER_2_PIN, 0); - } - } -#endif - + #if defined(HEATER_BED_PIN) && HEATER_BED_PIN > -1 // BED if (soft_pwm_b < slow_pwm_count) { @@ -1493,20 +1354,8 @@ FORCE_INLINE static void soft_pwm_core() // Extruder 0 if (state_timer_heater_0 > 0) { state_timer_heater_0--; - } - -#if EXTRUDERS > 1 - // Extruder 1 - if (state_timer_heater_1 > 0) - state_timer_heater_1--; -#endif - -#if EXTRUDERS > 2 - // Extruder 2 - if (state_timer_heater_2 > 0) - state_timer_heater_2--; -#endif - + } + #if defined(HEATER_BED_PIN) && HEATER_BED_PIN > -1 // Bed if (state_timer_heater_b > 0) From fcabcd28044574ae53d9e1ff2e97123cc4e25a98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 21 Apr 2023 19:26:47 +0000 Subject: [PATCH 3/9] Remove TEMP_SENSOR_1 and TEMP_SENSOR_2 Hopefully I didn't miss anything --- Firmware/Configuration_adv.h | 22 ---- Firmware/temperature.cpp | 24 ++--- Firmware/thermistortables.h | 102 +++++------------- Firmware/ultralcd.cpp | 6 -- .../variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h | 6 -- .../variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h | 6 -- .../1_75mm_MK25S-RAMBo10a-E3Dv6full.h | 6 -- .../1_75mm_MK25S-RAMBo13a-E3Dv6full.h | 6 -- .../variants/1_75mm_MK3-EINSy10a-E3Dv6full.h | 6 -- .../variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h | 6 -- .../obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h | 6 -- .../obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h | 6 -- 12 files changed, 32 insertions(+), 170 deletions(-) diff --git a/Firmware/Configuration_adv.h b/Firmware/Configuration_adv.h index d115e558d..aa663228d 100644 --- a/Firmware/Configuration_adv.h +++ b/Firmware/Configuration_adv.h @@ -453,14 +453,6 @@ const unsigned int dropsegments=5; //everything with less than this number of st #define THERMISTORHEATER_0 TEMP_SENSOR_0 #define HEATER_0_USES_THERMISTOR #endif -#if TEMP_SENSOR_1 > 0 - #define THERMISTORHEATER_1 TEMP_SENSOR_1 - #define HEATER_1_USES_THERMISTOR -#endif -#if TEMP_SENSOR_2 > 0 - #define THERMISTORHEATER_2 TEMP_SENSOR_2 - #define HEATER_2_USES_THERMISTOR -#endif #if TEMP_SENSOR_BED > 0 #define THERMISTORBED TEMP_SENSOR_BED #define BED_USES_THERMISTOR @@ -474,12 +466,6 @@ const unsigned int dropsegments=5; //everything with less than this number of st #if TEMP_SENSOR_0 == -1 #define HEATER_0_USES_AD595 #endif -#if TEMP_SENSOR_1 == -1 - #define HEATER_1_USES_AD595 -#endif -#if TEMP_SENSOR_2 == -1 - #define HEATER_2_USES_AD595 -#endif #if TEMP_SENSOR_BED == -1 #define BED_USES_AD595 #endif @@ -490,14 +476,6 @@ const unsigned int dropsegments=5; //everything with less than this number of st #undef HEATER_0_MINTEMP #undef HEATER_0_MAXTEMP #endif -#if TEMP_SENSOR_1 == 0 - #undef HEATER_1_MINTEMP - #undef HEATER_1_MAXTEMP -#endif -#if TEMP_SENSOR_2 == 0 - #undef HEATER_2_MINTEMP - #undef HEATER_2_MAXTEMP -#endif #if TEMP_SENSOR_BED == 0 #undef BED_MINTEMP #undef BED_MAXTEMP diff --git a/Firmware/temperature.cpp b/Firmware/temperature.cpp index 06b455bd4..df5b1a222 100755 --- a/Firmware/temperature.cpp +++ b/Firmware/temperature.cpp @@ -189,21 +189,13 @@ static volatile bool temp_meas_ready = false; #endif uint8_t fanSpeedBckp = 255; -#if EXTRUDERS > 3 - # error Unsupported number of extruders -#elif EXTRUDERS > 2 - # define ARRAY_BY_EXTRUDERS(v1, v2, v3) { v1, v2, v3 } -#elif EXTRUDERS > 1 - # define ARRAY_BY_EXTRUDERS(v1, v2, v3) { v1, v2 } -#else - # define ARRAY_BY_EXTRUDERS(v1, v2, v3) { v1 } -#endif +#define ARRAY_BY_EXTRUDERS(v1 ) { v1 } // Init min and max temp with extreme values to prevent false errors during startup -static int minttemp_raw[EXTRUDERS] = ARRAY_BY_EXTRUDERS( HEATER_0_RAW_LO_TEMP , HEATER_1_RAW_LO_TEMP , HEATER_2_RAW_LO_TEMP ); -static int maxttemp_raw[EXTRUDERS] = ARRAY_BY_EXTRUDERS( HEATER_0_RAW_HI_TEMP , HEATER_1_RAW_HI_TEMP , HEATER_2_RAW_HI_TEMP ); -static int minttemp[EXTRUDERS] = ARRAY_BY_EXTRUDERS( 0, 0, 0 ); -static int maxttemp[EXTRUDERS] = ARRAY_BY_EXTRUDERS( 16383, 16383, 16383 ); +static int minttemp_raw[EXTRUDERS] = ARRAY_BY_EXTRUDERS( HEATER_0_RAW_LO_TEMP ); +static int maxttemp_raw[EXTRUDERS] = ARRAY_BY_EXTRUDERS( HEATER_0_RAW_HI_TEMP ); +static int minttemp[EXTRUDERS] = ARRAY_BY_EXTRUDERS( 0 ); +static int maxttemp[EXTRUDERS] = ARRAY_BY_EXTRUDERS( 16383 ); #ifdef BED_MINTEMP static int bed_minttemp_raw = HEATER_BED_RAW_LO_TEMP; #endif @@ -217,8 +209,8 @@ static int ambient_minttemp_raw = AMBIENT_RAW_LO_TEMP; static int ambient_maxttemp_raw = AMBIENT_RAW_HI_TEMP; #endif -static void *heater_ttbl_map[EXTRUDERS] = ARRAY_BY_EXTRUDERS( (void *)HEATER_0_TEMPTABLE, (void *)HEATER_1_TEMPTABLE, (void *)HEATER_2_TEMPTABLE ); -static uint8_t heater_ttbllen_map[EXTRUDERS] = ARRAY_BY_EXTRUDERS( HEATER_0_TEMPTABLE_LEN, HEATER_1_TEMPTABLE_LEN, HEATER_2_TEMPTABLE_LEN ); +static void *heater_ttbl_map[EXTRUDERS] = ARRAY_BY_EXTRUDERS( (void *)HEATER_0_TEMPTABLE ); +static uint8_t heater_ttbllen_map[EXTRUDERS] = ARRAY_BY_EXTRUDERS( HEATER_0_TEMPTABLE_LEN ); static float analog2temp(int raw, uint8_t e); static float analog2tempBed(int raw); @@ -714,7 +706,7 @@ static float analog2tempAmbient(int raw) void soft_pwm_init() { -#if MB(RUMBA) && ((TEMP_SENSOR_0==-1)||(TEMP_SENSOR_1==-1)||(TEMP_SENSOR_2==-1)||(TEMP_SENSOR_BED==-1)) +#if MB(RUMBA) && ((TEMP_SENSOR_0==-1) || (TEMP_SENSOR_BED==-1)) //disable RUMBA JTAG in case the thermocouple extension is plugged on top of JTAG connector MCUCR=(1<USHRT_MAX #error "Check maximal allowed value @ ShortTimer (see HEATER_MINTEMP_DELAY definition)" @@ -184,8 +182,6 @@ #else #define HEATER_0_MAXTEMP 305 #endif -#define HEATER_1_MAXTEMP 305 -#define HEATER_2_MAXTEMP 305 #define BED_MAXTEMP 125 #if defined(E3D_PT100_EXTRUDER_WITH_AMP) || defined(E3D_PT100_EXTRUDER_NO_AMP) @@ -437,8 +433,6 @@ #else #define TEMP_SENSOR_0 5 #endif -#define TEMP_SENSOR_1 0 -#define TEMP_SENSOR_2 0 #if defined(E3D_PT100_BED_WITH_AMP) #define TEMP_SENSOR_BED 247 #elif defined(E3D_PT100_BED_NO_AMP) diff --git a/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h index 3cd87e2af..a646a5d85 100644 --- a/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h @@ -164,8 +164,6 @@ // Mintemps #define HEATER_0_MINTEMP 30 -#define HEATER_1_MINTEMP 5 -#define HEATER_2_MINTEMP 5 #define HEATER_MINTEMP_DELAY 15000 // [ms] ! if changed, check maximal allowed value @ ShortTimer #if HEATER_MINTEMP_DELAY>USHRT_MAX #error "Check maximal allowed value @ ShortTimer (see HEATER_MINTEMP_DELAY definition)" @@ -185,8 +183,6 @@ #else #define HEATER_0_MAXTEMP 305 #endif -#define HEATER_1_MAXTEMP 305 -#define HEATER_2_MAXTEMP 305 #define BED_MAXTEMP 125 #if defined(E3D_PT100_EXTRUDER_WITH_AMP) || defined(E3D_PT100_EXTRUDER_NO_AMP) @@ -438,8 +434,6 @@ #else #define TEMP_SENSOR_0 5 #endif -#define TEMP_SENSOR_1 0 -#define TEMP_SENSOR_2 0 #if defined(E3D_PT100_BED_WITH_AMP) #define TEMP_SENSOR_BED 247 #elif defined(E3D_PT100_BED_NO_AMP) diff --git a/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h index 480f7b9b5..19848f3d8 100644 --- a/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h @@ -163,8 +163,6 @@ // Mintemps #define HEATER_0_MINTEMP 30 -#define HEATER_1_MINTEMP 5 -#define HEATER_2_MINTEMP 5 #define HEATER_MINTEMP_DELAY 15000 // [ms] ! if changed, check maximal allowed value @ ShortTimer #if HEATER_MINTEMP_DELAY>USHRT_MAX #error "Check maximal allowed value @ ShortTimer (see HEATER_MINTEMP_DELAY definition)" @@ -184,8 +182,6 @@ #else #define HEATER_0_MAXTEMP 305 #endif -#define HEATER_1_MAXTEMP 305 -#define HEATER_2_MAXTEMP 305 #define BED_MAXTEMP 125 #if defined(E3D_PT100_EXTRUDER_WITH_AMP) || defined(E3D_PT100_EXTRUDER_NO_AMP) @@ -437,8 +433,6 @@ #else #define TEMP_SENSOR_0 5 #endif -#define TEMP_SENSOR_1 0 -#define TEMP_SENSOR_2 0 #if defined(E3D_PT100_BED_WITH_AMP) #define TEMP_SENSOR_BED 247 #elif defined(E3D_PT100_BED_NO_AMP) diff --git a/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h index 387a03507..71dac5cf7 100644 --- a/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h @@ -164,8 +164,6 @@ // Mintemps #define HEATER_0_MINTEMP 30 -#define HEATER_1_MINTEMP 5 -#define HEATER_2_MINTEMP 5 #define HEATER_MINTEMP_DELAY 15000 // [ms] ! if changed, check maximal allowed value @ ShortTimer #if HEATER_MINTEMP_DELAY>USHRT_MAX #error "Check maximal allowed value @ ShortTimer (see HEATER_MINTEMP_DELAY definition)" @@ -185,8 +183,6 @@ #else #define HEATER_0_MAXTEMP 305 #endif -#define HEATER_1_MAXTEMP 305 -#define HEATER_2_MAXTEMP 305 #define BED_MAXTEMP 125 #if defined(E3D_PT100_EXTRUDER_WITH_AMP) || defined(E3D_PT100_EXTRUDER_NO_AMP) @@ -438,8 +434,6 @@ #else #define TEMP_SENSOR_0 5 #endif -#define TEMP_SENSOR_1 0 -#define TEMP_SENSOR_2 0 #if defined(E3D_PT100_BED_WITH_AMP) #define TEMP_SENSOR_BED 247 #elif defined(E3D_PT100_BED_NO_AMP) diff --git a/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h index 070d63ef1..5a11c881c 100644 --- a/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h @@ -300,8 +300,6 @@ // Mintemps #define HEATER_0_MINTEMP 10 -#define HEATER_1_MINTEMP 5 -#define HEATER_2_MINTEMP 5 #define HEATER_MINTEMP_DELAY 15000 // [ms] ! if changed, check maximal allowed value @ ShortTimer #if HEATER_MINTEMP_DELAY>USHRT_MAX #error "Check maximal allowed value @ ShortTimer (see HEATER_MINTEMP_DELAY definition)" @@ -322,8 +320,6 @@ #else #define HEATER_0_MAXTEMP 305 #endif -#define HEATER_1_MAXTEMP 305 -#define HEATER_2_MAXTEMP 305 #define BED_MAXTEMP 125 #define AMBIENT_MAXTEMP 100 @@ -588,8 +584,6 @@ #else #define TEMP_SENSOR_0 5 #endif -#define TEMP_SENSOR_1 0 -#define TEMP_SENSOR_2 0 #if defined(E3D_PT100_BED_WITH_AMP) #define TEMP_SENSOR_BED 247 #elif defined(E3D_PT100_BED_NO_AMP) diff --git a/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h index 12d8971a0..6571f72cb 100644 --- a/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h @@ -302,8 +302,6 @@ // Mintemps #define HEATER_0_MINTEMP 10 -#define HEATER_1_MINTEMP 5 -#define HEATER_2_MINTEMP 5 #define HEATER_MINTEMP_DELAY 15000 // [ms] ! if changed, check maximal allowed value @ ShortTimer #if HEATER_MINTEMP_DELAY>USHRT_MAX #error "Check maximal allowed value @ ShortTimer (see HEATER_MINTEMP_DELAY definition)" @@ -324,8 +322,6 @@ #else #define HEATER_0_MAXTEMP 305 #endif -#define HEATER_1_MAXTEMP 305 -#define HEATER_2_MAXTEMP 305 #define BED_MAXTEMP 125 #define AMBIENT_MAXTEMP 100 @@ -592,8 +588,6 @@ #else #define TEMP_SENSOR_0 5 #endif -#define TEMP_SENSOR_1 0 -#define TEMP_SENSOR_2 0 #if defined(E3D_PT100_BED_WITH_AMP) #define TEMP_SENSOR_BED 247 #elif defined(E3D_PT100_BED_NO_AMP) diff --git a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h index 3851e2220..4a3ba4011 100644 --- a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h +++ b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h @@ -102,8 +102,6 @@ EXTRUDER SETTINGS // Mintemps #define HEATER_0_MINTEMP 30 -#define HEATER_1_MINTEMP 5 -#define HEATER_2_MINTEMP 5 #define HEATER_MINTEMP_DELAY 15000 // [ms] ! if changed, check maximal allowed value @ ShortTimer #if HEATER_MINTEMP_DELAY>USHRT_MAX #error "Check maximal allowed value @ ShortTimer (see HEATER_MINTEMP_DELAY definition)" @@ -120,8 +118,6 @@ EXTRUDER SETTINGS #else #define HEATER_0_MAXTEMP 305 #endif -#define HEATER_1_MAXTEMP 305 -#define HEATER_2_MAXTEMP 305 #define BED_MAXTEMP 150 #if defined(E3D_PT100_EXTRUDER_WITH_AMP) || defined(E3D_PT100_EXTRUDER_NO_AMP) @@ -367,8 +363,6 @@ THERMISTORS SETTINGS #else #define TEMP_SENSOR_0 5 #endif -#define TEMP_SENSOR_1 0 -#define TEMP_SENSOR_2 0 #if defined(E3D_PT100_BED_WITH_AMP) #define TEMP_SENSOR_BED 247 #elif defined(E3D_PT100_BED_NO_AMP) diff --git a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h index 9dc206959..10e9f71c4 100644 --- a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h +++ b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h @@ -101,8 +101,6 @@ EXTRUDER SETTINGS // Mintemps #define HEATER_0_MINTEMP 30 -#define HEATER_1_MINTEMP 5 -#define HEATER_2_MINTEMP 5 #define HEATER_MINTEMP_DELAY 15000 // [ms] ! if changed, check maximal allowed value @ ShortTimer #if HEATER_MINTEMP_DELAY>USHRT_MAX #error "Check maximal allowed value @ ShortTimer (see HEATER_MINTEMP_DELAY definition)" @@ -119,8 +117,6 @@ EXTRUDER SETTINGS #else #define HEATER_0_MAXTEMP 305 #endif -#define HEATER_1_MAXTEMP 305 -#define HEATER_2_MAXTEMP 305 #define BED_MAXTEMP 150 #if defined(E3D_PT100_EXTRUDER_WITH_AMP) || defined(E3D_PT100_EXTRUDER_NO_AMP) @@ -366,8 +362,6 @@ THERMISTORS SETTINGS #else #define TEMP_SENSOR_0 5 #endif -#define TEMP_SENSOR_1 0 -#define TEMP_SENSOR_2 0 #if defined(E3D_PT100_BED_WITH_AMP) #define TEMP_SENSOR_BED 247 #elif defined(E3D_PT100_BED_NO_AMP) From 327b5b230b0526038a2a1b12166cddcdb37e8fb8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 21 Apr 2023 20:30:32 +0000 Subject: [PATCH 4/9] Remove soft_pwm_1 and soft_pwm_2 --- Firmware/temperature.cpp | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/Firmware/temperature.cpp b/Firmware/temperature.cpp index df5b1a222..07192c0e1 100755 --- a/Firmware/temperature.cpp +++ b/Firmware/temperature.cpp @@ -1142,20 +1142,6 @@ FORCE_INLINE static void soft_pwm_core() static unsigned char state_heater_0 = 0; static unsigned char state_timer_heater_0 = 0; #endif -#if (EXTRUDERS > 1) || defined(HEATERS_PARALLEL) - static unsigned char soft_pwm_1; -#ifdef SLOW_PWM_HEATERS - static unsigned char state_heater_1 = 0; - static unsigned char state_timer_heater_1 = 0; -#endif -#endif -#if EXTRUDERS > 2 - static unsigned char soft_pwm_2; -#ifdef SLOW_PWM_HEATERS - static unsigned char state_heater_2 = 0; - static unsigned char state_timer_heater_2 = 0; -#endif -#endif #if HEATER_BED_PIN > -1 // @@DR static unsigned char soft_pwm_b; #ifdef SLOW_PWM_HEATERS From c14332bfb2c6a1282e40dee4513a8de983b9a1bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 21 Apr 2023 20:34:45 +0000 Subject: [PATCH 5/9] Combine two ifdefs --- Firmware/temperature.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Firmware/temperature.cpp b/Firmware/temperature.cpp index 07192c0e1..3d25961bc 100755 --- a/Firmware/temperature.cpp +++ b/Firmware/temperature.cpp @@ -1141,14 +1141,11 @@ FORCE_INLINE static void soft_pwm_core() static unsigned char slow_pwm_count = 0; static unsigned char state_heater_0 = 0; static unsigned char state_timer_heater_0 = 0; -#endif #if HEATER_BED_PIN > -1 - // @@DR static unsigned char soft_pwm_b; -#ifdef SLOW_PWM_HEATERS static unsigned char state_heater_b = 0; static unsigned char state_timer_heater_b = 0; -#endif -#endif +#endif // HEATER_BED_PIN > -1 +#endif // SLOW_PWM_HEATERS #ifndef SLOW_PWM_HEATERS /* From 25522d3d68b70e883892cb15222d08c0fdbd0836 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 21 Apr 2023 20:44:55 +0000 Subject: [PATCH 6/9] Remove unused Autofan extruder configs --- Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h | 2 -- Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h | 2 -- Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h | 2 -- 8 files changed, 16 deletions(-) diff --git a/Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h index 38e0505cf..0374ce209 100644 --- a/Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h @@ -204,8 +204,6 @@ // Extruder cooling fans #define EXTRUDER_0_AUTO_FAN_PIN 8 -#define EXTRUDER_1_AUTO_FAN_PIN -1 -#define EXTRUDER_2_AUTO_FAN_PIN -1 #define EXTRUDER_AUTO_FAN_TEMPERATURE 50 #define EXTRUDER_AUTO_FAN_SPEED 255 // == full speed diff --git a/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h index a646a5d85..2bb180eed 100644 --- a/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h @@ -205,8 +205,6 @@ // Extruder cooling fans #define EXTRUDER_0_AUTO_FAN_PIN 8 -#define EXTRUDER_1_AUTO_FAN_PIN -1 -#define EXTRUDER_2_AUTO_FAN_PIN -1 #define EXTRUDER_AUTO_FAN_TEMPERATURE 50 #define EXTRUDER_AUTO_FAN_SPEED 255 // == full speed diff --git a/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h index 19848f3d8..581546061 100644 --- a/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h @@ -204,8 +204,6 @@ // Extruder cooling fans #define EXTRUDER_0_AUTO_FAN_PIN 8 -#define EXTRUDER_1_AUTO_FAN_PIN -1 -#define EXTRUDER_2_AUTO_FAN_PIN -1 #define EXTRUDER_AUTO_FAN_TEMPERATURE 50 #define EXTRUDER_AUTO_FAN_SPEED 255 // == full speed diff --git a/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h index 71dac5cf7..af1fe3632 100644 --- a/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h @@ -205,8 +205,6 @@ // Extruder cooling fans #define EXTRUDER_0_AUTO_FAN_PIN 8 -#define EXTRUDER_1_AUTO_FAN_PIN -1 -#define EXTRUDER_2_AUTO_FAN_PIN -1 #define EXTRUDER_AUTO_FAN_TEMPERATURE 50 #define EXTRUDER_AUTO_FAN_SPEED 255 // == full speed diff --git a/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h index 5a11c881c..fa59c5fa7 100644 --- a/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h @@ -343,8 +343,6 @@ // Extruder cooling fans #define EXTRUDER_0_AUTO_FAN_PIN 8 -#define EXTRUDER_1_AUTO_FAN_PIN -1 -#define EXTRUDER_2_AUTO_FAN_PIN -1 #define EXTRUDER_AUTO_FAN_TEMPERATURE 50 #define EXTRUDER_AUTO_FAN_SPEED 255 // == full speed diff --git a/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h index 6571f72cb..c7c918fb4 100644 --- a/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h @@ -345,8 +345,6 @@ // Extruder cooling fans #define EXTRUDER_0_AUTO_FAN_PIN 8 -#define EXTRUDER_1_AUTO_FAN_PIN -1 -#define EXTRUDER_2_AUTO_FAN_PIN -1 #define EXTRUDER_AUTO_FAN_TEMPERATURE 50 #define EXTRUDER_AUTO_FAN_SPEED 255 // == full speed #define EXTRUDER_ALTFAN_DETECT diff --git a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h index 4a3ba4011..ff091f35f 100644 --- a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h +++ b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h @@ -137,8 +137,6 @@ EXTRUDER SETTINGS // Extruder cooling fans #define EXTRUDER_0_AUTO_FAN_PIN 8 -#define EXTRUDER_1_AUTO_FAN_PIN -1 -#define EXTRUDER_2_AUTO_FAN_PIN -1 #define EXTRUDER_AUTO_FAN_TEMPERATURE 50 #define EXTRUDER_AUTO_FAN_SPEED 255 // == full speed diff --git a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h index 10e9f71c4..a02348d62 100644 --- a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h +++ b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h @@ -136,8 +136,6 @@ EXTRUDER SETTINGS // Extruder cooling fans #define EXTRUDER_0_AUTO_FAN_PIN 8 -#define EXTRUDER_1_AUTO_FAN_PIN -1 -#define EXTRUDER_2_AUTO_FAN_PIN -1 #define EXTRUDER_AUTO_FAN_TEMPERATURE 50 #define EXTRUDER_AUTO_FAN_SPEED 255 // == full speed From c7f0ee13bee6198b02e8c6649683af8a9b9f5b60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 21 Apr 2023 20:52:36 +0000 Subject: [PATCH 7/9] Missed these macros disable_e1/2 --- Firmware/Marlin_main.cpp | 20 ++------------------ Firmware/stepper.cpp | 24 ------------------------ Firmware/temperature.cpp | 14 +------------- 3 files changed, 3 insertions(+), 55 deletions(-) diff --git a/Firmware/Marlin_main.cpp b/Firmware/Marlin_main.cpp index 67e8e86a8..ce66afc25 100644 --- a/Firmware/Marlin_main.cpp +++ b/Firmware/Marlin_main.cpp @@ -4938,8 +4938,6 @@ void process_commands() disable_y(); disable_z(); disable_e0(); - disable_e1(); - disable_e2(); setTargetBed(0); //set bed target temperature back to 0 lcd_show_fullscreen_message_and_wait_P(_T(MSG_PINDA_CALIBRATION_DONE)); eeprom_update_byte((unsigned char *)EEPROM_TEMP_CAL_ACTIVE, 1); @@ -6209,8 +6207,6 @@ Sigma_Exit: disable_heater(); st_synchronize(); disable_e0(); - disable_e1(); - disable_e2(); finishAndDisableSteppers(); fanSpeed = 0; _delay(1000); // Wait a little before to switch off @@ -6281,9 +6277,9 @@ Sigma_Exit: if (code_seen('X')) disable_x(); if (code_seen('Y')) disable_y(); if (code_seen('Z')) disable_z(); -#if ((E0_ENABLE_PIN != X_ENABLE_PIN) && (E1_ENABLE_PIN != Y_ENABLE_PIN)) // Only enable on boards that have seperate ENABLE_PINS +#if (E0_ENABLE_PIN != X_ENABLE_PIN) // Only enable on boards that have seperate ENABLE_PINS if (code_seen('E')) disable_e0(); - #endif +#endif } } break; @@ -9269,15 +9265,6 @@ void controllerFan() lastMotorCheck = _millis(); if(!READ(X_ENABLE_PIN) || !READ(Y_ENABLE_PIN) || !READ(Z_ENABLE_PIN) || (soft_pwm_bed > 0) - #if EXTRUDERS > 2 - || !READ(E2_ENABLE_PIN) - #endif - #if EXTRUDER > 1 - #if defined(X2_ENABLE_PIN) && X2_ENABLE_PIN > -1 - || !READ(X2_ENABLE_PIN) - #endif - || !READ(E1_ENABLE_PIN) - #endif || !READ(E0_ENABLE_PIN)) //If any of the drivers are enabled... { lastMotor = _millis(); //... set time to NOW so the fan will turn on @@ -9310,9 +9297,6 @@ void controllerFan() */ static void handleSafetyTimer() { -#if (EXTRUDERS > 1) -#error Implemented only for one extruder. -#endif //(EXTRUDERS > 1) if (printer_active() || (!degTargetBed() && !degTargetHotend(0)) || (!safetytimer_inactive_time)) { safetyTimer.stop(); diff --git a/Firmware/stepper.cpp b/Firmware/stepper.cpp index 758e0dcdb..3e7e4c72c 100644 --- a/Firmware/stepper.cpp +++ b/Firmware/stepper.cpp @@ -1102,12 +1102,6 @@ void st_init() #if defined(E0_DIR_PIN) && E0_DIR_PIN > -1 SET_OUTPUT(E0_DIR_PIN); #endif - #if defined(E1_DIR_PIN) && (E1_DIR_PIN > -1) - SET_OUTPUT(E1_DIR_PIN); - #endif - #if defined(E2_DIR_PIN) && (E2_DIR_PIN > -1) - SET_OUTPUT(E2_DIR_PIN); - #endif //Initialize Enable Pins - steppers default to disabled. @@ -1141,14 +1135,6 @@ void st_init() SET_OUTPUT(E0_ENABLE_PIN); if(!E_ENABLE_ON) WRITE(E0_ENABLE_PIN,HIGH); #endif - #if defined(E1_ENABLE_PIN) && (E1_ENABLE_PIN > -1) - SET_OUTPUT(E1_ENABLE_PIN); - if(!E_ENABLE_ON) WRITE(E1_ENABLE_PIN,HIGH); - #endif - #if defined(E2_ENABLE_PIN) && (E2_ENABLE_PIN > -1) - SET_OUTPUT(E2_ENABLE_PIN); - if(!E_ENABLE_ON) WRITE(E2_ENABLE_PIN,HIGH); - #endif //endstops and pullups #if defined(X_MIN_PIN) && X_MIN_PIN > -1 @@ -1246,16 +1232,6 @@ void st_init() WRITE(E0_STEP_PIN,INVERT_E_STEP_PIN); disable_e0(); #endif - #if defined(E1_STEP_PIN) && (E1_STEP_PIN > -1) - SET_OUTPUT(E1_STEP_PIN); - WRITE(E1_STEP_PIN,INVERT_E_STEP_PIN); - disable_e1(); - #endif - #if defined(E2_STEP_PIN) && (E2_STEP_PIN > -1) - SET_OUTPUT(E2_STEP_PIN); - WRITE(E2_STEP_PIN,INVERT_E_STEP_PIN); - disable_e2(); - #endif // waveform generation = 0100 = CTC TCCR1B &= ~(1< -1) SET_OUTPUT(HEATER_0_PIN); - #endif - #if defined(HEATER_1_PIN) && (HEATER_1_PIN > -1) - SET_OUTPUT(HEATER_1_PIN); - #endif - #if defined(HEATER_2_PIN) && (HEATER_2_PIN > -1) - SET_OUTPUT(HEATER_2_PIN); - #endif + #endif #if defined(HEATER_BED_PIN) && (HEATER_BED_PIN > -1) SET_OUTPUT(HEATER_BED_PIN); #endif @@ -2027,12 +2021,6 @@ void disable_heater() #if defined(HEATER_0_PIN) && HEATER_0_PIN > -1 && EXTRUDERS > 0 WRITE(HEATER_0_PIN,LOW); #endif -#if defined(HEATER_1_PIN) && HEATER_1_PIN > -1 && EXTRUDERS > 1 - WRITE(HEATER_1_PIN,LOW); -#endif -#if defined(HEATER_2_PIN) && HEATER_2_PIN > -1 && EXTRUDERS > 2 - WRITE(HEATER_2_PIN,LOW); -#endif #if defined(HEATER_BED_PIN) && HEATER_BED_PIN > -1 // TODO: this doesn't take immediate effect! timer02_set_pwm0(0); From 0cf0d40a2e3c77ad5bec80b1905693580bffed64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Fri, 21 Apr 2023 21:14:19 +0000 Subject: [PATCH 8/9] Remove checkAllHotends() --- Firmware/temperature.cpp | 8 -------- Firmware/temperature.h | 4 +--- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/Firmware/temperature.cpp b/Firmware/temperature.cpp index 53f5fe6c5..7672d7f2e 100755 --- a/Firmware/temperature.cpp +++ b/Firmware/temperature.cpp @@ -244,14 +244,6 @@ static void temp_runaway_check(uint8_t _heater_id, float _target_temperature, fl static void temp_runaway_stop(bool isPreheat, bool isBed); #endif -// return "false", if all extruder-heaters are 'off' (ie. "true", if any heater is 'on') -bool checkAllHotends(void) -{ - bool result=false; - for(int i=0;i Date: Sat, 22 Apr 2023 12:32:56 +0000 Subject: [PATCH 9/9] Remove INVERT_E1_DIR and INVERT_E2_DIR from config I think these should be removed from the configuration files as these definitions don't do anything. --- Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h | 2 -- Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h | 2 -- Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h | 3 --- Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h | 3 --- 8 files changed, 18 deletions(-) diff --git a/Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h index 0374ce209..d227f54af 100644 --- a/Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25-RAMBo10a-E3Dv6full.h @@ -50,8 +50,6 @@ #define INVERT_Y_DIR 0 // for Mendel set to 1, for Orca set to 0 #define INVERT_Z_DIR 0 // for Mendel set to 0, for Orca set to 1 #define INVERT_E0_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E1_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E2_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 // Home position #define MANUAL_X_HOME_POS 0 diff --git a/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h index 2bb180eed..33217ad65 100644 --- a/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25-RAMBo13a-E3Dv6full.h @@ -50,8 +50,6 @@ #define INVERT_Y_DIR 0 // for Mendel set to 1, for Orca set to 0 #define INVERT_Z_DIR 0 // for Mendel set to 0, for Orca set to 1 #define INVERT_E0_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E1_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E2_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 // Home position #define MANUAL_X_HOME_POS 0 diff --git a/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h index 581546061..6b0d3e8a7 100644 --- a/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25S-RAMBo10a-E3Dv6full.h @@ -50,8 +50,6 @@ #define INVERT_Y_DIR 0 // for Mendel set to 1, for Orca set to 0 #define INVERT_Z_DIR 0 // for Mendel set to 0, for Orca set to 1 #define INVERT_E0_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E1_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E2_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 // Home position #define MANUAL_X_HOME_POS 0 diff --git a/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h b/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h index af1fe3632..692616786 100644 --- a/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK25S-RAMBo13a-E3Dv6full.h @@ -50,8 +50,6 @@ #define INVERT_Y_DIR 0 // for Mendel set to 1, for Orca set to 0 #define INVERT_Z_DIR 0 // for Mendel set to 0, for Orca set to 1 #define INVERT_E0_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E1_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E2_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 // Home position #define MANUAL_X_HOME_POS 0 diff --git a/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h index fa59c5fa7..dffc509d3 100644 --- a/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK3-EINSy10a-E3Dv6full.h @@ -52,8 +52,6 @@ #define INVERT_Y_DIR 0 // for Mendel set to 1, for Orca set to 0 #define INVERT_Z_DIR 1 // for Mendel set to 0, for Orca set to 1 #define INVERT_E0_DIR 0 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E1_DIR 0 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E2_DIR 0 // for direct drive extruder v9 set to 1, for geared extruder set to 0 // Home position #define MANUAL_X_HOME_POS 0 diff --git a/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h b/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h index c7c918fb4..3a2a1359c 100644 --- a/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h +++ b/Firmware/variants/1_75mm_MK3S-EINSy10a-E3Dv6full.h @@ -54,8 +54,6 @@ #define INVERT_Y_DIR 0 // for Mendel set to 1, for Orca set to 0 #define INVERT_Z_DIR 1 // for Mendel set to 0, for Orca set to 1 #define INVERT_E0_DIR 0 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E1_DIR 0 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E2_DIR 0 // for direct drive extruder v9 set to 1, for geared extruder set to 0 // Home position #define MANUAL_X_HOME_POS 0 diff --git a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h index ff091f35f..31ded6c88 100644 --- a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h +++ b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h @@ -46,9 +46,6 @@ AXIS SETTINGS #define INVERT_Y_DIR 0 // for Mendel set to 1, for Orca set to 0 #define INVERT_Z_DIR 0 // for Mendel set to 0, for Orca set to 1 #define INVERT_E0_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E1_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E2_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 - // Home position #define MANUAL_X_HOME_POS 0 diff --git a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h index a02348d62..9a8086739 100644 --- a/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h +++ b/Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h @@ -46,9 +46,6 @@ AXIS SETTINGS #define INVERT_Y_DIR 0 // for Mendel set to 1, for Orca set to 0 #define INVERT_Z_DIR 0 // for Mendel set to 0, for Orca set to 1 #define INVERT_E0_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E1_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 -#define INVERT_E2_DIR 1 // for direct drive extruder v9 set to 1, for geared extruder set to 0 - // Home position #define MANUAL_X_HOME_POS 0