Alex Voinea
1342db3532
Merge pull request #3257 from gudnimg/lcd-optimisation-gudni
...
Remove redundant operations on LCD CGRAM
2022-02-09 08:09:48 +01:00
Alex Voinea
aab094ff4f
Merge pull request #3292 from gudnimg/fix-pinda-thermistor-build-fail
...
Fix build error if `PINDA_THERMISTOR` is not defined
2022-02-09 07:54:42 +01:00
3d-gussner
e6703125ec
Merge pull request #3268 from gudnimg/lcd_button_update_gudni
...
Remove one call to `lcd_timeoutToStatus.start`
2022-02-09 07:37:36 +01:00
Alex Voinea
234add3c58
Merge branch 'MK3' into lcd-optimisation-gudni
2022-02-08 00:14:59 +01:00
Guðni Már Gilbert
121324d20b
Revert "Remove one space from Support -> Temperatures menu"
...
This reverts commit 158877e736 .
2022-02-08 00:09:09 +01:00
Alex Voinea
2b18357fef
Merge pull request #3375 from leptun/MK3_arduino_1.8.13
...
Fix arduino 1.8.13 warnings
2022-02-07 17:27:13 +01:00
Alex Voinea
9c3c47ea29
Merge pull request #3253 from gudnimg/sd-sub-dir-fix
...
Fix edge case when SD card is inserted while user is inside the 'No SD card' submenu
2022-02-07 17:09:14 +01:00
3d-gussner
75d6942d81
Merge pull request #2836 from wavexx/remove_jerk_limits
...
Remove hard-coded X/Y jerk limits
2022-02-07 17:04:49 +01:00
3d-gussner
0d4d386991
Merge pull request #3228 from gudnimg/remove-mmu_lcd
...
Remove a few redundant lines from ultralcd code
2022-02-07 17:04:34 +01:00
Guðni Már Gilbert
ff00988303
Revert "Replace hardcoded values and optimise strings"
...
This reverts commit e62bc4686f .
2022-02-06 11:09:45 +01:00
Alex Voinea
670214a30b
Fix indentation
2022-02-06 11:01:35 +01:00
Guðni Már Gilbert
c6ecc0dfc9
Merge branch 'prusa3d:MK3' into lcd-optimisation-gudni
2022-02-06 09:54:58 +00:00
Guðni Már Gilbert
a22a7ea9d7
Change LCD_STR_UPLEVEL to LCD_STR_UPLEVEL[0] for consistency
...
Saves 4 bytes of flash and 2 bytes of SRAM (Arduino IDE 1.8.19)
2022-02-05 19:58:31 +00:00
Guðni Már Gilbert
d5b666d260
Add LCD_STR_SOLID_BLOCK to represent \xFF
2022-02-05 19:53:42 +00:00
Guðni Már Gilbert
976c8c4902
Change message from .c to .cpp
...
The allows us to include lcd.h and replace hardcoded value with define LCD_STR_REFRESH
Also deleted a #define for bool which does not seem to be used.
2022-02-05 18:57:18 +00:00
Guðni Már Gilbert
e62bc4686f
Replace hardcoded values and optimise strings
...
This commit saves 64 bytes of flash memory on my end
2022-02-05 18:28:17 +00:00
Alex Voinea
274f198188
Fix typo from long ago
2022-02-04 16:28:49 +01:00
Alex Voinea
58867f6c06
Fix arduino 1.8.13 warnings
2022-02-04 15:53:49 +01:00
Guðni Már Gilbert
63c6373f8d
Remove TEMP_STAT_LEDS from firmware
...
This isn't used by MK3 printers.
It seems to be leftover code from Marlin
2021-12-25 09:41:50 +00:00
DRracer
0be90dc5d1
Merge pull request #3320 from prusa3d/MK3_3.10.1
...
Merge MK3_3.10.1 into MK3 after release
2021-12-17 14:02:13 +01:00
D.R.racer
caca7bb9b8
Version changed (3.10.1 build 4697)
2021-12-16 12:14:02 +01:00
3d-gussner
1c1e69e555
Update FW crash message
2021-12-16 11:23:44 +01:00
3d-gussner
785d94ab3a
Add links to RepRap Gcode wiki for new Dcodes D20-D23
2021-12-16 09:32:38 +01:00
Yuri D'Elia
3849f9785a
Make cancel_heatup also abort cooldown in M190
...
This matches the expected behavior, as already implemented in
wait_for_heater().
2021-12-10 01:51:43 +01:00
Yuri D'Elia
320835a1b7
Do not cancel wait-for-temperature loops in disable_heaters()
...
Partially revert previous change: cancelling a single loop would often
advance the gcode stream to the next wait-for loop if executed at the
beginning of an SD print, implicitly turning off the flag again.
Cancel the loop directly in UnconditionalStop() which stops the command
queue as well in an atomic way, handling this correctly.
2021-12-10 01:46:20 +01:00
Yuri D'Elia
32d8d892f5
Actually call UnconditionalStop() in Stop()->lcd_print_stop()
...
Remove incorrect check introduced during development.
2021-12-10 01:43:59 +01:00
Yuri D'Elia
83693bf4cc
Remove useless assignment in lcd_cooldown
...
The current filament action will be aborted by lcd_return_to_status()
2021-12-07 19:27:18 +01:00
Yuri D'Elia
78f856c8d6
Do not unconditionally overwrite the status message in check_file()
...
No function should touch the status message directly without checking
the message severity level first. Replace the strcpy_P with
lcd_setstatuspgm().
2021-12-07 19:27:18 +01:00
Yuri D'Elia
7ff117d0c4
temp_runaway_stop: remove spourious space in error message
2021-12-07 19:27:18 +01:00
Yuri D'Elia
36a7b5ca56
Avoid redundant checks in lcd_setalertstatus*
2021-12-07 19:27:18 +01:00
Yuri D'Elia
a3915b57b9
Improve temp_runaway_stop robustness
...
Remove most of the duplicated code inside temp_runaway_stop(),
making it identical to the other temperature handlers.
Move the lower-level functions required to stop the entirety of the
machine into UnconditionalStop(). Reuse this function inside
lcd_print_stop().
Set the LCD alert message before calling Stop(), as done in other safety
handlers, so that the error is visible while the printer is stopping.
This also avoids other temporary status messages to appear before
the real issue is shown and/or STEALING the first CRITICAL alert
level before we do.
2021-12-07 19:25:34 +01:00
Yuri D'Elia
57abffda1b
Update temperature-related error message to use LCD_STATUS_CRITICAL
2021-12-07 11:09:58 +01:00
Yuri D'Elia
fb025bba05
Introduce severity levels for alert messages
...
Use the internal lcd_status_message_level for multiple severity levels
of alert messages.
This is needed to distinguish between non-critical alerts (such as FAN
ERROR) from critical ones (any heater issue). During a failure
scenario, a critical error MUST NOT be overridden by a lower-level one.
As such LCD_STATUS_CRITICAL is currently used for all heater-related
errors that result in a safety full-stop.
2021-12-07 11:06:08 +01:00
DRracer
a7dfe4b523
Merge pull request #3305 from gudnimg/sd-card-lcdtimer-fix-gudni-v2
...
Fix issue when the SD card is inserted and the file menu may sometimes close immediately due to a timeout
2021-11-19 07:23:21 +01:00
Guðni Már Gilbert
be79e3791f
Fixes #3262
...
Make sure to call lcd_timeoutToStatus.start() when the SD card is inserted
into the printer after it was removed beforehand.
(cherry picked from commit 6795843f15 )
2021-11-18 19:23:21 +00:00
Guðni Már Gilbert
13732f162b
Fix build error when TMC2130_SERVICE_CODES_M910_M918 is enabled
...
(cherry picked from commit 6ed4b79cc6 )
2021-11-18 19:19:56 +00:00
Guðni Már Gilbert
6887f844d3
Merge branch 'prusa3d:MK3' into fix-pinda-thermistor-build-fail
2021-11-18 19:15:15 +00:00
Panayiotis-git
f8410d8f3c
Print temperatures only if filament loading is still active
2021-11-18 11:46:36 +02:00
Guðni Már Gilbert
05e0c1e1d3
Fix build error if PINDA_THERMISTOR is not defined
...
temp_cal_active variable is not defined in this scope
2021-10-12 21:52:19 +00:00
EV3R4
eff9cd9f21
Typo: M84 docs
2021-09-27 19:34:53 +02:00
Guðni Már Gilbert
cf8a16baa1
Remove one call to lcd_timeoutToStatus.start
...
Saves 8 bytes of Flash memory
This call is redundant and when moving between menus
it gets called multiple times which results in waste
of clock cycles.
lcd_timeoutToStatus.start() is called from menu_lcd_lcdupdate_func()
which is enough.
2021-08-21 14:34:02 +00:00
DRracer
fd6dbba06f
Merge branch 'MK3_3.10.1' into PFW-1271_PF-buildv20
2021-08-02 08:51:51 +02:00
Guðni Már Gilbert
158877e736
Remove one space from Support -> Temperatures menu
...
Saves 2 bytes of flash memory
2021-08-01 11:20:29 +00:00
Guðni Már Gilbert
da2c802440
Add two defines and use LCD_STR_DEGREE with consistency
...
This saves 12 bytes of flash and 2 bytes of SRAM
2021-08-01 11:10:03 +00:00
Guðni Már Gilbert
6afc87d3c8
Reduce unnecessary LCD CGRAM writes
2021-07-30 23:53:57 +00:00
Guðni Már Gilbert
b1972fdcee
Fixes https://github.com/prusa3d/Prusa-Firmware/issues/3252
2021-07-28 16:47:47 +00:00
Guðni Már Gilbert
400f673fe0
Remove redundant extern variable lcd_encoder from menu.cpp
...
This extern variable is included from lcd.h
2021-07-20 09:12:14 +02:00
Guðni Már Gilbert
d087973e00
Remove redundant extern variable is_usb_printing from tmc2130.cpp
...
This extern variable is included from Marlin.h
2021-07-20 09:12:14 +02:00
Guðni Már Gilbert
6aee17b4ca
lcd_change_fil_state has two extern's in Marlin.h, only one needed.
2021-07-20 09:12:14 +02:00
Guðni Már Gilbert
3cfd706fff
Remove useless extern in cmdqueue.cpp
2021-07-20 09:12:14 +02:00