Guðni Már Gilbert
a7e9ccfb57
Major refactoring
...
Fixes all the issues I've found so far.
Roughly 60B of flash saved. Need to double check that later.
2023-04-05 10:30:59 +02:00
Guðni Már Gilbert
67c206ea5c
Remove menu_back_if_clicked_fb
...
Since feedback is always produced on knob click
we can use menu_back_if_clicked instead
Change in memory:
Flash: -18 bytes
SRAM: 0 bytes
2023-04-05 10:30:59 +02:00
Guðni Már Gilbert
eeb5f3d50c
optimisation: refactor menu_draw_P()
...
Add a way to only change the LCD column
Change in memory:
Flash: -90 bytes
SRAM: 0 bytes
2023-01-16 12:36:57 +01:00
Guðni Már Gilbert
730bb3708e
Fix an issue with menu_draw_item_puts_P
...
Change in memory:
Flash: +16 bytes
SRAM: 0 bytes
2023-01-16 12:36:57 +01:00
Guðni Már Gilbert
4f4153175c
Refactor menu_draw_toggle_puts_P
...
The refactoring drops the local buffer lineStr
Change in memory:
Flash: -106 bytes
SRAM: 0 bytes
2023-01-16 12:36:57 +01:00
Guðni Már Gilbert
cc08b938b7
Optimisations: implement lcd_print_pad_P()
...
Used lcd_print_pad_P is some obvious places. We can probably use
this function in more places to further save flash memory
Change in memory:
Flash: -268 bytes
SRAM: 0 bytes
2023-01-16 12:36:57 +01:00
Guðni Már Gilbert
08460bd403
PFW-1397 Drop ON_MENU_ENTER
...
Using _menu_data_t turns out to save *just* a little bit more flash. So for now just use it.
2022-11-08 13:49:40 +01:00
Guðni Már Gilbert
390f69a82f
PFW-1397 Fix: ON_MENU_ENTER was always run
2022-11-08 13:49:40 +01:00
Guðni Már Gilbert
82bd9db1d6
PFW-1397 Implement ON_MENU_ENTER to simplify code
...
ON_MENU_ENTER runs code within the brackets only once
after a new menu is entered.
For the tool change menu, this allows us to display the data and
read from EEPROM only once.
2022-11-08 13:49:40 +01:00
Yuri D'Elia
374b829fb6
Generalize menu_block_entering_on_serious_errors for menu lockout
...
Call this variable menu_block_mask instead. We don't need to know the
exact reason of why we're locking the menu.
We will be able to reuse this to prevent menu entry during more
activities in a cleaner way than testing for each condition as it's
currently done for both menu entry and longpress.
2022-07-25 17:30:22 +02:00
Alex Voinea
42b91a83cd
Merge branch 'MK3' into MK3_3.12_Optimizations
2022-02-10 10:36:31 +01:00
Guðni Már Gilbert
c2bad473dc
Optimise _menu_edit_P
...
If the first if statement is true, then we don't need to check the next if statement.
Saves 64 bytes of flash memory
2022-02-06 09:01:16 +00:00
Guðni Már Gilbert
d5b666d260
Add LCD_STR_SOLID_BLOCK to represent \xFF
2022-02-05 19:53:42 +00:00
Guðni Már Gilbert
9bf45773f9
Merge remote-tracking branch 'upstream/MK3' into rebase-testing-ground-v2
2022-01-30 11:43:16 +00:00
Guðni Már Gilbert
77cce1fc05
Replace three lines by one function call which does the same thing
...
Saves 42 bytes of flash memory
2022-01-30 11:39:24 +00:00
Guðni Már Gilbert
400f673fe0
Remove redundant extern variable lcd_encoder from menu.cpp
...
This extern variable is included from lcd.h
2021-07-20 09:12:14 +02:00
Alex Voinea
225c456ae6
Limit progressbar to LCD_WIDTH
...
for some stupid reason bubbleSort sometimes exceeds the total value :)
2021-02-26 09:18:28 +02:00
Alex Voinea
8821439878
Cardreader progressbar code
2021-02-25 20:25:32 +02:00
Alex Voinea
afa7c7ab03
Remove forgotten (?) undef at the end of menu.cpp
2021-02-25 19:29:14 +02:00
Alex Voinea
4c977cc335
Merge branch 'MK3' into MK3_NEW_SD_COMPILATION
2021-02-03 18:28:18 +02:00
D.R.racer
0eb7261e29
Save ~100B on menu implementation
2021-01-26 09:29:17 +01:00
Alex Voinea
4abf1f436a
Gracefully dump the queue + fixes to fancheck
2020-11-09 21:49:56 +02:00
Alex Voinea
6bc59197ad
Merge branch 'MK3' into MK3_NEW_SD_COMPILATION
2020-09-12 08:28:13 +03:00
Alex Voinea
7ac16d5f04
Menu view return patch
2020-09-07 19:42:53 +03:00
Alex Voinea
355b003b7f
menu_data_reset()
2020-03-04 22:20:53 +02:00
Alex Voinea
40ebd455f2
Safer menu interrupt call
2020-03-04 22:14:53 +02:00
Alex Voinea
f35e553373
Code cleanup
2020-03-04 20:33:43 +02:00
Alex Voinea
53e130fc6d
Merge branch 'MK3' into MK3_NEW_SD_COMPILATION
2020-03-03 14:14:43 +02:00
Yuri D'Elia
5122f79a39
Merge remote-tracking branch 'upstream/MK3' into MK3_LA15
2019-12-04 17:27:23 +01:00
Alex Voinea
d40656e3ca
Small changes to rendering
2019-11-24 19:16:22 +02:00
Alex Voinea
8a806bceea
SDDIR
2019-11-21 21:32:52 +02:00
Alex Voinea
6538262e75
First build that actually works
2019-11-21 19:04:45 +02:00
Alex Voinea
b3a587f5a4
SD first attempt. Broken
2019-11-20 20:25:51 +02:00
Alex Voinea
1de353dd09
Merge branch 'MK3' into MK3_Translations
2019-11-07 17:02:45 +02:00
leptun
6bd35bfa2f
Increase MENU_DEPTH_MAX to 7 to allow sheet calibration with MMU
2019-10-01 19:43:30 +03:00
DRracer
14933f6b0e
Fix. Sound [assist], Z-probe [5], menu_fmt_float13off format for last
...
string parameter from PROGMEM
2019-09-17 16:50:51 +02:00
leptun
695f938348
Fix conversion warnings
2019-09-14 12:24:45 +03:00
leptun
e828798209
Fixes after merge and line buffer
...
General fixes to the lcd_edit_off item and improved way to generate the toggles.
The old process is this: Write '>' if required -> print base -> pad everything before the last character with spaces -> write the eol character -> jump back and print the toggle over the blank characters. This resulted in noticeable flickering when the toggle was redrawn and was showing the same thing. Now the process is similar, except that everything happens in a "line buffer" (a char buffer that holds an entire line) and gets printed in one go, avoiding jump instructions for the lcd and prevents flickering since it doesn't write ' ' and the letters afterwards.
This should get even better when the lcd_buffer gets implemented since the line_buffer will get compared to the existing data on the screen and avoid overwriting what is on the lcd with the same thing.
2019-09-13 21:21:42 +03:00
DRracer
4423106fad
dialogs' layouts fixes (support menu dlgs, statistics etc.)
...
French translation polished
2019-09-13 16:55:05 +02:00
leptun
ae839aee31
Merge branch 'MK3' into MK3_Translations
2019-09-12 16:28:36 +03:00
leptun
3c4fffef60
Merge branch 'MK3' into MK3_Translations
2019-08-31 15:30:51 +03:00
leptun
6a8330a43b
Toggle "HW Setup"*
...
All toggles from "HW Setup" were changed.
This includes:
-"Nozzle d."
-all "Checks"
Also added an option to provide a string from sram (not from progmem) as the toggle argument. This can be useful when toggling numbers or even when toggling sheets in the future.
2019-08-30 17:36:21 +03:00
Marek Bel
6c78c2fad5
Fix compiler warning.
2019-08-30 12:03:35 +02:00
Marek Bel
d647cdc02c
Convert sheet switcher from sub menu to function. Handle null characters in sheet name.
2019-08-29 20:13:10 +02:00
leptun
6e9c44af2d
Fix warning
2019-08-19 11:07:11 +03:00
leptun
5a3f14b752
"N/A" toggle support and format update
2019-08-19 10:20:17 +03:00
leptun
596ffe1dc2
Actual fix to the missing first two characters
2019-08-10 21:03:45 +03:00
leptun
505deb28fd
Toggle menu item
2019-08-10 08:42:33 +03:00
Yuri D'Elia
18b8dc89e5
Merge remote-tracking branch 'upstream/MK3' into MK3_LA15
2019-08-04 17:06:34 +02:00
NotaRobotexe
b9f622f8a6
variables to PROGMEM, text formating
2019-07-23 11:31:20 +02:00