Get rid of STEP_INTERRUPT_INTERRUPTIBLE.

It was certainly a good idea, but also always a suspect of
malfunctions and as such, almost never used. Newer code
organisation moves most of the code behind it to dda_clock()
anyways, so it also became mostly obsolete.

Rest In Peace, STEP_INTERRUPT_INTERRUPTIBLE, you were matter
of quite a number of interesting discussions and investigations.

Changes for Configtool by jbernardis <jeff.bernardis@gmail.com>

config.3drag.h

@@ -553,13 +553,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-	\note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.gen3.h

@@ -559,12 +559,6 @@ DEFINE_TEMP_SENSOR(bed,       TT_INTERCOM,    AIO1,      0)
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.gen6.h

@@ -545,12 +545,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.gen7-v1.1-v1.3.h

@@ -556,13 +556,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-	\note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.gen7-v1.4.h

@@ -556,13 +556,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-	\note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.ramps-v1.2.h

@@ -554,12 +554,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/**
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.ramps-v1.3.h

@@ -556,13 +556,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-	\note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.rumba.h

@@ -557,13 +557,6 @@ PWM value for 'off'
 */
 #define REFERENCE     REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-  this option makes the step interrupt interruptible (nested).
-  this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-  \note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define   STEP_INTERRUPT_INTERRUPTIBLE  1
-
 /**
   temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
   higher values make PID derivative term more stable at the expense of reaction time

config.sanguinololu-v1.1.h

@@ -552,13 +552,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-	\note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.sanguinololu-v1.2.h

@@ -552,13 +552,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-	\note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.sanguish.h

@@ -556,13 +556,6 @@ PWM value for 'off'
 */
 #define REFERENCE     REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-  this option makes the step interrupt interruptible (nested).
-  this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-  \note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define   STEP_INTERRUPT_INTERRUPTIBLE  1
-
 /**
   temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
   higher values make PID derivative term more stable at the expense of reaction time

config.teensy.h

@@ -610,13 +610,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-	\note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time

config.teensypp.h

@@ -624,13 +624,6 @@ PWM value for 'off'
 */
 #define REFERENCE         REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-  this option makes the step interrupt interruptible (nested).
-  this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-  \note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define    STEP_INTERRUPT_INTERRUPTIBLE  1
-
 /**
   temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
   higher values make PID derivative term more stable at the expense of reaction time

config/printer.mendel.h

@@ -276,17 +276,6 @@
 */
 #define REFERENCE                REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-  This option makes the step interrupt interruptible (nested). This should
-  help immensely with dropped serial characters, but may also make debugging
-  infuriating due to the complexities arising from nested interrupts.
-
-  Note: disable this option if you're using a '168 or for some reason your
-  ram usage is above 90%. This option hugely increases likelihood of stack
-  smashing.
-*/
-#define STEP_INTERRUPT_INTERRUPTIBLE 1
-
 /** \def TH_COUNT
   Temperature history count. This is how many temperature readings to keep in
   order to calculate derivative in PID loop higher values make PID derivative

config/printer.wolfstrap.h

@@ -276,17 +276,6 @@
 */
 #define REFERENCE                REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-  This option makes the step interrupt interruptible (nested). This should
-  help immensely with dropped serial characters, but may also make debugging
-  infuriating due to the complexities arising from nested interrupts.
-
-  Note: disable this option if you're using a '168 or for some reason your
-  ram usage is above 90%. This option hugely increases likelihood of stack
-  smashing.
-*/
-#define STEP_INTERRUPT_INTERRUPTIBLE 1
-
 /** \def TH_COUNT
   Temperature history count. This is how many temperature readings to keep in
   order to calculate derivative in PID loop higher values make PID derivative

configtool/miscellaneouspage.py

@@ -23,7 +23,6 @@ class MiscellaneousPage(wx.Panel, Page):
                    'DC_EXTRUDER': "Heater:", 'DC_EXTRUDER_PWM': "PWM:",
                    'USE_WATCHDOG': "Use the Watchdog Timer",
                    'REFERENCE': "Analog Reference:",
-                   'STEP_INTERRUPT_INTERRUPTIBLE': "STEP Interrupt",
                    'TH_COUNT': "Temperature History Size:",
                    'FAST_PWM': "Fast PWM",
                    'ENDSTOP_STEPS': "Endstop Steps:",
@@ -73,10 +72,6 @@ class MiscellaneousPage(wx.Panel, Page):
     cb = self.addCheckBox(k, self.onCheckBox)
     sz.Add(cb, pos = (4, 1))
 
-    k = 'STEP_INTERRUPT_INTERRUPTIBLE'
-    cb = self.addCheckBox(k, self.onCheckBox)
-    sz.Add(cb, pos = (5, 1))
-
     k = 'FAST_PWM'
     cb = self.addCheckBox(k, self.onCheckBox)
     sz.Add(cb, pos = (6, 1))
@@ -279,14 +274,7 @@ class MiscellaneousPage(wx.Panel, Page):
   def getValues(self):
     result = Page.getValues(self)
 
-    k = 'STEP_INTERRUPT_INTERRUPTIBLE'
+    k = 'DC_EXTRUDER'
-    cb = self.checkBoxes[k]
-    if cb.IsChecked():
-      result[k] = "1"
-    else:
-      result[k] = "0"
-
-    k = "DC_EXTRUDER"
     s = self.choices[k].GetSelection()
     v = self.choices[k].GetString(s)
     if v == self.heaterNameNone:

dda.c

@@ -628,15 +628,6 @@ void dda_step(DDA *dda) {
 	}
 #endif
 
-	#if STEP_INTERRUPT_INTERRUPTIBLE && ! defined ACCELERATION_RAMPING
-		// Since we have sent steps to all the motors that will be stepping
-		// and the rest of this function isn't so time critical, this interrupt
-		// can now be interruptible by other interrupts.
-		// The step interrupt is disabled before entering dda_step() to ensure
-		// that we don't step again while computing the below.
-		sei();
-	#endif
-
 	#ifdef ACCELERATION_REPRAP
 		// linear acceleration magic, courtesy of http://www.embedded.com/design/mcus-processors-and-socs/4006438/Generate-stepper-motor-speed-profiles-in-real-time
 		if (dda->accel) {

dda_queue.c

@@ -89,8 +89,6 @@ void queue_step() {
 			}
 		}
 		else {
-			// NOTE: dda_step makes this interrupt interruptible for some time,
-			//       see STEP_INTERRUPT_INTERRUPTIBLE.
 			dda_step(current_movebuffer);
 		}
 	}

testcases/config.h.Profiling

@@ -556,13 +556,6 @@ PWM value for 'off'
 */
 #define	REFERENCE			REFERENCE_AVCC
 
-/** \def STEP_INTERRUPT_INTERRUPTIBLE
-	this option makes the step interrupt interruptible (nested).
-	this should help immensely with dropped serial characters, but may also make debugging infuriating due to the complexities arising from nested interrupts
-	\note disable this option if you're using a '168 or for some reason your ram usage is above 90%. This option hugely increases likelihood of stack smashing.
-*/
-#define		STEP_INTERRUPT_INTERRUPTIBLE	1
-
 /**
 	temperature history count. This is how many temperature readings to keep in order to calculate derivative in PID loop
 	higher values make PID derivative term more stable at the expense of reaction time