From 6250dbb9e0b62383b85864e5c23c91ce4d33b993 Mon Sep 17 00:00:00 2001 From: Markus Hitter Date: Fri, 13 Jun 2014 22:19:23 +0200 Subject: [PATCH] Configuration: move DEBUG_LED definition. Eventual debugging LEDs aren't part of the CPU, but part of the electronics. Accordingly, define it in config.*.h, not in arduino_*.h (which would be better named something like "atmega_*.h). --- arduino_1280.h | 2 -- arduino_168_328p.h | 1 - arduino_32U4.h | 4 ---- arduino_644.h | 2 +- arduino_usb1286.h | 2 -- arduino_usb1287.h | 2 -- config.default.h | 2 ++ config.gen3.h | 2 ++ config.gen6.h | 2 ++ config.gen7-v1.1-v1.3.h | 2 ++ config.gen7-v1.4.h | 2 ++ config.ramps-v1.2.h | 2 ++ config.ramps-v1.3.h | 2 ++ config.sanguinololu-v1.1.h | 2 ++ config.sanguinololu-v1.2.h | 2 ++ config.sanguish.h | 2 ++ config.teensy.h | 2 ++ config.teensypp.h | 2 ++ 18 files changed, 25 insertions(+), 12 deletions(-) diff --git a/arduino_1280.h b/arduino_1280.h index 293a1af..493bcfc 100644 --- a/arduino_1280.h +++ b/arduino_1280.h @@ -29,8 +29,6 @@ #define OC5B DIO45 #define OC5C DIO44 -// change for your board -#define DEBUG_LED DIO21 /* pins diff --git a/arduino_168_328p.h b/arduino_168_328p.h index e53bbdb..23ca34d 100644 --- a/arduino_168_328p.h +++ b/arduino_168_328p.h @@ -20,7 +20,6 @@ #define OC2A DIO11 #define OC2B DIO3 -#define DEBUG_LED AIO5 /* pins diff --git a/arduino_32U4.h b/arduino_32U4.h index c3520e5..014f678 100644 --- a/arduino_32U4.h +++ b/arduino_32U4.h @@ -51,10 +51,6 @@ #define OC4D DIO12 -// change for your board -#define DEBUG_LED DIO22 /* led D11 red */ -#define DEBUG_LED_PIN DIO22 - /* pins */ diff --git a/arduino_644.h b/arduino_644.h index bd4db18..aab99ff 100644 --- a/arduino_644.h +++ b/arduino_644.h @@ -25,7 +25,7 @@ #define OC2A DIO15 #define OC2B DIO14 -#define DEBUG_LED DIO0 + /* pins */ diff --git a/arduino_usb1286.h b/arduino_usb1286.h index 571939b..05e0d74 100644 --- a/arduino_usb1286.h +++ b/arduino_usb1286.h @@ -13,8 +13,6 @@ #define MOSI DIO10 #define SS DIO8 -// change for your board -#define DEBUG_LED DIO6 /* led D6 */ /* pins diff --git a/arduino_usb1287.h b/arduino_usb1287.h index 80cd6e9..ce4e545 100644 --- a/arduino_usb1287.h +++ b/arduino_usb1287.h @@ -4,8 +4,6 @@ #define MOSI DIO10 #define SS DIO8 -// change for your board -#define DEBUG_LED DIO31 /* led D5 red */ /* pins diff --git a/config.default.h b/config.default.h index dbd1db3..014c38e 100644 --- a/config.default.h +++ b/config.default.h @@ -292,6 +292,8 @@ //#define STEPPER_ENABLE_PIN xxxx //#define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + /***************************************************************************\ diff --git a/config.gen3.h b/config.gen3.h index b497d1d..c399775 100644 --- a/config.gen3.h +++ b/config.gen3.h @@ -297,6 +297,8 @@ //#define STEPPER_ENABLE_PIN xxxx //#define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + /***************************************************************************\ diff --git a/config.gen6.h b/config.gen6.h index 86ed49a..2248fb9 100644 --- a/config.gen6.h +++ b/config.gen6.h @@ -292,6 +292,8 @@ //#define STEPPER_ENABLE_PIN xxxx //#define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + /***************************************************************************\ diff --git a/config.gen7-v1.1-v1.3.h b/config.gen7-v1.1-v1.3.h index 2aa1a47..a3767b2 100644 --- a/config.gen7-v1.1-v1.3.h +++ b/config.gen7-v1.1-v1.3.h @@ -300,6 +300,8 @@ #define STEPPER_ENABLE_PIN DIO24 #define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + /***************************************************************************\ diff --git a/config.gen7-v1.4.h b/config.gen7-v1.4.h index 9a7f76f..0d89e81 100644 --- a/config.gen7-v1.4.h +++ b/config.gen7-v1.4.h @@ -300,6 +300,8 @@ #define STEPPER_ENABLE_PIN DIO25 #define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + /***************************************************************************\ diff --git a/config.ramps-v1.2.h b/config.ramps-v1.2.h index 86079e6..20a32ad 100644 --- a/config.ramps-v1.2.h +++ b/config.ramps-v1.2.h @@ -295,6 +295,8 @@ //#define SD_CARD_DETECT DIO2 //#define SD_WRITE_PROTECT DIO3 +//#define DEBUG_LED_PIN DIO0 + /***************************************************************************\ diff --git a/config.ramps-v1.3.h b/config.ramps-v1.3.h index ed74efe..4ce708c 100644 --- a/config.ramps-v1.3.h +++ b/config.ramps-v1.3.h @@ -295,6 +295,8 @@ //#define STEPPER_ENABLE_PIN xxxx //#define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + // TODO: 20110813 SJL - the following two are not yet used&verified for RAMPS1.3 //#define SD_CARD_DETECT DIO2 //#define SD_WRITE_PROTECT DIO3 diff --git a/config.sanguinololu-v1.1.h b/config.sanguinololu-v1.1.h index 9b859ac..6cafe4a 100644 --- a/config.sanguinololu-v1.1.h +++ b/config.sanguinololu-v1.1.h @@ -293,6 +293,8 @@ #define STEPPER_ENABLE_PIN DIO4 //#define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + //#define SD_CARD_DETECT DIO2 //#define SD_WRITE_PROTECT DIO3 diff --git a/config.sanguinololu-v1.2.h b/config.sanguinololu-v1.2.h index c9d5478..311e9e1 100644 --- a/config.sanguinololu-v1.2.h +++ b/config.sanguinololu-v1.2.h @@ -293,6 +293,8 @@ #define STEPPER_ENABLE_PIN DIO14 #define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + //#define SD_CARD_DETECT DIO2 //#define SD_WRITE_PROTECT DIO3 diff --git a/config.sanguish.h b/config.sanguish.h index 6c5c8d4..77e68b0 100644 --- a/config.sanguish.h +++ b/config.sanguish.h @@ -300,6 +300,8 @@ //#define STEPPER_ENABLE_PIN DIO25 //#define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + /***************************************************************************\ diff --git a/config.teensy.h b/config.teensy.h index 9165adf..e31b2f4 100644 --- a/config.teensy.h +++ b/config.teensy.h @@ -342,6 +342,8 @@ to use the other 6 PWMs instead. #define STEPPER_ENABLE_PIN DIO19 #define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + //#define SD_CARD_DETECT DIO2 //#define SD_WRITE_PROTECT DIO3 diff --git a/config.teensypp.h b/config.teensypp.h index 31ce8f8..d02aaa8 100644 --- a/config.teensypp.h +++ b/config.teensypp.h @@ -356,6 +356,8 @@ DaveX plan for Teensylu/printrboard-type pinouts (ref teensylu & sprinter) for a #define STEPPER_ENABLE_PIN DIO26 #define STEPPER_INVERT_ENABLE +//#define DEBUG_LED_PIN DIO0 + //#define SD_CARD_DETECT DIO2 //#define SD_WRITE_PROTECT DIO3