6ce7792045
Remove "hh" in fmt where it makes no difference
2022-02-02 20:58:21 +01:00
146b008186
Remove redundant variable farm_status
...
It is unused and status_number variable can be used instead.
2022-02-02 18:37:55 +00:00
459570ab66
Change prusa_stat_printerstatus parameter to uint8_t
...
Also changes status_number global variable to uint8_t
Changes save 80 bytes of flash and 1 byte of SRAM (Arduino IDE 1.8.19)
2022-02-02 18:35:52 +00:00
e525bcb7f5
Optimise lcd_selftest_screen input parameters and return type
...
* _progress_scale is max 3 so it can be uint8_t
* _progress is max 6 so it can be uint8_t
* Change _delay type to uint16_t to be explicit
Changes save 102 bytes of flash memory (Arduino IDE 1.8.19)
2022-02-01 18:57:43 +00:00
8681d84c44
Merge branch 'MK3_3.12_Optimizations' of https://github.com/leptun/Prusa-Firmware into MK3_3.12_Optimizations
2022-02-01 18:37:57 +00:00
53dfcf9d6f
Optimise if-statments in world2machine_clamp
...
Only one of the statements can be true: tmpx < X_MIN_POS or tmpx > X_MAX_POS.
So we can be a little bit smarter here and skip the second if statement if the first was true.
This saves 6 bytes of flash memory and potential some clock cycles
2022-02-01 18:37:41 +00:00
aec2db7683
Optimize MUL8x16R8
2022-02-01 18:12:13 +01:00
b7806bf25f
Crash if pullups get enabled on the thermistor inputs
2022-02-01 12:34:07 +01:00
c0e7e17fc3
Fix type of nrFiles
2022-01-30 13:07:09 +00:00
1523194d3b
Fix build (merge conflict)
2022-01-30 13:18:07 +01:00
67e6361ff1
Fix temperature runaway variable types (merge conflict)
2022-01-30 13:16:05 +01:00
9bf45773f9
Merge remote-tracking branch 'upstream/MK3' into rebase-testing-ground-v2
2022-01-30 11:43:16 +00:00
aae562e480
Fix G81 for loop
2022-01-30 11:39:29 +00:00
c081e1a5ae
Loop index can be unsigned
...
Saves 4 bytes of flash memory
2022-01-30 11:39:29 +00:00
49693a9fb3
Remove undefined function
...
No change in memory footprint.
2022-01-30 11:39:29 +00:00
c705d4aa10
Change set_z() parameters to uin8_t
...
Saves 24 bytes of flash
2022-01-30 11:39:28 +00:00
581188ce2c
Fix an issue found in code review
...
Unfortunately this increases flash usages by 212 bytes (same usage as in current release) It seems it is most memory effcient to use int16_t (int). int8_t requires more memory.
2022-01-30 11:39:28 +00:00
f8847edca6
Remove one unused variable
...
Saves 1 byte of SRAM
The variable is only assigned a value but is never used.
2022-01-30 11:39:28 +00:00
d8723c0eac
Use code_value_uint8() in get_command()
...
The if statement is simplified as the value is never negative
and we can get rid of one variable
Saves 12 bytes of flash memory
2022-01-30 11:39:27 +00:00
ac049c7e3c
Use code_value_short() in get_command()
...
Same code but uses a defined function
Saves 28 bytes of flash memory
2022-01-30 11:39:27 +00:00
052ecc3782
G81: Change for loop variables x and y to uint8_t
...
Saves 198 bytes of flash, that's crazy
2022-01-30 11:39:27 +00:00
7787f17139
Smaller code in G28
...
Replace two blocks of code with already defined functions.
Change saves 100 bytes of flash memory and 11 lines of code.
2022-01-30 11:39:27 +00:00
b835f31904
Remove variable move_menu_scale
...
The variable is just set to 1.0 and is never modified, I also
removed the function lcd_move_menu_1mm()
Changes save 96 bytes of flash memory and 4 bytes of SRAM
2022-01-30 11:39:27 +00:00
a940c364c9
Create enum class for heating_status variable
2022-01-30 11:39:27 +00:00
2013295f94
Change farm_timer to uint8_t
...
Remove extern declaration of farm_timer and farm_status as they
are only used in one file.
Saves 26 bytes of flash
2022-01-30 11:39:26 +00:00
a687173e02
Change custom_message_state_old and custom_message_state to uint8_t
...
I see max value as 7*7+10 = 59
Saves 100 byte of flash and 1 byte of SRAM
2022-01-30 11:39:26 +00:00
60c9640602
Change heating_status_counter to uint8_t
...
It has a max value of 14
Saves 28 bytes of flash and 1 byte of SRAM
2022-01-30 11:39:26 +00:00
22f23dff36
Change heating_status to uint8_t
...
Saves 66 byte of flash and 1 byte of SRAM
2022-01-30 11:39:26 +00:00
2d614a8d41
Change usb_printing_counter to uint8_t
...
It is assigned max value of 10
Saves 26 byte of flash and 1 byte of SRAM
2022-01-30 11:39:26 +00:00
aa0a86bf13
Remove internal Prusa command 'Beat'
...
It doesn't seem to do anything.
Saves 22 bytes of flash
2022-01-30 11:39:25 +00:00
42778cae83
Remove unused kicktime timer
...
The variable is only set and never actually used
Saves 8 bytes of flash and 4 bytes of SRAM
2022-01-30 11:39:25 +00:00
ef8083a148
crashDetTimer can be ShortTimer
...
Expired value is less than 65535
Saves 8 bytes of flash and 2 bytes of SRAM
2022-01-30 11:39:25 +00:00
6a9bab02f7
Convert display_time to ShortTimer
...
Saves 24 bytes of flash, 1 byte of SRAM
2022-01-30 11:39:25 +00:00
802b8860c8
Convert mmu_last_finda_response to ShortTimer
...
Saves 48 bytes of Flash, 1 byte of SRAM
2022-01-30 11:39:25 +00:00
37fd9d1b11
Convert NcTime to ShortTimer
...
The variable is only used in ultralcd.cpp so I made it static there
and deleted it from Marlin_main.cpp
Saves 24 bytes of flash and 1 byte of SRAM
2022-01-30 11:39:25 +00:00
a1abd094dd
Convert autostart_atmillis to ShortTimer
...
Saves 34 bytes of flash and 1 byte of SRAM
2022-01-30 11:39:24 +00:00
762a5db125
Convert previous_millis_cmd to LongTimer
...
Saves 196 bytes of Flash but adds 1 byte of SRAM
2022-01-30 11:39:24 +00:00
1cd9ecb2c7
Convert mmu_last_request and mmu_last_response to ShortTimer
...
Saves 180 bytes of flash and 2 byte of SRAM
2022-01-30 11:39:24 +00:00
66782e9c9d
setTargetHotend expect an uint8_t, not int for second parameter
...
also change _usb_timer to ShortTimer
Saves 28 bytes of Flash and 1 byte of SRAM
2022-01-30 11:39:24 +00:00
77cce1fc05
Replace three lines by one function call which does the same thing
...
Saves 42 bytes of flash memory
2022-01-30 11:39:24 +00:00
a26651e7aa
Change return types of two functions uint8_t
...
These functions aren't used but they should return the appropriate type.
2022-01-30 11:39:24 +00:00
800f44509d
Change row_offsets[] to uint8_t
...
Saves 10 bytes of flash, and 4 bytes of SRAM
2022-01-30 11:39:24 +00:00
58213814cf
Replace for-loop with memcpy
...
Saves 22 bytes of flash memory
2022-01-30 11:39:23 +00:00
52aa5a5f00
Use inlined function set_destination_to_current() in more places
...
Saves 70 bytes of flash memory
2022-01-30 11:39:23 +00:00
a8d16d2949
Use memset to zero previous_speed array
...
Saves 150 bytes of flash memory
2022-01-30 11:39:23 +00:00
cdd7ea30f4
Fix LUT loop
2022-01-30 11:39:23 +00:00
fb10b4398e
Merge pull request #6 from gudnimg/gudni-PR1
...
Purged some `int`s for `uint8_t` when using the axis enum
2022-01-30 11:30:25 +00:00
f81db56793
temp_runaway_check() parameter _heater_id should be uint8_t
...
Saves 58 bytes of flash
2022-01-30 11:22:45 +00:00
261f311825
Change two arrays from int to uint8_t
...
__preheat_counter has max value of 16
__preheat_errors has max value of 5
Saves 58 bytes of flash memory and 4 bytes of SRAM
2022-01-30 11:22:45 +00:00
7535fa3a44
Remove unused variable
...
Saves 2 bytes of SRAM
2022-01-30 11:22:45 +00:00
623762bd50
Fix build
2022-01-30 11:22:44 +00:00
42a5f7dc20
Fix M226
2022-01-30 11:22:44 +00:00
4aae88afdf
M42 optimization
2022-01-30 11:22:44 +00:00
a5cd99a917
Disable unimplemented PID_ADD_EXTRUSION_RATE
2022-01-30 11:22:44 +00:00
9951e3da52
Sound enums as uint8_t
2022-01-30 11:22:44 +00:00
6dd59985ee
Disable PRUSA M28
2022-01-30 11:22:44 +00:00
f22b9260ae
Fix build
2022-01-30 11:22:44 +00:00
9abae2fd97
Remove maxlimit_status
2022-01-30 11:22:43 +00:00
9684806e00
Change arduino IO to fastio where possible
2022-01-30 11:22:43 +00:00
42c393764f
Adjust temperature runaway extruder count
2022-01-30 11:22:43 +00:00
78362419da
nIRsensorLastTime
2022-01-30 11:22:43 +00:00
a5f1f23fe2
TimeNow && TimeSent
2022-01-30 11:22:43 +00:00
f64c6c2a39
Remove unused Stepper.cpp variables
2022-01-30 11:22:43 +00:00
9d1e54e685
Tmc2130 use ShortTimer instead of custom timer implementation
2022-01-30 11:22:43 +00:00
d8a14842c5
Remove unused `skip_debug_msg` flag
2022-01-30 11:22:43 +00:00
4d348fa953
Initial Romanian translation
2022-01-17 16:21:59 +01:00
c09b732522
Reserve xflash space for the mmu update files
2022-01-17 12:03:12 +01:00
b72c027924
XFLASH layout explained
2022-01-17 11:46:14 +01:00
93b1a6b736
"Unload filament" c adjustment
2022-01-16 11:19:24 +01:00
1d491e772b
Expand maximum language count ( #3345 )
...
* Expand maximum language count
2022-01-13 16:01:36 +02:00
1544a79b4e
Add Lithuanian
2022-01-03 15:00:45 +01:00
54d7e9331b
Add Croatian
2022-01-03 11:25:15 +01:00
75dc5bd410
Add Luxembourgish
2022-01-03 11:25:15 +01:00
8911161f6b
Add Hungarian
...
Fix typo
2022-01-03 11:25:15 +01:00
7083529990
Add Slovanian
2022-01-03 11:25:15 +01:00
f8a0d3ad7b
Add Danish
2022-01-03 11:25:15 +01:00
5bce397fab
Add Swedish
2022-01-03 11:25:15 +01:00
e02dd42765
Prepare for lot of community languages
...
The firmware is limited to how many languages can be stored in the xflash.
We will need to compile multiple language groups
2022-01-03 11:25:15 +01:00
63c6373f8d
Remove TEMP_STAT_LEDS from firmware
...
This isn't used by MK3 printers.
It seems to be leftover code from Marlin
2021-12-25 09:41:50 +00:00
0be90dc5d1
Merge pull request #3320 from prusa3d/MK3_3.10.1
...
Merge MK3_3.10.1 into MK3 after release
2021-12-17 14:02:13 +01:00
caca7bb9b8
Version changed (3.10.1 build 4697)
2021-12-16 12:14:02 +01:00
1c1e69e555
Update FW crash message
2021-12-16 11:23:44 +01:00
785d94ab3a
Add links to RepRap Gcode wiki for new Dcodes D20-D23
2021-12-16 09:32:38 +01:00
3849f9785a
Make cancel_heatup also abort cooldown in M190
...
This matches the expected behavior, as already implemented in
wait_for_heater().
2021-12-10 01:51:43 +01:00
320835a1b7
Do not cancel wait-for-temperature loops in disable_heaters()
...
Partially revert previous change: cancelling a single loop would often
advance the gcode stream to the next wait-for loop if executed at the
beginning of an SD print, implicitly turning off the flag again.
Cancel the loop directly in UnconditionalStop() which stops the command
queue as well in an atomic way, handling this correctly.
2021-12-10 01:46:20 +01:00
32d8d892f5
Actually call UnconditionalStop() in Stop()->lcd_print_stop()
...
Remove incorrect check introduced during development.
2021-12-10 01:43:59 +01:00
83693bf4cc
Remove useless assignment in lcd_cooldown
...
The current filament action will be aborted by lcd_return_to_status()
2021-12-07 19:27:18 +01:00
78f856c8d6
Do not unconditionally overwrite the status message in check_file()
...
No function should touch the status message directly without checking
the message severity level first. Replace the strcpy_P with
lcd_setstatuspgm().
2021-12-07 19:27:18 +01:00
7ff117d0c4
temp_runaway_stop: remove spourious space in error message
2021-12-07 19:27:18 +01:00
36a7b5ca56
Avoid redundant checks in lcd_setalertstatus*
2021-12-07 19:27:18 +01:00
a3915b57b9
Improve temp_runaway_stop robustness
...
Remove most of the duplicated code inside temp_runaway_stop(),
making it identical to the other temperature handlers.
Move the lower-level functions required to stop the entirety of the
machine into UnconditionalStop(). Reuse this function inside
lcd_print_stop().
Set the LCD alert message before calling Stop(), as done in other safety
handlers, so that the error is visible while the printer is stopping.
This also avoids other temporary status messages to appear before
the real issue is shown and/or STEALING the first CRITICAL alert
level before we do.
2021-12-07 19:25:34 +01:00
57abffda1b
Update temperature-related error message to use LCD_STATUS_CRITICAL
2021-12-07 11:09:58 +01:00
fb025bba05
Introduce severity levels for alert messages
...
Use the internal lcd_status_message_level for multiple severity levels
of alert messages.
This is needed to distinguish between non-critical alerts (such as FAN
ERROR) from critical ones (any heater issue). During a failure
scenario, a critical error MUST NOT be overridden by a lower-level one.
As such LCD_STATUS_CRITICAL is currently used for all heater-related
errors that result in a safety full-stop.
2021-12-07 11:06:08 +01:00
a7dfe4b523
Merge pull request #3305 from gudnimg/sd-card-lcdtimer-fix-gudni-v2
...
Fix issue when the SD card is inserted and the file menu may sometimes close immediately due to a timeout
2021-11-19 07:23:21 +01:00
be79e3791f
Fixes #3262
...
Make sure to call lcd_timeoutToStatus.start() when the SD card is inserted
into the printer after it was removed beforehand.
(cherry picked from commit 6795843f15
2021-11-18 19:23:21 +00:00
13732f162b
Fix build error when TMC2130_SERVICE_CODES_M910_M918 is enabled
...
(cherry picked from commit 6ed4b79cc6
2021-11-18 19:19:56 +00:00
6887f844d3
Merge branch 'prusa3d:MK3' into fix-pinda-thermistor-build-fail
2021-11-18 19:15:15 +00:00
f8410d8f3c
Print temperatures only if filament loading is still active
2021-11-18 11:46:36 +02:00
05e0c1e1d3
Fix build error if PINDA_THERMISTOR is not defined
...
temp_cal_active variable is not defined in this scope
2021-10-12 21:52:19 +00:00
eff9cd9f21
Typo: M84 docs
2021-09-27 19:34:53 +02:00
cf8a16baa1
Remove one call to lcd_timeoutToStatus.start
...
Saves 8 bytes of Flash memory
This call is redundant and when moving between menus
it gets called multiple times which results in waste
of clock cycles.
lcd_timeoutToStatus.start() is called from menu_lcd_lcdupdate_func()
which is enough.
2021-08-21 14:34:02 +00:00
e6a7abf2c1
Change temp_runaway_timer from float to uint32_t
...
Saves 32 bytes of flash
Also change temp_runaway_error_counter from int to
uint16_t to be specific
2021-08-06 15:08:46 +00:00
db1e5a203b
Change temp_runaway_status from float to uint8_t and its enum
...
Saves 90 bytes of flash, and 12 bytes of SRAM
2021-08-06 15:03:35 +00:00
b716c208d7
Various optimisation to change int to uint8_t
...
This commit saves 174 bytes of flash memory
2021-08-03 22:42:01 +00:00
8d7d1698ee
Remove unused global variable 'chunkHead'
...
No change in memory on my end, but it is one less 'int' :)
2021-08-03 21:48:26 +00:00
1946c58d21
1. Remove redundant variable 'inters'
...
2. 'gh' variable can be 1 byte instead of 2
This saves 26 bytes of flash memory
2021-08-03 21:46:11 +00:00
05ed5b9668
Improve lcd_selftest_screen_step() parameter types
...
Saves 62 bytes of flash memory
2021-08-03 21:35:28 +00:00
a54a133968
Use memset instead of nested for-loop to zero a 2d array
...
Saves 26 bytes of flash memory and removes two 'int' types
2021-08-02 19:20:51 +00:00
2554d21925
Use uint8_t when using axis enum
...
Saves 76 bytes of flash memory
2021-08-02 12:20:10 +00:00
fd6dbba06f
Merge branch 'MK3_3.10.1' into PFW-1271_PF-buildv20
2021-08-02 08:51:51 +02:00
158877e736
Remove one space from Support -> Temperatures menu
...
Saves 2 bytes of flash memory
2021-08-01 11:20:29 +00:00
da2c802440
Add two defines and use LCD_STR_DEGREE with consistency
...
This saves 12 bytes of flash and 2 bytes of SRAM
2021-08-01 11:10:03 +00:00
6afc87d3c8
Reduce unnecessary LCD CGRAM writes
2021-07-30 23:53:57 +00:00
b1972fdcee
Fixes https://github.com/prusa3d/Prusa-Firmware/issues/3252
2021-07-28 16:47:47 +00:00
8af9f78822
Optimize farm_mode init in setup()
...
This saves 28 bytes of flash memory
2021-07-26 16:37:09 +00:00
21226214a7
Remove MAX_SILENT_FEEDRATE
...
It was last used on MK2 in 3rd July 2017.
I suspect this code was simply forgotten.
2021-07-21 14:06:23 +00:00
25408d14da
Remove unused #ifdef MK1BP
...
MK1BP is never defined anywhere
2021-07-21 06:27:44 +00:00
13477c65c6
Remove two functions EEPROM_read_B() and EEPROM_save_B()
...
This resolves #3218
2021-07-20 17:04:17 +00:00
400f673fe0
Remove redundant extern variable lcd_encoder from menu.cpp
...
This extern variable is included from lcd.h
2021-07-20 09:12:14 +02:00
d087973e00
Remove redundant extern variable is_usb_printing from tmc2130.cpp
...
This extern variable is included from Marlin.h
2021-07-20 09:12:14 +02:00
6aee17b4ca
lcd_change_fil_state has two extern's in Marlin.h, only one needed.
2021-07-20 09:12:14 +02:00
3cfd706fff
Remove useless extern in cmdqueue.cpp
2021-07-20 09:12:14 +02:00
31c8e4bc4c
* Remove redundant externs already included with temperature.h
...
* Add ifdefs in Dcodes.cpp when using extern variables
2021-07-20 09:12:14 +02:00
eb9c8c8c20
Improve mc_arc() parameters
...
- Make the mc_arc() function declaration consistent with the definition
- isclockwise is supposed to be bool type, given how it is used.
2021-07-20 09:03:50 +02:00
538ce06bf0
Remove unused function lcd_choose_color()
2021-07-20 08:55:49 +02:00
bbe62b136a
Remove unused Sound_Save() function declaration
2021-07-20 08:51:57 +02:00
d04ea859fb
Consolidate "Unknown X-Code" to save 16 bytes
2021-07-20 08:19:19 +02:00
47b1e6ccef
Remove spourious trailing whitespace in errors
2021-07-20 08:19:19 +02:00
1888c783cb
Print an error on unknown D-codes
...
This follows the same convention of M/G codes, so that the user knowns
that the D-code has been either handled or ignored.
2021-07-20 08:19:19 +02:00
d853c19a21
Use fabs() instead of abs() when using floats
...
This saves 514 bytes of flash memory
2021-07-20 08:16:18 +02:00
31b913cddb
Correct the C implementation for MultiU16X8toH16
...
The comment behind the ASM MultiU16X8toH16 was misleading.
It actually computes ((a<<8)*b)>>16, or (a*b)>>8.
Correct the comment and C reference implementation accordingly.
2021-07-20 08:10:36 +02:00
710852a1f2
Change nrFiles from int16_t to uint16_t
2021-07-20 08:10:07 +02:00
16602f4003
change boolean to bool
2021-07-20 08:03:17 +02:00
3d871a3aa6
Merge remote-tracking branch 'upstream/MK3' into PFW-1271_PF-buildv20
2021-07-17 19:10:51 +02:00
4580b8a78c
Version changed (3.10.1 build 4587)
2021-07-16 07:37:11 +02:00
153de8e1db
Remove redundant lines
2021-07-10 17:01:13 +00:00
47b8462c38
Remove two functions EEPROM_read() and EEPROM_save()
2021-07-02 20:10:47 +00:00
1279a6cf4b
Correctly read FW_VERSION_NR array from progmem
...
In PR #3093 the progmem array FW_VERSION_NR was introduced to store the
version components, however the code didn't read it properly using the
pgm_read_* functions, making version comparisons fail.
Fix the existing/unused is_provided_version_newer() and reuse it in
show_upgrade_dialog_if_version_newer().
Similarly also read/update correctly the version in the eeprom.
2021-06-28 06:36:26 +02:00
56e531d40a
Improve/fix D23 for M2.5/S printers
...
- Move D23 into it's own function inside Dcodes
- Correctly include a break in the switch statement
- Show the dumper status (enabled/disabled) after toggling
- Allow to generate an immediate dump via g-code using D23 E for
symmetry with D20 E
2021-06-25 08:46:55 +02:00
380e34d481
Include "Dcodes.h" after "Marlin.h" for configuration
...
This is needed in order to get the function prototypes right according
to the actual enabled configuration.
2021-06-25 08:46:55 +02:00
ecce6f865f
write_command() no line number handling
2021-06-25 08:12:30 +02:00
53fcd6fc8f
Work-around GCC LTO codegen bug in process_commands()
...
When building with GCC 4.9.2 (bundled with PF-build-env-1.0.6.*), -Os
and LTO enabled, PID_autotune gets automatically inlined into
process_commands().
Sadly, due to the massive size of process_commands(), it results in
codegen bug doing a partial stack overwrite in process_commands()
itself, manifesting as random behavior depending on the timing of
interrupts and the codepath taken inside the merged function.
Mark the function as noinline and add a note about the affected compiler
version in order to be checked again in the future.
2021-06-24 07:39:28 +02:00
36f2b5375f
Merge remote-tracking branch 'upstream/MK3' into PFW-1271_PF-buildv20
...
merge latest changes and fix isses
2021-06-24 05:53:43 +02:00
66ee9a295f
Remove useless function EEPROM_read_st
2021-06-22 19:08:20 +02:00
8d11ad9d2d
xfdump: correctly erase all sectors in xfdump_erase
2021-06-22 19:07:49 +02:00
88074ac6c8
Remove FW version parsing
...
as it can be done at compile time. Code size dropped by >800 bytes.
2021-06-22 08:49:52 +02:00
6188870c2e
Merge pull request #3157 from wavexx/improve_d2
...
Add extra debugging functions & crash analysis
2021-06-22 07:37:30 +02:00
f36b9173da
Merge pull request #3191 from wavexx/fix_longpress_isr
...
Handle Long-Press in the main loop
2021-06-22 07:09:01 +02:00
79287ffb3d
Use uint8_t consistently for the block buffer's index
...
Instead of using a mixture of int8_t, unsigned char and (incorrectly)
int, use uint8_t consistently for indexing the current block.
This improves the performance of the wait loop in plan_buffer_line,
which currently expands all comparisons to a word for no reason.
This also extends the theoretical limit to 128 entries.
Add some static assertions to ensure BLOCK_BUFFER_SIZE is correct.
2021-06-22 06:59:57 +02:00
f4fcdae630
Fixup the DUMP_MAGIC constant
2021-06-22 00:04:39 +02:00
934b567e5a
Remove "bonus" exclamation points from the crash message
2021-06-21 22:37:28 +02:00
edde002cdc
Merge remote-tracking branch 'upstream/MK3' into fix_longpress_isr
2021-06-21 11:51:45 +02:00
3c649a89d3
Merge remote-tracking branch 'upstream/MK3' into PFW-1271_PF-buildv20
2021-06-21 08:01:24 +02:00
30d9faef9d
Minor fixes to SD presence handling ( #3139 )
...
* Remove forgotten function protorypes
* Fix code indentation
* Fix double sorting if SD card is inserted during setup()
* Correctly handle SD removal during sorting
2021-06-21 07:30:47 +02:00
0cbc759d8b
Second attempt at retrieving the SN from the 32u2 IC
2021-06-21 07:24:41 +02:00
6d25345fc4
optiboot_xflash comment about w25x20cl messages
...
Mention supported ICs
2021-06-21 07:21:40 +02:00
a92c0278fe
Use LCD_WIDTH instead of hardcoding 20
2021-06-21 07:21:10 +02:00
8a7dd08116
Fixed C++ bug
2021-06-21 07:05:17 +02:00
09e935d27b
Fix two new explicit case fallthru warnings
2021-06-21 06:52:52 +02:00
d727a949dd
Silence explicit case-fallthru
2021-06-21 06:52:52 +02:00
c096462aab
Clarify statement by adding extra braces
2021-06-21 06:52:52 +02:00
051f03119b
Fix misleading indentation warnings by expanding tabs
2021-06-21 06:52:52 +02:00
f2fe57bfc0
Fix unused static declaration warnings
...
Guard declarations using the appropriate defines
2021-06-21 06:52:52 +02:00
7bd43b77d7
Remove unnecessary assignment
2021-06-21 06:47:59 +02:00
eafdf6c216
Also move host_keepalive to manage_inactivity()
...
This avoids the "busy" output interleaving with regular output in very
rare scenarios.
We should focus in finding which calls are not using manage_inactivity()
properly instead of working it around.
2021-06-21 06:46:24 +02:00
29322d4bf3
Move host_autoreport() to manage_inactivity()
...
This makes autoreport work more consistently.
2021-06-21 06:46:24 +02:00
5c8a231ed6
Move autoreporting out of the temperature ISR
...
Code running in the temperature ISR needs to be fully reentrant, which
is hard to track down.
Move autoreporting to the main processing loop. This can make the
autoreporting slower or pause at times, but removes the reentrant
restriction, which allows us to use printf_P.
2021-06-21 06:46:24 +02:00
97f66a6a13
Remove ignored/incorrect PROGMEM
...
This PROGMEM is currently ignored by gcc, but even if it wasn't it
wouldn't be correct since the following code is expecting to read "item"
without fetching the array itself from PROGMEM.
2021-06-21 06:44:19 +02:00
5bb8bb2ccb
Merge pull request #3134 from wavexx/fix_partial_redraw2
...
Redraw "Preheating to load" in full when modified by other actions
2021-06-21 06:42:13 +02:00
700825ff76
serial_dump: include hex prefix
2021-06-19 13:57:40 +02:00
bff79d290a
GETPC: Do not manipulate the 32bit return address
...
We can do that offline, saving over 30 bytes of instructions.
2021-06-19 13:56:40 +02:00
72b8f0d1e6
Add some warnings in lcd_buttons_update
2021-06-19 13:46:10 +02:00
06d91ddcee
Handle Long-Press in the main loop
...
The longpress function is currently called within the temperature ISR,
which is bogus. Calling the longpress function at the wrong moment
can corrupt the menu buffers.
Move the call to the main loop by changing the logic slightly:
- still sample the lcd buttons inside the temperature ISR, which keeps
scrollong/pressing responsive, but...
- set a flag to indicate that longpress has been triggered instead of
calling the function directly
- call the function on the next manage_inactivity run
Combined with #3180 this removes _most_ unsafe operations out of the ISR
which can happen during a normal run (max/mintemp warnings are still an
exception).
2021-06-17 20:07:01 +02:00
56889bae13
Update PF-build.sh to work after @DRracer Remove FW version parsing PR
2021-06-17 19:08:55 +02:00
dd8c6c064c
xfdump: simplify stack debugging (sample pc+sp)
...
Instead of having to guess the PC where the SP was sampled, always take
both. This allows "seamless" stack decoding for both serial and xflash
dumps, since we don't have to guess which function generated the dump.
Make the core functions (doing the sampling) be ``noinline`` as well,
so that they always have valid frame.
2021-06-17 01:29:25 +02:00
97535ec0c1
Fix last commit
2021-06-15 22:10:08 +02:00
e6d520cf6e
Add test code for the stack overflow handler
2021-06-15 18:49:20 +02:00
a614268c94
serial_dump_and_reset: do not call manage_heater with interrupts disabled
...
Do not call manage_heater() in print_mem() if interrupts are already
disabled. This means we're running inside the crash handler.
2021-06-15 18:44:44 +02:00
d193d0f7ac
serial_dump: manipulate WDT just once
2021-06-15 16:21:56 +02:00
928c7211ad
emergency handlers: always save SP _at_ the crash location
...
Save SP which is closest to the crash location, which simplifies
debugging. For serial_dump, write SP just before the dump.
For xfdump, save SP in the dump header.
This makes xfdump_dump and xfdump_full_dump_and_reset() equivalent for
stack debugging.
2021-06-15 11:47:27 +02:00
96aad0a475
Remove duplication in crash handlers
...
It's kind of nice that all handlers eventually came to become the same.
2021-06-14 12:38:23 +02:00
fa0f58d5bc
serial_dump: add description about bad_isr
2021-06-14 12:30:24 +02:00
8e667a8acd
bad ISR catch
2021-06-14 11:30:38 +03:00
d2041ee2fe
Enable debugging features on all variants
...
- XFlash crash dumper on MK3+ series
- Online crash dumper on MK2.5+ series
- D2/D6 on MK3+ series
- D2 on MK2.5+ series
2021-06-13 22:35:43 +02:00
7db667ca86
serial_dump_and_reset: turn on print fan while dumping
...
To avoid scorching the sheet while dumping close to the bed.
2021-06-13 22:28:28 +02:00
ea51d65137
serial_dump_and_reset: do not completely disable WDT
...
Set it to 8s which is long enough to complete the dump.
2021-06-12 15:39:37 +02:00
6de98f7b0d
Move inclusion closer to the usage point
2021-06-12 15:33:18 +02:00
050cf72e98
Move stack checking to the temperature ISR
...
Now that the stack_error function is truly minimal,
we can check for stack errors much more frequently.
Also move away stack_error from ultralcd to Marlin_main.
2021-06-12 15:23:33 +02:00
01934b89e9
xflash_dump is now always required in all variants
2021-06-12 15:13:32 +02:00
449510392d
Untangle a bit some recursive include mess
2021-06-12 15:09:03 +02:00
e28301f391
Report crash also in MK2.5, fix stack_error abuse
...
Rename EEPROM_CRASH_ACKNOWLEDGED to EEPROM_FW_CRASH_FLAG.
Use EEPROM_FW_CRASH_FLAG to always set the last crash reason, which
simplifies handling between the online/offline variants.
Make stack_error safe, by setting the flag and restarting immediately,
so that the error can be shown after restart.
2021-06-12 14:41:54 +02:00
bd57e00448
Implement an online crash dumper for MK2.5 boards
...
When XFLASH is not available, allow users to request _online_ crash
dumps by using D23 (since these require active user cooperation).
Once enabled, instead of just rebooting, dump memory directly to
the serial.
As similarly done with EMERGENCY_DUMP, we have two features that can be
enabled:
EMERGENCY_SERIAL_DUMP: enables dumping on crash after being requested
MENU_SERIAL_DUMP: allow triggering the same manually through the support
menu.
2021-06-12 13:37:20 +02:00
f7dc8dcaef
Fix usage of RAMEND
...
RAMEND is the last valid address, not one-past as I expected it to be...
2021-06-12 13:16:12 +02:00
f18d4757c6
Introduce STACK_GUARD_MARGIN in all variants
...
Create a gap between the BSS and the stack guard.
Set this gap (STACK_GUARD_MARGIN) to 32 bytes in all variants.
The gap serves two purposes:
- Detect a stack overflow earlier (falsely triggering in overtight
situations is OK!), so that we can hopefully avoid smashing
the heap and have a clean view during the dump.
- Reserve spack space itself for the stack dumping machinery,
which is going to grow the stack even further.
Remove get_stack_guard_test_value() which was unused.
2021-06-12 12:08:53 +02:00
9663653671
xfdump_erase: remove redundant XFLASH_SPI_ENTER()
2021-06-12 12:05:02 +02:00
3187b96ca4
xfdump: report to the host that a dump is available
...
As suggested by @3d-gussner, announce to the host that a dump is
available for retrieval using an action "dump_available".
Any kind of dump is announced (even if manually triggered).
To avoid reading from xflash twice, remove some duplication and return
the crash reason directly in xfdump_check_state().
2021-06-11 19:21:51 +02:00
31f416fd5e
Rename dump_crash_source to dump_crash_reason
2021-06-10 17:35:49 +02:00
c375610668
Move "WDR dump" inside EMERGENGENCY_DUMP
2021-06-10 17:02:41 +02:00
63f870c089
Enable the "WDR reset" menu item in DEBUG_BUILD only
2021-06-10 16:30:59 +02:00
0362b6484f
xfdump_full_dump_and_reset: set a guaranteed minimum WDT
...
Just prior to dumping, reset the WDT to a known-safe (and not too long)
interval that guarantees a complete dump.
2021-06-10 16:30:39 +02:00
0a77f2c02d
Dump header as well
2021-06-10 11:58:46 +03:00
094c577e9d
Fix XFLASH_DUMP print_mem
2021-06-09 14:10:20 +03:00
1e786c7f55
WDR crash initial
2021-06-09 13:59:26 +03:00
8c3d76f85f
Fix millis reference
2021-06-09 12:44:28 +03:00
fab04dbc6c
D6: remove option for unsupported models
2021-06-08 19:53:37 +02:00
318ee695c2
xfdump_layout: add some comments
2021-06-08 19:50:43 +02:00
c2e64c8c6e
xfdump: fix another off-by-one static size check
2021-06-08 19:08:03 +02:00
378f239ff0
dcode_code: fix inverted define to print larger types
2021-06-08 18:57:16 +02:00
56d0848ea9
xfdump: fix size check
2021-06-08 18:43:32 +02:00
9d3b19b637
xfdump: defensive static checks to ensure dump location always fits
2021-06-08 18:29:55 +02:00
dcfdce87c7
Document new applicable build options in the variant files
...
Document, but don't enable them.
Leave exiting functionality unchanged for now.
2021-06-08 18:17:56 +02:00
c072fbbf02
Dcodes: fix daddr_t type when only XFLASH_DUMP is enabled
2021-06-08 18:14:49 +02:00
c331c07b16
xfdump: reuse standard definitions for SRAM size/offset
2021-06-08 17:53:06 +02:00
520f7a2e26
config: add sanity checks for XFLASH_DUMP options
2021-06-08 17:32:14 +02:00
1a88e339bf
xfdump: fix build with XFLASH_DUMP disabled
2021-06-08 17:17:18 +02:00
a6e372e696
Typo
2021-06-08 17:14:22 +02:00
c31109c750
Implement MENU_DUMP: offline memory dump from "Support"
...
If MENU_DUMP is enabled, a new entry at the end of the "Support" menu is
added that allows to dump memory for offline use.
This allows to trigger a memory dump at any moment during regular usage
(either idling or printing) and to recover the dump later even after a
hardware reset.
2021-06-08 16:56:58 +02:00
c089ac5341
Implement EMERGENCY_DUMP for offline analysis
...
If EMERGENCY_DUMP is defined, crash and dump using the new xflash dump
functionality instead of just continuing with an error message.
When an emergency crash is stored, the first restart after a crash
displays a message that debug data is available and to contact support
to submit the crash for analysis.
2021-06-08 16:42:43 +02:00
e7f78125d3
Merge remote-tracking branch 'panayiotis/FixEepromAddressDocumentation' into improve_d2
2021-06-08 16:18:09 +02:00
30402e0404
Dcodes: add D20/D21/D22 to generate/read/clear dumps
2021-06-08 15:34:39 +02:00
6dfef76346
xfdump: implement dump-to-xflash functionality
...
Update xflash_layout to include information about the dump, which sits
at the end of xflash.
2021-06-08 15:28:02 +02:00
b398a09a4f
xflash: add xflash_multipage_program and documentation
...
Add a new high-level command to perform multipage writes quickly.
2021-06-08 15:25:16 +02:00
86e753fe37
xflash: remove some duplication
2021-06-08 15:24:46 +02:00
5ae8bad0ba
Introduce "xflash_layout" to organize XFLASH's content
...
Update the language code to use the new LANG_OFFSET definition
and remove hard-coded flash sizes.
2021-06-08 15:22:37 +02:00
af636c7f2a
Move "xflash" include inside the conditional
2021-06-08 15:18:33 +02:00
0fcdada579
D6: add documentation
2021-06-07 19:58:18 +02:00
ed9f52dd85
D6: also hide declaration behind conditional
2021-06-07 18:50:45 +02:00
db096557d4
D[236]: remove "busy" messages while dumping, avoid WDT
2021-06-07 16:41:25 +02:00
12e124324f
Remove PROGMEM handling from print_mem until D5 uses dcode_core
...
Handling PROGMEM also requires a 32bit address type.
2021-06-07 16:41:25 +02:00
f9371146d0
Implement reading XFLASH with D6
...
This requires expanding the dcode_core address type to 32bit type,
thus enlarges the D2/D3 implementation as a result.
Still allow to save all the original space if D6 is disabled, for now.
2021-06-07 16:41:25 +02:00
915f5a7692
Unify D2 and D3 handling
...
Handle reading/writing memory using the same base functions
in order to save space.
2021-06-07 16:41:25 +02:00
2d25a5705f
Fix D2 to read the entire SRAM content
...
Allow to read up to 0x21ff, which is the last byte of SRAM. Set default
starting address to 0x200, which is the first true byte.
0x0-200 is mapped to register/io space and could cause issues when read
from bi-directional registers.
2021-06-07 16:37:34 +02:00
62f496e1d6
Allow D2 to be enabled selectively
2021-06-07 16:37:34 +02:00
6bb7c0e3d3
Farm workaround M1 message
...
Farmers want to abuse a bug from the previous firmware releases
- they need to see the filename on the status screen instead of "Wait for user..."
So we won't update the message in farm mode...
2021-05-25 09:45:42 +02:00
3c63ddaafd
Fix the eeprom address documentation
2021-05-22 17:09:55 +03:00
04de9c0c8a
Version changed (3.10.0 build 4481)
2021-05-06 13:46:05 +02:00
1a92f2e19f
Merge remote-tracking branch 'upstream/MK3_3.10.0' into fix_partial_redraw2
2021-05-04 10:49:24 +02:00
eaa6801849
Merge pull request #3136 from leptun/PFW-1225_fix_open_file_from_sd_wrong_file
...
Fix menu_action_sdfile() check_file(filename) call
2021-04-29 16:34:01 +02:00
80e248662c
Merge pull request #3079 from 3d-gussner/PFW-1189
...
PFW-1189 Pre-release tasks
2021-04-29 16:33:18 +02:00
89386036e6
Merge pull request #3137 from leptun/PFW-1239_fix_M23_subroutine_issue
...
Do not allow M23 to run subroutines
2021-04-29 15:06:33 +02:00
a3b392d96c
Merge pull request #3130 from DRracer/move-alldata-2-end
...
Move All Data into last position in Factory Reset menu
2021-04-29 10:08:32 +02:00
8610d0a850
Do not allow M23 to run subroutines
2021-04-29 10:59:21 +03:00
7c914ec2d1
Merge pull request #3125 from leptun/PFW-1238_fix_M105_from_SD
...
Fix M105 from SD
2021-04-29 09:12:05 +02:00
1a70f3369d
fix comment
2021-04-29 09:48:25 +03:00
d9976ca69c
Fix menu_action_sdfile() check_file(filename) call
2021-04-29 09:47:16 +03:00
a9ae8ea731
Remove `SpoolJoin` from translations
2021-04-29 08:15:24 +02:00
488d9d4b38
Remove "Firmware" from translations
...
deleted another unused "Firmware" define in language.h
2021-04-28 18:02:36 +02:00
d251f3980a
Remove FlashAir from translations
2021-04-28 17:57:39 +02:00
b5ba4041d3
Remove FINDA from translations
2021-04-28 17:36:17 +02:00
08566d4121
Remove PINDA from translations
2021-04-28 17:33:52 +02:00
30b383195d
Remove copy/paste error
2021-04-28 17:29:32 +02:00
aee04a43e2
Redraw "Preheating to load" in full when modified by other actions
...
Check for lcd_draw_update to see if the lcd has been altered outside the
function and redraw the screen if full.
This fixes scenarios such as #3129 where the "Card removed" message or
the SD menu is entered from outside the function's control.
This requires checking/resetting bFilamentWaitingFlag carefully to avoid
re-entering this function _twice_ (raise_z_above will run the main
loop until complete).
2021-04-28 17:13:46 +02:00
5089b2cddb
Move All Data into last position in Factory Reset menu
2021-04-28 06:43:54 +02:00
7a54c3638c
Remove web links and `Prusa i3 MKxy OK.` from translations
...
as these never have been translated or doesn't make sense
to translate web links
2021-04-27 20:36:22 +02:00
686054b95e
Changed `x of 4` and `y of 9` to `x/4` and `y/4`
...
Added `Iteration` translation
2021-04-27 20:22:28 +02:00
738a24178a
Update #MSG_FIND_BED_OFFSET_AND_SKEW_LINE1 c=20 r=3
2021-04-27 07:45:36 +02:00
b8ae08fd3d
Update `x of 4` and `x of 9` messages so longer text can be used.
2021-04-27 07:18:52 +02:00
1145b231a9
Define MSG_SELFTEST_FS_LEVEL
2021-04-26 14:30:20 +02:00
af519626aa
Define MSG_FS_V_04_OR_NEWER and MSG_FS_V_03_OR_OLDER c=14
2021-04-26 14:21:33 +02:00
b522ef4812
Update MSG_SEVER_SKEW and MSG_SLIGHT_SKEW message to c=14
...
Changed and tested Support-> "XYZ cal. details" LCD output
2021-04-26 12:39:13 +02:00
536a8f5f87
Revert that has been commited by mistake
2021-04-26 07:28:03 +02:00
466de83ae0
Remove white spaces in messags which saves ~62bytes
2021-04-26 07:22:22 +02:00
29ad021b23
Updated French translation of MSG_MMU_LOAD_FAILED c=20 as @awenelo suggested
2021-04-24 20:50:01 +02:00
9f77ca31b8
Set MSG_SET_TEMPERATURE chars to c=20
...
Fix Italian warning shown by `lang-check.py`
2021-04-24 08:19:48 +02:00
aa45091400
Scale extruder motor current linearly with speed. ( #2813 )
...
Scale extruder motor current linearly with speed.
49% less heating when running at low speed and standstill, 4% more torque at maximum extrusion rate (15mm^3/s), 15% more torque in high speed movements (un/retractions).
StealthChop mode is used for low speeds (below 900mm/min)
spreadCycle is used above. Transition speed is well above maximum extrusion rate of 15mm^3/s (275mm/min) so mode transition is not expected to be visible on printed surface.
StealthChop is expected to improve printed surface quality (less artifacts).
Warning you can burn extruder motor if it is not the same impedance as original Prusa i3 Extruder stepper motor. There is no current feedback in low speed so lower impedance motor can be burned by over current.
Even there is no direct current feedback, there is no risk for original motor thermal runaway, as motor resistance increases with temperature, current decreases.
Standstill peak phase current is expected to be 500 mA and linearly increase with speed to 970 mA at 900mm/min where spreadCycle constant current regulation takes over and keeps peak current at 805 mA to maximum speed possible.
As motor heating increases with current squared, lowering low speed current from 700mA to 500mA decreases heating 49% in thate mode, where motor spends most of the time.
Enable E-motor cool mode in farm mode only (and experimental menu) - the experimental menu is visible AND the EEPROM_ECOOL variable has a value of the universal answer to all problems of the universe - i.e. two conditions must be met at the start of the FW to enable the E-cool mode. If the user enables the experimental menu, sets the E-cool mode and disables the menu afterwards, on the next start of the FW the E-cool mode will be DISABLED. This is still subject to discussion how much obscure (security through obscurity) we'd like this option to have .
Additional stuff:
* Add serial debug msg to verify if E-cool mode is on
* Avoid access to E-cool mode switch on machines without TMC2130
* Do not allow only M907 E in case of E-cool mode+warn the user on the serial line that the command was skipped
Co-authored-by: D.R.racer <drracer@drracer.eu>
2021-04-23 16:06:28 +02:00
c2cde83d7e
Fix MSG_SELFTEST_WIRINGERROR to c=18
2021-04-23 13:29:45 +02:00
3f51627c02
Fix MSG_NO being too short, no need to be
2021-04-23 13:23:11 +02:00
013708479f
Fix MSG_UNLOAD_FILAMENT length as in MMU a number is added
2021-04-23 13:12:57 +02:00
032e8a5957
@leptun strip 1st char hack for duplicate `Cancel`
2021-04-23 13:03:59 +02:00
403b340f19
Added ` EXTENDED_M20` to RepRap Gcode wiki `M115` see https://reprap.org/mediawiki/index.php?title=G-code&type=revision&diff=189034&oldid=189033
2021-04-23 11:02:42 +02:00
635bc442d6
Fix M105 from SD
2021-04-23 11:14:16 +03:00
28aec049a2
Fix Typo in MSG_FIL_FAILED
2021-04-23 09:41:12 +02:00
ff9185d1bb
Readded `>Cancel` as the `>` has some meaning. Sadly the previously 10bytes more free space are gone again
2021-04-23 08:50:50 +02:00
044c0a0a6a
Update "\04Refresh" message as two "abcd" "efgh" in one line cause issues in lang-build scripts
2021-04-23 08:49:22 +02:00
e18d688b64
Fix merge issues
2021-04-22 20:48:26 +02:00
681bc560c9
Merge remote-tracking branch 'upstream/MK3_3.10.0' into PFW-1189
2021-04-22 20:43:54 +02:00
999b93be35
Merge pull request #3123 from prusa3d/MK3_3.10.0
...
MK3 3.10.0
2021-04-22 12:53:26 +02:00
00ce16ee55
Merge pull request #3121 from wavexx/reduce_m600_min_height
...
Revert/cleanup mininum extruder height during M600
2021-04-22 11:43:18 +02:00
1e0fd8af87
Merge pull request #3120 from wavexx/fix_lcd_redraw_autoload
...
Fix partial redraw during filament autoload
2021-04-22 10:36:40 +02:00
98643825dc
Merge pull request #3055 from awenelo/add-satin-sheet
...
Add satin sheets
2021-04-22 07:13:32 +02:00
daef5428d2
Rework gcode_M600_filament_change_z_shift to make it consistent
...
gcode_M600_filament_change_z_shift is almost useless, since it performs
what is already been done internally by filament_unload().
However it *does* cause the carriage to raise earlier during unload
compared to making the user wait after "press for unload".
Change it so the calculated Z height matches MIN_Z_FOR_SWAP.
2021-04-21 19:12:26 +02:00
8d04316497
Revert/cleanup mininum extruder height during M600
...
This change restores the minimum extruder height for filament purge
during M600 from the current 50mm back to 27mm from FW 3.9.
We do this by introducing a new option for unload_filament() to indicate
that the unload is part of an automatic swap, and in such cases avoid
raising more than absolutely necessary (this will _also_ come in handy
to avoid the extra purge in PR #2318 during M600).
A new define MIN_Z_FOR_SWAP is introduced for this purpose.
MIN_Z_FOR_UNLOAD is still used for manual lcd unload and for M702 and
hasn't been changed.
2021-04-21 19:07:58 +02:00
bc355674d9
Fix partial redraw during filament autoload
...
If the printer was already being pre-heated but didn't reach the target
temperature yet and a new filament is being inserted, the LCD used to
display a "Preheating to load" message to block the loading until the
extruder is hot.
This message is currently missing, and the ">Cancel" option doesn't
display immediately either, depending on the extruder height.
This PR fixes this behavior, which was broken during an earlier update.
We now force-update LCD updates during the first (and _only_) time the
screen is setup, and push all messages _before_ the carriage is
eventually raised, so that ">Cancel" is shown immediately as well.
2021-04-21 16:56:16 +02:00
7d82cab125
Update doxygen
2021-04-20 09:16:56 +03:00
c4b70b82f3
Document M20 T parameter
2021-04-20 09:13:38 +03:00
1c0383c48f
Add capability report for extended M20
2021-04-20 09:03:22 +03:00
7011014abb
Save 16 bytes - pass ls_param by value to functions
...
... as ls_param is a 1-byte structure it is more conservative to pass it
to functions by value than by a pointer
2021-04-20 06:50:37 +02:00
2129bcf315
M20 T
2021-04-19 14:48:50 +03:00
b16e1e5235
Invert size and LFN in M20 L output
2021-04-19 13:54:43 +03:00
6d7d8c7c75
Do not show hidden/system dirs with M20 L
2021-04-19 13:31:30 +03:00
a5e4df390d
Sync before/after setting mesh_bed_leveling_flag/homing_flag
...
mesh_bed_leveling_flag and homing_flag should be set only when the
planner is empty as a consequence of #3100 , since any operation executed
*while* the mbl/homing flag is set is considered part of the compound
instruction that generated it (G80, G28, G30, G76).
Failure in doing so can result in instructions just prior being lost,
since they're incorrectly discarded (assumed to be redone).
G1 ; lost ..
G80 ; .. if PP happens here
2021-04-19 06:31:57 +02:00
23c75da727
Fix Crash/PP recovery position on instructions with comments
...
PR #2967 altered the way ``sdpos_atomic`` was set, causing issues in the
crashdetect/powerpanic recovery offset if the instruction being
recovered happens to contain a comment.
Previously ``sdpos`` was assumed to be a single byte prior to the last
read character. sdpos+1 would thus position the index to the next
instruction. With gcode-filtering in place, sdpos is left just before
the comment, while the actual read position is at the newline. This
causes to parser to resume in the middle of the comment.
Change the value returned by cardreader::get_sdpos() to always return
the last read position, as everybody expects (!!).
This avoids the +1, and correctly sets the resume position to the next
valid instruction without overhead.
2021-04-19 06:30:37 +02:00
c43688a549
Version changed (3.10.0-RC2 build 4104)
2021-04-16 13:52:36 +02:00
5a91e1de4d
Calibration: fix checking of scan of calibration points
...
PFW-1223
2021-04-14 06:25:18 +02:00
7356cd0811
EEPROM_JOB_ID
2021-04-09 08:09:51 +02:00
f9f6284c50
Merge pull request #3100 from wavexx/powerpanic_state_fixes
...
Fix PowerPanic and Crash Detection during homing and bed leveling
2021-04-07 18:19:50 +02:00
61faa49cbb
Fix buffer overflow in buf
...
Fix cmd overflow introduced in 186ce0f
2021-04-07 15:57:50 +02:00
d31601dcb8
Use correct mfrid for gd25q20c
2021-04-06 10:16:47 +02:00
94c1e65d83
Fix MK2.x builds
2021-04-06 10:16:47 +02:00
56948157d0
GD25Q40C xflash support
2021-04-06 10:16:47 +02:00
07bf4bbe48
Fix gd25120c rd_uid command
2021-04-06 10:16:47 +02:00
9454f9d8ec
Rename w25x20cl to xflash
2021-04-06 10:16:47 +02:00
449d181971
G80: handle power panic
...
This is handled in the same way crash detection is handled: homing/mbl
invalidates saved_target _and_ current position.
Fixes PP recovery during MBL and homing.
2021-04-06 02:20:00 +02:00
b46a52ffa8
G80: Handle crash detection
...
At a higher level, crash detection will repeat the last gcode command.
Some commands such as G28 or G80 need to be repeated in full and require
special handling.
In such cases, do not store the saved target coordinate (which is fake
in such cases) and invalidate the saved position.
This fixes the last coordinate of the first G1 move after recovery.
We also avoid moving from the origin when the saved position is
invalidated, which is not strictly necessary, but saves some time.
2021-04-06 02:00:47 +02:00
a5530593fa
G80: preserve lcd status and message when aborting
...
Restore the old status just before returning, so that the subsequent G80
can restore the first (initial) message correctly.
2021-04-06 00:31:56 +02:00
5923276a86
G80: correctly abort during crash detection
...
Crash detection is handled at a higher level (which automatically
repeats the current command), however we still need to abort the current
command correctly.
Handle XY crashes by checking the planner status after st_synchronize().
2021-04-06 00:31:29 +02:00
5da39df968
G80: Use consistent XY axis feedrate
2021-04-06 00:10:33 +02:00
ce2e35d14d
Move G80 into it's own function
...
No actual changes done in the function in this, besides break->return.
In G28, simply call the new function instead of using goto, making the
code more readable.
Also remove the senseless comments in G28 about command queuing (dating
back to when G80 was queued instead of being executed).
2021-04-05 23:35:17 +02:00
d2be40491b
PP recovery: clamp initial position to software endstops
...
As done when initializing the printer from a cold start, we need to
clamp the starting position to software endstops before setting the
planner position since 0,0 is frequently out-of-bounds.
This avoids an useless move during recovery that can cause a crash:
- Initial X is set to be 0
- G1 performed by homing will clamp X>=0, resulting in a positive shift
- If X is already at max X (extruder being parked due to PP), this will
slam at X+, causing an immediate crash.
2021-04-05 22:11:06 +02:00
3276320a06
Hide tmc2130_sg_change behind DEBUG_CRASHDET_COUNTERS
...
tmc2130_sg_change is only used for debugging purposes.
Hide definition and usage behind the required define.
2021-04-05 20:07:03 +02:00
6a61c26955
Removed unused crashdet_stop_and_save_print2
2021-04-05 20:04:50 +02:00
b74e1d6062
Update RepRap url for `M123`
2021-04-01 19:48:14 +02:00
e12c1dde5c
Updated RepRap Wiki and removed the @todos
2021-04-01 19:06:31 +02:00
3b431bcbc1
Fix output "Y distance from min" by removing ":" so translations can use 20 chars
2021-03-31 08:54:16 +02:00
d864a5cfdb
Define #MSG_PRINTER_IP c=18
2021-03-31 08:46:17 +02:00
9922774fa7
Cleanup some comments ////c=
2021-03-31 08:11:19 +02:00
8e74cbce58
Remove r=1 and some minor fixes
2021-03-31 08:07:42 +02:00
fb691b44b4
Update #MSG_INFO_SENSORS c=18
2021-03-31 07:51:22 +02:00
3fb90be46f
Define #MSG_SELECT c=18
2021-03-31 07:50:18 +02:00
9a0e67c1d7
Define #MSG_RENAME c=18
2021-03-31 07:43:48 +02:00
15919a0f09
Define #MSG_NOZZLE_DIFFERS_CONTINUE c=20 r=5, #MSG_NOZZLE_DIFFERS_CANCELLED c=20 r=9
2021-03-31 07:41:21 +02:00
cdfc40fb62
Define #MSG_MODE_CHANGE_IN_PROGRESS c=20 r=3
2021-03-31 07:38:41 +02:00
c0869efc76
Define #MSG_MK3S_FIRMWARE_ON_MK3 c=20 r=4, #MSG_MK3_FIRMWARE_ON_MK3S c=20 r=4
2021-03-31 07:36:26 +02:00
268d4020cf
Define #MSG_FINDA c=5 and update #MSG_PINDA c=5
2021-03-31 07:32:43 +02:00
c0b8eef6cd
Define #MSG_FALSE_TRIGGERING c=20
2021-03-31 07:29:42 +02:00
1ca443f1f4
Define #MSG_CHECKS c=18
2021-03-31 07:28:18 +02:00
5e049283be
Define #MSG_UNKNOWN c=13
2021-03-31 07:24:41 +02:00
982153fee1
Define and update #MSG_PRINT_TIME c=19, #MSG_FILAMENT_USED c=19, #MSG_TOTAL_FILAMENT c=19, #MSG_TOTAL_PRINT_TIME c=19
2021-03-31 07:16:36 +02:00
7a88ce89e4
Update MSG_TEMPERATURE c=18
2021-03-31 07:11:01 +02:00
c0df79d39a
Define #MSG_SELECT_TEMP_MATCHES_MATERIAL c=20 r=4
2021-03-31 07:10:03 +02:00
7268f6a824
Define #MSG_SELECT_FILAMENT c=20
2021-03-31 07:08:09 +02:00
2e43234d3f
Update #MSG_SUPPORT c=18
2021-03-31 07:06:46 +02:00
ba38262109
Update #MSG_STATISTICS c=18
2021-03-31 07:05:28 +02:00
960ebac02d
Update #MSG_SPEED c=15
2021-03-31 07:04:47 +02:00
b52d87e9a5
Define #MSG_Z-LEVELING_ENFORCED c=20 r=4
2021-03-31 07:02:42 +02:00
acbdc2ac8d
Define #MSG_RUNOUTS c=7
2021-03-31 06:59:16 +02:00
09f4850a8a
Define #MSG_SLIGHT_SKEW c=13, #MSG_SEVERE_SKEW c=13
2021-03-31 06:53:04 +02:00
4749dd1750
Define #MSG_CHECK_IR_CONNECTION c=20 r=4
2021-03-31 06:46:43 +02:00
bd8ab39b39
Define #MSG_UNLOAD_FILAMENT_REPEAT c=20 r=4
2021-03-31 06:45:33 +02:00
5280a89fba
Define #MSG_MMU_INSERT_FILAMENT_FIRST_TUBE c=20 r=6
2021-03-31 06:43:21 +02:00
0d48a32e87
Define #MSG_RESUME_NOZZLE_TEMP c=20 r=4
2021-03-31 06:41:17 +02:00
4f394c8c5a
Update #MSG_TUNE c=18, #MSG_PREHEAT c=18
2021-03-31 06:38:50 +02:00
fbecae1707
Update MSG_PREHEAT c=18
2021-03-31 06:38:06 +02:00
ac810bf03a
Define #MSG_REMOVE_SHIPPING_HELPERS c=20 r=3
2021-03-31 06:36:28 +02:00
00b100bf26
Define #MSG_NOZZLE_FAN c=10, #MSG_PRINT_FAN c=10
2021-03-31 06:30:00 +02:00
baf231b0f1
Update MSG_NO_CARD c=18
2021-03-31 06:23:18 +02:00
1c09e8411d
Define #MSG_PINDA c=6 and remove duplicate saved 8 bytes
2021-03-30 19:30:26 +02:00
6a266d497b
Define #MSG_REMOVE_TEST_PRINT c=20 r=4
2021-03-30 19:19:43 +02:00
5fcc731be1
Define #MSG_INSERT_FIL c=20 r=6
2021-03-30 19:17:48 +02:00
243fa68745
Define #MSG_LIN_CORRECTION c=18
2021-03-30 19:16:11 +02:00
44f7be134d
Define #MSG_FS_VERIFIED c=20 r=3
2021-03-30 19:13:31 +02:00
bcdaecb46d
Define #MSG_TO_LOAD_FIL c=20, #MSG_TO_UNLOAD_FIL c=20, #MSG_PRESS_KNOB c=20
2021-03-30 19:10:56 +02:00
de9697b913
Define #MSG_PREHEATING_TO_LOAD/UNLOAD/CUT/EJECT c=20
2021-03-30 19:06:46 +02:00
d601355d40
Define #MSG_GCODE_NEWER_FIRMWARE_CONTINUE c=20 r=5, #MSG_GCODE_NEWER_FIRMWARE_CANCELLED c=20 r=8
2021-03-30 19:01:24 +02:00
669ab0f7f7
Define #MSG_GCODE_DIFF_CONTINUE c=20 r=4, #MSG_GCODE_DIFF_CANCELLED c=20 r=7
2021-03-30 18:58:04 +02:00
e9750a7312
Update #MSG_FIL_FAILD c=20 r=5
2021-03-30 18:52:58 +02:00
4a5d7bc6b7
Define #MSG_Y_DIST_FROM_MIN c=20
2021-03-30 18:51:04 +02:00
2abdfeb4c5
Update #MSG_YES c=3
2021-03-30 18:48:14 +02:00
7f3fe6740b
Update #MSG_NO_MOVE c=20
2021-03-30 18:46:56 +02:00
1a1a1d88a7
Update MSG_MOVE_X/Y/Z c=18
2021-03-30 18:13:49 +02:00
c1f22a5239
Update #MSG_MOVE_AXIS c=18
2021-03-30 18:12:03 +02:00
99893d5066
Define #MSG_MMU_CONNECTED c=18
2021-03-30 18:11:22 +02:00
77a7a92a42
Define MSG_MMU_LOAD_FAILED c=20
2021-03-30 18:08:13 +02:00
4d9dffb042
Define #MSG_MEASURED_SKEW c=13
2021-03-30 18:06:43 +02:00
1e2dde9a52
Update #MSG_MEASURE_BED_REFERENCE_HEIGHT_LINE1 c=20 r=3
2021-03-30 18:02:27 +02:00
afb7c82e26
Update #MSG_LOAD_TO_NOZZLE c=18
2021-03-30 18:00:20 +02:00
2408bc9f2e
Update MSG_LOADING_COLOR c=20
2021-03-30 17:58:51 +02:00
62ecbb3ae3
Update #MSG_BABYSTEP_Z c=18
2021-03-30 17:57:50 +02:00
50e69fcca8
Update #MSG_NO c=3
2021-03-30 17:53:58 +02:00
75c0de741b
Update #MSG_AUTO_DEPLETE c=13
2021-03-30 17:52:59 +02:00
ddf47a3cac
Update #MSG_NA c=3, #MSG_OFF c=3, #MSG_ON c=3
2021-03-30 17:51:31 +02:00
d1813890a8
Update #MSG_STOPPED c=20
2021-03-30 17:49:02 +02:00
a9ed513979
Update #MSG_STOP_PRINT c=18
2021-03-30 17:48:06 +02:00
46367c2a33
Update #MSG_STEALTH c=7, #MSG_SILENT c=7, #MSG_NORMAL c=7
2021-03-30 17:46:37 +02:00
3d848328ed
Update #MSG_AUTO_POWER c=10
2021-03-30 17:42:33 +02:00
8771519880
Update #MSG_HIGH_POWER c=10
2021-03-30 17:41:51 +02:00
afabfa789d
Update #MSG_MODE c=6
2021-03-30 17:41:09 +02:00
dc56b74263
Update #MSG_MODE c=9
2021-03-30 17:39:43 +02:00
2a08a6e441
Update #MSG_SELFTEST_WIRINGERROR c=17
2021-03-30 17:37:50 +02:00
e6ea843e62
Update #MSG_SELFTEST_MOTOR c=18
2021-03-30 17:36:39 +02:00
35b000faea
Update MSG_RESUMING_PRINT c=20
2021-03-30 17:34:36 +02:00
557486ee0b
Update MSG_REFRESH c=18
2021-03-30 17:34:00 +02:00
54f594238b
Update #MSG_NOZZLE c=12
2021-03-30 17:33:15 +02:00
a878056be3
Update MSG_BACK c=18
2021-03-30 17:32:04 +02:00
610ba9bc45
Update #MSG_CARD_MENU c=18
2021-03-30 17:31:18 +02:00
5eb14dc433
Update #MSG_MAGNETS_COMP c=13
2021-03-30 17:29:56 +02:00
12372d6525
Update #MSG_Z_PROBE_NR c=14
2021-03-30 17:28:43 +02:00
7e2c272839
Update #MSG_MESH c=12
2021-03-30 17:27:02 +02:00
bc8a23a0c6
Update #MSG_TOSHIBA_FLASH_AIR_COMPATIBILITY c=8
2021-03-30 17:25:35 +02:00
3367d7f8fa
Update #MSG_SD_CARD c=8
2021-03-30 17:24:45 +02:00
e8c3ba89dc
Update #MSG_MMU_MODE c=8
2021-03-30 17:23:29 +02:00
532c7438d8
Update #MSG_NOZZLE_DIAMETER c=10, MSG_GCODE c=8
2021-03-30 17:19:00 +02:00
0a634f7d48
Update #MSG_FIRMWARE c=8
2021-03-30 17:16:31 +02:00
39b8a35f3a
Update #MSG_MODEL c=8
2021-03-30 17:15:48 +02:00
5b843c3a4d
Update #MSG_STRICT c=8
2021-03-30 17:14:49 +02:00
f60ba6de87
Update #MSG_WARN c=8
2021-03-30 17:13:56 +02:00
b465c96327
Update #MSG_NONE c=8
2021-03-30 17:13:09 +02:00
cdcc06f376
SDFile - fix errorneous offset computation
...
... my fault, I was originally too optimistic about the overflow
Fixes #3077
PFW-1233
2021-03-30 11:33:42 +02:00
a251dcc14e
Merge pull request #3064 from 3d-gussner/PFW-1222
...
PFW-1222: Disable M120 M121
2021-03-30 10:09:47 +02:00
e76b0c40a8
Merge pull request #3066 from espr14/PFW-1223
...
Calibration: detect biased PINDA and retry calibration PFW-1223
2021-03-30 10:08:16 +02:00
c4f80642b3
Update #MSG_MAIN c=18
2021-03-30 09:52:52 +02:00
4417deb9ea
Update #MSG_SOUND_BLIND c=7, #MSG_SOUND_LOUD c=7, MSG_SOUND_ONCE c=7
2021-03-30 09:50:21 +02:00
e4ed1ffc17
Update #MSG_SOUND c=9
2021-03-30 09:46:20 +02:00
2ce5d3a840
Update #MSG_RPI_PORT c=13
2021-03-30 09:44:13 +02:00
2ca8a23e4a
Update #MSG_SORT_ALPHA c=8 #MSG_SORT_TIME c=8
2021-03-30 09:42:53 +02:00
c85ebb4aa3
Update #MSG_SORT c=7
2021-03-30 09:40:26 +02:00
440ec49a36
Update #MSG_SETTINGS c=18
2021-03-30 09:38:33 +02:00
6900c206cd
Define #MSG_SEL_PREHEAT_TEMP c=20 r=6
2021-03-30 09:36:32 +02:00
12dc48ff1a
Update #MSG_BELTTEST c=18
2021-03-30 09:34:41 +02:00
b697117654
Update #MSG_SELFTEST c=18
2021-03-30 09:33:49 +02:00
9bc702ae0a
Update #MSG_SELFTEST_OK c=20
2021-03-30 09:32:27 +02:00
00fedbb08a
Update MSG_LANGUAGE_SELECT c=18
2021-03-30 09:30:04 +02:00
164226c739
Define #MSG_RIGHT c=10
2021-03-30 09:29:07 +02:00
2daf1d9114
Define #MSG_LEFT c=10
2021-03-30 09:26:50 +02:00
169f8983b6
Define #MSG_ADDITIONAL_SHEETS c=20 r=9
2021-03-30 09:23:35 +02:00
a82ca3def4
Update #MSG_WATCH c=18
2021-03-30 09:21:50 +02:00
0139bb5a5e
Update #MSG_CHANGE_SUCCESS c=20
2021-03-30 09:20:57 +02:00
0e86ab88fd
Update #MSG_FILAMENTCHANGE c=18
2021-03-30 09:20:01 +02:00
9c0300df66
Update #MSG_HEATING c=20
2021-03-30 09:18:11 +02:00
280a3c4d3a
Update #MSG_PRUSA3D_HOWTO c=18
2021-03-30 09:16:14 +02:00
12bd2f1a09
Update #MSG_PRUSA3D c=18
2021-03-30 09:15:21 +02:00
4e4fb7a59f
Update #MSG_PRUSA3D_FORUM c=18
2021-03-30 09:14:20 +02:00
10c586b577
Update #MSG_FLOW c=15
2021-03-30 09:13:09 +02:00
db07d55c29
Define #MSG_MMU_FIX_ISSUE c=20 r=4
2021-03-30 09:11:19 +02:00
7c9891d85e
Update #MSG_FSENSOR c=12
2021-03-30 09:09:11 +02:00
7a99f63ffd
Define #MSG_FAIL_STATS c=18
2021-03-30 09:06:59 +02:00
d427563e2b
Define #MSG_MMU_FAIL_STATS c=18
2021-03-30 09:05:18 +02:00
1b4241f031
Update #MSG_ERROR c=10
2021-03-30 09:03:38 +02:00
1b8ca77b0c
Define #MSG_MMU_CUTTING_FIL c=18
2021-03-30 09:01:58 +02:00
b6031c02a8
Update #MSG_DISABLE_STEPPERS c=18
2021-03-30 08:59:27 +02:00
69b9acdfc1
Define #MSG_CRASH_RESUME c=20 r=3
2021-03-30 08:57:42 +02:00
411caddc55
Define #MSG_CHOOSE_FIL_1ST_LAYERCAL c=20 r=7
2021-03-30 08:14:46 +02:00
2d2dc23e81
Define #MSG_CALIBRATING_HOME c=20
2021-03-30 08:12:20 +02:00
c8af50d344
Define #MSG_COPY_SEL_LANG c=20 r=3
2021-03-30 08:09:08 +02:00
71638b49fc
Update #MSG_COOLDOWN c=18
2021-03-30 08:05:54 +02:00
5f9b66a23a
Update #MSG_NOT_COLOR c=19
2021-03-30 08:04:39 +02:00
02ff05639b
Define MSG_CHECKING_FILE c=17
2021-03-30 08:01:26 +02:00
f2298b1a46
Update #MSG_SD_REMOVED c=20
2021-03-30 07:57:42 +02:00
1e2f5c8323
Update #MSG_MENU_CALIBRATION c=18
2021-03-30 07:55:19 +02:00
3733c42d38
Update #MSG_HOMEYZ_DONE c=20
2021-03-30 07:54:11 +02:00
79aa6b198d
Update #MSG_HOMEYZ c=18
2021-03-30 07:52:24 +02:00
fa0382fd3e
Update #MSG_CALIBRATE_BED c=18
2021-03-30 07:50:54 +02:00
2985c6bd6b
Update #MSG_BED c=13
2021-03-30 07:49:37 +02:00
7c906dd0b1
Update #MSG_BED_CORRECTION_MENU c=18
2021-03-30 07:44:16 +02:00
4d464b79f4
Update MSG_BED_HEATING c=20
2021-03-20 17:30:44 +01:00
3ee23af7b7
Update MSG_BED_DONE c=20
2021-03-20 16:04:52 +01:00
ba0f2b2501
Update MSG_LOOSE_PULLEY c=20
2021-03-20 07:11:41 +01:00
3fcc81ebdb
Update MSG_SELFTEST_ENDSTOP c=16
2021-03-20 07:11:07 +01:00
17df4e1c8d
Update MSG_SELFTEST_ENDSTOPS c=20
2021-03-20 07:10:09 +01:00
4a6c53daf8
Update MSG_SELFTEST_PLEASECHECK c=20
2021-03-20 07:09:33 +01:00
Alex Voinea
Guðni Már Gilbert
3d-gussner
DRracer
D.R.racer
Yuri D'Elia
Panayiotis-git
EV3R4
Guðni Már Gilbert
metacollin
Jonas Meyer
Marek Bel
DESKTOP-AFI832L\admin