Guðni Már Gilbert
2ad916a2c3
Fix manual fan check menu
...
lcd_encoder was not being updated
we need to call manage_inactivity
Tested on MK3S+
Change in memory:
Flash: +6 bytes
SRAM: 0 bytes
2023-04-19 15:41:36 +00:00
Guðni Már Gilbert
18c389543b
Fix lcd_update() FW crashes
...
Change in memory:
Flash: +10 bytes
SRAM: 0 bytes
2023-04-19 15:41:36 +00:00
3d-gussner
20e73e3c4f
Merge pull request #4067 from scottmudge/MK3_3.12-meatpack-pr
...
Add support for g-code compression/packing over serial connection (MeatPack)
2023-04-19 09:20:07 +02:00
Alex Voinea
2dcaae80d5
Merge pull request #4027 from gudnimg/minor-optimisation-gudni
...
Many minor optimisations for 3.13/3.14
2023-04-17 21:27:48 +02:00
Alex Voinea
ea97ca7920
Use `EXTRUDERS` instead of hardcoded value in string
2023-04-17 21:12:59 +02:00
Alex Voinea
b67063f14a
Remove empty lines
2023-04-17 21:10:20 +02:00
Guðni Már Gilbert
43d41ddd2b
cleanup: static variables in Marlin_main.cpp
2023-04-16 23:23:31 +00:00
Guðni Már Gilbert
4b54cd1f30
Remove unused LoadingToNozzleRAII
...
The variable is not used anywhere.
Change in memory:
Flash: -14 bytes
SRAM: -1 byte
2023-04-16 17:23:28 +00:00
Guðni Már Gilbert
01df65882f
cleanup: remove commented code
2023-04-16 15:25:43 +00:00
Alex Voinea
f6135f2ed1
Enable Analog IR sensor again
2023-04-16 13:58:18 +00:00
Guðni Már Gilbert
f5b9d2ac2e
cleanup: Remove unused Developer define
2023-04-16 13:13:16 +00:00
Guðni Már Gilbert
2ed4a75894
cleanup: remove unused settings
2023-04-16 13:13:16 +00:00
Guðni Már Gilbert
559e1bb21a
Remove unused MMU configs
...
- MMU_IDLER_SENSOR_ATTEMPTS_NR
- MMU_REQUIRED_FW_BUILDNR
These are no longer used
2023-04-16 13:13:16 +00:00
Guðni Már Gilbert
9b6e1babcb
many more lcd_putc_at optimisations
...
Changes in
lcd_implementation_drawmenu_sdfile
and
lcd_implementation_drawmenu_sddirectory
seem to save the most.
Change in memory:
Flash: -72 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
dea7f2b26c
Resolve PR review
...
Initialise EEPROM_CHECK_MODE always
But if farm mode is detected, update the Check mode to Strict
Initialise EEPROM_NOZZLE_DIAMETER on farm mode.
When opening the menus this value is set automatically to
_Diameter_400 anyway so this should be fine.
No change in memory on Multilang build
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
9f66eceb29
optimisation: belt test new values
...
use lcd_print instead of lcd_printf_P
to print the number only
Tested on MK3S+
Change in memory:
Flash: -34 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
87e40f1cee
optimisation: lcd_putc_at in belt test
...
Change in memory:
Flash: -4 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
583c46a63f
Simplify two fan_check_error checks
...
There are only 3 possible values. No need to check for two of them
to rule of the last value. Instead simply check for the last value only.
Change in memory:
Flash: -16 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
b67c359129
Move fan_state to fancheck.cpp and make it static
...
No change in memory
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
ebdcfbec50
cleanup: tmc2130: make variables static where applicable
...
No change in memory
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
7c23d8b00c
cleanup: make cancel_heatup static in Marlin_main
2023-04-15 13:45:10 +00:00
Alex Voinea
d148c08991
Remove dead code from get_coordinates()
2023-04-15 13:45:10 +00:00
Alex Voinea
c7de1b1416
optimize get_coordinates() axis mask
2023-04-15 13:45:10 +00:00
Alex Voinea
ea7b395852
Remove useless parantheses
...
Found these a few months ago when I was trying some other optimization. Don't want to make a PR just for this, so I'll just slide it here in this existing PR.
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
d175dba669
optimisation: use expired_cont is specific places
...
!variable.running() || variable.expired()
is equal to
variable.expired_cont()
The latter required less flash memory
Change in memory:
Flash: -28 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
00ffab8f62
optimisation: combine if statements in Sensors menu
...
FINDA status is always 0 or 1
Change in memory:
Flash: -28 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
7ff514621c
cleanup: remove unused global variable
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
69b4696114
use lcd_puts_P instead of lcd_printf_P
...
Change in memory:
Flash: -8 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
66bb9bcfe4
optimisation: lcd_temp_cal_show_result
...
result is boolean so always update the EEPROM
Change in memory:
Flash: -20 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
bd796a2cb3
optimisation: more lcd_putc_at
...
Change in memory:
Flash: -18 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
70dadc4202
M115: Extruder count is always 1
...
Change in memory:
Flash: -8 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
62cbc829f6
optimisation: use new eeprom methods in check_printer_version()
...
Change in memory:
Flash: -48 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
cd8a22d6b3
optimisation: utils: don't initialise global variables
...
They will be set by fCheckModeInit() by reading from EEPROM
Change in memory:
Flash: -2 bytes
SRAM: -1 byte
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
7a8dfdae53
optimisation: use new EEPROM init method for fCheckModeInit
...
Change in memory:
Flash: -90 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
6aafbe69a8
cleanup: remove unused function declaration
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
6e02a082e2
cleanup: make heating_status_counter static
...
Change in memory:
Flash: 0 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
ab934f8ba5
optimisation: make clock_interval static and 1 byte
...
Change in memory:
Flash: -16 bytes
SRAM: -1 byte
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
66e629ba74
cleanup: remove unused variable FSensorStateMenu
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
3cd97a5e8f
optimsation: draw cursor and set position with one function
...
Change in memory:
Flash: -4 bytes
SRAM: 0 bytes
2023-04-15 13:45:08 +00:00
Guðni Már Gilbert
2120d17912
optimisation: simplify T-code response for single material
...
Extruder is always 0
Change in memory:
Flash: -12 bytes
SRAM: 0 bytes
2023-04-15 13:45:08 +00:00
Guðni Már Gilbert
420f745bed
optimisation: mmu: combine if statements
...
Change in memory:
Flash: -6 bytes
SRAM: 0 bytes
2023-04-15 13:45:08 +00:00
Guðni Már Gilbert
4d90ecbcc4
cleanup: remove ctype include
...
We don't use any function from this header
No change in code size
2023-04-15 13:45:08 +00:00
Alex Voinea
8241be273b
Merge pull request #4123 from gudnimg/improve-mmu-status
...
Minor UI fixes for MMU status line during toolchange
2023-04-14 10:46:29 +02:00
Guðni Már Gilbert
f34c1ffeac
Fix an issue where visualisation is overwritten by SD file name
...
We should let EndReport set the custom message type state to Status
This will ensure the SD file name is shown correctly AFTER we've shown
the visualisation
Currently the visualisation is cut off in the middle by ReportProgressHook
Change in memory:
Flash: -6 bytes
SRAM: 0 bytes
2023-04-14 09:32:41 +02:00
Guðni Már Gilbert
4b3dc65598
Don't always set MSG_WELCOME at end of toolchange
...
This should only be set when NOT printing
Change in memory:
Flash: +8 bytes
SRAM: 0 bytes
2023-04-14 09:32:41 +02:00
3d-gussner
c15ea67379
Merge pull request #4119 from leptun/kill_reset
...
Postponed kill() message with softReset
2023-04-14 08:51:02 +02:00
Alex Voinea
41b8279805
Fix eeprom table addresses
2023-04-13 11:34:18 +02:00
Alex Voinea
af4a3f3328
Reorder eeprom reads
...
Saves 4B of flash
2023-04-13 11:15:17 +02:00
Alex Voinea
f333d36e47
Use a different location as a kill message pending flag
...
The old implementation would fail if the message was in progmem at address 0xffff or 0x0000 (both unlikely). It would also fail if the eeprom was initialized to some other random value, which could have been dangerous when displayed as a full screen message.
2023-04-13 10:57:00 +02:00
Alex Voinea
4b65d49512
Move kill check earlier during startup
2023-04-13 10:57:00 +02:00