ea101f49d4
`lcd_buttons` is actually `lcd_click_trigger`
...
Flash: -4B
SRAM: 0B
2023-04-24 11:56:04 +02:00
eb8ac250cc
Merge pull request #4163 from gudnimg/tx-fix
...
Fix issue where Tx gcode doesnt reset custom_message_type
2023-04-23 12:15:11 +02:00
62991c8e67
Fix issue where Tx gcode doesnt reset custom_message_type
...
We need to call BeginReport and EndReport
otherwise the SD filename is not shown when printing
This only affects single material MMU gcodes
Change in memory:
Flash: -4 bytes
SRAM: 0 bytes
2023-04-23 09:52:11 +00:00
ae75d9bb0e
Merge pull request #4162 from leptun/fix_lcd_encoder_diff
...
Fix `lcd_encoder_diff` getting out of sync with the knob hard steps
2023-04-23 11:31:45 +02:00
5778e39687
Resync `lcd_encoder_diff` when clicking
...
Flash: +4B
SRAM: 0B
2023-04-23 10:07:52 +02:00
c037e6dfba
Use atomic block for accessing lcd_encoder_diff
...
There was still the possibility of lcd_encoder_diff being updated from the ISR while the new enc_diff was being computed.
Flash: +8B
SRAM: 0B
2023-04-23 09:58:56 +02:00
1f181a949a
Fix `lcd_encoder_diff` getting out of sync with the knob hard steps
...
Flash: +18B
SRAM: 0B
2023-04-23 09:48:09 +02:00
ee8b95b556
Merge pull request #4158 from gudnimg/remove-dead-code-gudni-e1e2
...
Cleanup: remove unused extruder macros
2023-04-23 09:26:26 +02:00
9662bb11d4
Merge pull request #4144 from gudnimg/double-feedback-bugs
...
Double feedback bugs
2023-04-23 09:14:01 +02:00
3509791943
Drop sound feedback in lcd_v2_calibration
...
Drop the sound feedback in lcd_v2_calibration
when switching to lcd_generic_preheat_menu
If a single filament setup (no MMU) has filament loaded, it will jump
immediately to lcd_generic_preheat_menu
this created double feedback.
Let's just drop the feedback since the transition
between menus is very fast.
Change in memory:
Flash: -8 bytes
2023-04-22 15:28:27 +00:00
b15beb25cc
Remove INVERT_E1_DIR and INVERT_E2_DIR from config
...
I think these should be removed from the configuration files
as these definitions don't do anything.
2023-04-22 15:15:21 +00:00
0cf0d40a2e
Remove checkAllHotends()
2023-04-22 15:15:21 +00:00
c7f0ee13be
Missed these macros disable_e1/2
2023-04-22 15:15:21 +00:00
25522d3d68
Remove unused Autofan extruder configs
2023-04-22 15:15:21 +00:00
c14332bfb2
Combine two ifdefs
2023-04-22 15:15:21 +00:00
327b5b230b
Remove soft_pwm_1 and soft_pwm_2
2023-04-22 15:15:21 +00:00
fcabcd2804
Remove TEMP_SENSOR_1 and TEMP_SENSOR_2
...
Hopefully I didn't miss anything
2023-04-22 15:15:21 +00:00
f539b40611
Remove more EXTRUDERS > 1 code
2023-04-22 15:15:21 +00:00
4935191335
Cleanup remove unused macros
...
enable_e1
enable_e2
disable_e1
disable_e2
The firmware doesn't support multiple extruders
No change in memory
2023-04-22 15:15:21 +00:00
7889d54cfd
Merge pull request #4160 from gudnimg/cleanup-tcode-description
...
Rewrite the Tcodes description
2023-04-22 14:43:33 +00:00
76a76de7ea
Rewrite the Tcodes description
...
The old description had typos and was a bit confusing for new users
The new text is a suggestion from David Buzek at Prusa Research
2023-04-22 14:27:01 +00:00
51da6065c8
Merge pull request #4159 from gudnimg/cleanup-gudni-comments
...
Remove random `//-//` comments
2023-04-22 13:53:13 +00:00
b8f8348e77
Fix double feedback in Z-offset menu
2023-04-22 15:53:06 +02:00
b6e228d5a5
Fix double feedback in First Layer Calibration
...
For MMU users: This happens when the user
selects a filament to load from 1 to 5
For non-MMU: this happens when clicking
the knob within 2 seconds.
Additionally fixed the code indendation
it was a mix of spaces and tabs
2023-04-22 15:53:06 +02:00
ccabf1fa31
Remove random //-// comments
2023-04-22 13:39:08 +00:00
e516d8a0c4
Merge pull request #4156 from leptun/lcd_status_screen_block
...
Fix `M0` click not consumed
2023-04-22 15:01:16 +02:00
4ce3fa53a1
Optimise M0/M1 code size
...
Replace two bool variables with one.
It's not obvious but (!hasP && !hasS) is equal to
!(hasP || hasS)
Note: expiration_time_set = hasP || hasS
Truth table:
|--------------------------------------------------|
| hasP| hasS| (!hasP && !hasS)| !(hasP || hasS) |
|------|-----|--------------------|-----------------|
| 0 | 0 | 1 | 1 |
| 0 | 1 | 0 | 0 |
| 1 | 0 | 0 | 0 |
| 1 | 1 | 0 | 0 |
|--------------------------------------------------|
Change in memory:
Flash: -36 bytes
SRAM: 0 bytes
2023-04-21 17:42:55 +00:00
360f234b98
Merge pull request #4146 from gudnimg/fan-check-opt
...
Reduce code size in fan check selftest
2023-04-21 14:24:04 +02:00
7ee1640792
Merge pull request #4143 from gudnimg/improve-lcd-update
...
Fix lcd_update() FW crashes
2023-04-21 14:23:16 +02:00
91b913e997
Fix `M0` click not consumed
...
Fix the need to click the knob twice to dismiss `M0`.
Flash: -54B
SRAM: -2B
2023-04-21 12:59:40 +02:00
2ad916a2c3
Fix manual fan check menu
...
lcd_encoder was not being updated
we need to call manage_inactivity
Tested on MK3S+
Change in memory:
Flash: +6 bytes
SRAM: 0 bytes
2023-04-19 15:41:36 +00:00
18c389543b
Fix lcd_update() FW crashes
...
Change in memory:
Flash: +10 bytes
SRAM: 0 bytes
2023-04-19 15:41:36 +00:00
20e73e3c4f
Merge pull request #4067 from scottmudge/MK3_3.12-meatpack-pr
...
Add support for g-code compression/packing over serial connection (MeatPack)
2023-04-19 09:20:07 +02:00
2dcaae80d5
Merge pull request #4027 from gudnimg/minor-optimisation-gudni
...
Many minor optimisations for 3.13/3.14
2023-04-17 21:27:48 +02:00
ea97ca7920
Use `EXTRUDERS` instead of hardcoded value in string
2023-04-17 21:12:59 +02:00
b67063f14a
Remove empty lines
2023-04-17 21:10:20 +02:00
43d41ddd2b
cleanup: static variables in Marlin_main.cpp
2023-04-16 23:23:31 +00:00
4b54cd1f30
Remove unused LoadingToNozzleRAII
...
The variable is not used anywhere.
Change in memory:
Flash: -14 bytes
SRAM: -1 byte
2023-04-16 17:23:28 +00:00
01df65882f
cleanup: remove commented code
2023-04-16 15:25:43 +00:00
f6135f2ed1
Enable Analog IR sensor again
2023-04-16 13:58:18 +00:00
f5b9d2ac2e
cleanup: Remove unused Developer define
2023-04-16 13:13:16 +00:00
2ed4a75894
cleanup: remove unused settings
2023-04-16 13:13:16 +00:00
559e1bb21a
Remove unused MMU configs
...
- MMU_IDLER_SENSOR_ATTEMPTS_NR
- MMU_REQUIRED_FW_BUILDNR
These are no longer used
2023-04-16 13:13:16 +00:00
9b6e1babcb
many more lcd_putc_at optimisations
...
Changes in
lcd_implementation_drawmenu_sdfile
and
lcd_implementation_drawmenu_sddirectory
seem to save the most.
Change in memory:
Flash: -72 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
dea7f2b26c
Resolve PR review
...
Initialise EEPROM_CHECK_MODE always
But if farm mode is detected, update the Check mode to Strict
Initialise EEPROM_NOZZLE_DIAMETER on farm mode.
When opening the menus this value is set automatically to
_Diameter_400 anyway so this should be fine.
No change in memory on Multilang build
2023-04-15 13:45:10 +00:00
9f66eceb29
optimisation: belt test new values
...
use lcd_print instead of lcd_printf_P
to print the number only
Tested on MK3S+
Change in memory:
Flash: -34 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
87e40f1cee
optimisation: lcd_putc_at in belt test
...
Change in memory:
Flash: -4 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
583c46a63f
Simplify two fan_check_error checks
...
There are only 3 possible values. No need to check for two of them
to rule of the last value. Instead simply check for the last value only.
Change in memory:
Flash: -16 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
b67c359129
Move fan_state to fancheck.cpp and make it static
...
No change in memory
2023-04-15 13:45:10 +00:00
ebdcfbec50
cleanup: tmc2130: make variables static where applicable
...
No change in memory
2023-04-15 13:45:10 +00:00
Alex Voinea
Guðni Már Gilbert
3d-gussner