gudnimg
20a2216623
PFW-1523 Implement S parameter for M79
...
Change in memory:
Flash: +112 bytes
SRAM: +3 bytes
2023-11-04 20:38:50 +00:00
gudnimg
8fcfdf31c4
PFW-1523 Implement M79 timer for PrusaLink
...
The idea is to have the host ping the printer periodically with a M79 to
enable certain features/UI. Using the usb_timer is not a good solution
for this as it depends on seeing a 'G' character
The LCD code, or whatever code is implementing the new functionality
will need to include host.h and check whether M79_timer_get_status()
returns 0 (timer not running) or 1 (timer is running).
I created a new file for the code host.cpp which we can use to expand
host related functionality and not clutter Marlin_main.cpp further.
Change in memory:
Flash: +104 bytes
SRAM: +5 bytes
2023-10-29 16:33:45 +00:00
3d-gussner
63b628d722
Merge pull request #4396 from 3d-gussner/MK3_PFW-1538_M420
...
PFW-1538: Add M420
2023-10-13 14:27:34 +02:00
3d-gussner
2027a54873
Merge pull request #4420 from gudnimg/PFW-1543
...
PFW-1543 Save print type in EEPROM
2023-10-06 09:04:30 +02:00
3d-gussner
8b9b63c35b
Merge pull request #4418 from gudnimg/PFW-1542-v2
...
PFW-1542 Handle fan error sooner when waiting for heating to complete
2023-10-03 10:16:49 +02:00
Alex Voinea
dd32f7be3c
bootapp cleanup
2023-10-03 08:19:48 +02:00
Alex Voinea
5466bfb500
Cleanup uartout declaration
2023-10-03 08:19:48 +02:00
gudnimg
3eaca29b0b
PFW-1543 Move printing types into enum
...
Also add power panic namespace
2023-10-01 12:57:25 +00:00
gudnimg
e621d3445e
PFW-1542 Handle fan error sooner when waiting for heating to complete
...
While waiting for the nozzle to reach a certain temperature, a fan error
should disable the hotend heater. If printing, it will simply pause the print.
Previously the printer would wait for the nozzle to heat up before pausing the print
and turning off the hotend heater.
We rely on LcdCommands::LongPause and must return to the top level loop to process it.
Waiting in the while loop e.g. in M190 does not make sense.
2023-09-30 14:01:09 +00:00
3d-gussner
f8c64de505
Merge pull request #4390 from sarusani/mbl_mag_comp
...
MBL: Add magnet compensation parameter
2023-09-22 14:57:09 +02:00
Guðni Már Gilbert
e323490659
optimisation: Remove unused Z offset
...
Frees up some SRAM
Change in memory:
Flash: 0 bytes
SRAM: -4 bytes
2023-09-19 23:37:38 +00:00
3d-gussner
1996f977e1
Merge branch 'MK3' into mbl_mag_comp
2023-09-18 15:55:42 +02:00
3d-gussner
8bd71b7bf0
Merge pull request #4391 from sarusani/mbl_default_to_eeprom
...
MBL: Default to EEPROM values
2023-09-18 15:52:38 +02:00
3d-gussner
039202f34b
Fix typo
2023-09-18 15:48:36 +02:00
3d-gussner
0877585bd1
Add M420
...
Same as G81
2023-09-18 15:45:13 +02:00
D.R.racer
be5523187b
Sync MK3<->MK4 MMU2 mmu2_mk4.h
2023-09-18 10:51:32 +02:00
Guðni Már Gilbert
6187b7eecf
optimisation: use disable_heater() in more places
...
Change in memory:
Flash: -84 bytes
SRAM: 0 bytes
2023-09-16 14:26:09 +00:00
sarusani
84d353793d
Fix typos
2023-09-16 12:38:14 +02:00
sarusani
e4a10e5fab
Move code_seen back into if statement
...
Same memory usage, but prettier to look at. :)
2023-09-15 14:11:27 +02:00
sarusani
56a79f88ef
Optimise memory usage
2023-09-15 14:11:27 +02:00
sarusani
2951bc8af0
Default to eeprom values
...
Use eeprom values if provided parameters are out of bounds.
2023-09-15 14:11:27 +02:00
3d-gussner
9e794a47a4
Merge pull request #4386 from 3d-gussner/MK3_mbl_print_area_translations
...
🚧 Add new MBL message for #4183 and translation
2023-09-15 09:00:38 +02:00
sarusani
21c57a1222
Add parameter for magnet compensation
...
allow to enable/disable magnet compensation when 7x7 is in use.
2023-09-14 21:02:56 +02:00
sarusani
2863c9bc01
Cleanup: whitespace in nProbeRetryCount var
2023-09-14 09:43:26 +02:00
3d-gussner
5f605012eb
Merge pull request #4388 from prusa3d/vintagepc/tmc-mode-query
...
Add Q parameter to M91[4/5]
2023-09-14 09:13:55 +02:00
VintagePC
70d83fe4ee
Add Q parameter to query current mode.
2023-09-13 16:52:11 -04:00
sarusani
a9c8bb7dbf
Code cleanup: rename params
2023-09-13 18:31:45 +02:00
sarusani
d3bb6e5ca5
Rename MBL repeat param
2023-09-13 17:37:39 +02:00
3d-gussner
ca27841d67
Add new MBL message for #4183 and translate these messages
2023-09-13 11:14:16 +02:00
3d-gussner
2e70697fa7
Merge pull request #4183 from leptun/mbl_print_area
...
MBL print area
2023-09-13 10:28:08 +02:00
3d-gussner
74f724b228
Merge pull request #4174 from gudnimg/check_all_heaters
...
optimisation: use `CHECK_ALL_HEATERS` in more places
2023-09-12 16:31:45 +02:00
3d-gussner
c84985ec3e
Merge pull request #4328 from dawidpieper/m850_addselection
...
M850 add possibility to set sheet as active
2023-09-11 13:02:04 +02:00
Guðni Már Gilbert
e6f05e7856
PFW-1522 Fix firmware getting stuck on ejecting
...
If slot is unknown, the printer will always get a rejected command
error from the MMU.
Change in memory:
Flash: +4 bytes
SRAM: 0 bytes
2023-08-18 14:27:39 +02:00
Guðni Már Gilbert
fc18f4c5d7
PFW-1522 Implement filament change screen
...
Change in memory:
Flash: +116 bytes
SRAM: +1 byte
2023-08-18 14:27:39 +02:00
Alex Voinea
ede4cc5d30
Update error messages
2023-08-17 08:02:47 +02:00
Alex Voinea
45823e7336
Make the G80 Z threshold tighter
2023-08-17 08:02:47 +02:00
Alex Voinea
f5f09f147c
Add a limit to how many times G80 can fail
...
Flash: +80
SRAM: +1
2023-08-17 07:53:39 +02:00
Alex Voinea
7740a81edb
Do not store a global mbl_z_probe_nr
...
flash: -6
sram: 0? (somehow)
2023-08-17 07:53:39 +02:00
Alex Voinea
a984b2e609
G80 `O` parameter
...
a
2023-08-17 07:53:39 +02:00
Alex Voinea
a15f536ff4
Combine BED_X/Y() and mbl::get_x/y()
...
flash: -112
2023-08-17 07:52:55 +02:00
Guðni Már Gilbert
6b12be42d9
optimisation: Make BED_X and BED_Y into functions
...
Previously these preprocessor macros were always being inlined.
By making these into a function we can control the inlining
more directly.
The number of points on the mesh is also now constant. This means
'n' can now be float at compile time. This removes one uint8_t to float
conversion.
Change in memory:
Flash: -208 bytes
SRAM: 0 bytes
2023-08-17 07:52:55 +02:00
Alex Voinea
3ccf2d60c0
Make bed correction matrix const
2023-08-17 07:52:55 +02:00
Alex Voinea
be3465cf18
optimize lambda expression capture
...
flash: -10
2023-08-17 07:52:55 +02:00
Alex Voinea
2d0b96fe6a
Bed correction code optimization
...
flash: -44
2023-08-17 07:52:55 +02:00
Alex Voinea
5b8c65e342
Minor magnet elimination optimization
...
flash: -4B
2023-08-17 07:52:55 +02:00
Alex Voinea
67945579de
G80 minor optimization
2023-08-17 07:52:55 +02:00
Alex Voinea
a5c20a1c6e
Do not plan a Z move if no move is actually performed
2023-08-17 07:52:55 +02:00
Alex Voinea
de98551691
Extract hardcoded value
2023-08-17 07:52:55 +02:00
Alex Voinea
40db9c9258
Fix eeprom mesh offset
2023-08-17 07:52:55 +02:00
Alex Voinea
a7d3dd720b
Fix eeprom mesh interpolation
2023-08-17 07:52:55 +02:00
Alex Voinea
36d8de0727
G80 general fixes
...
Use interpolated eeprom mesh for skewed Z detection
Use the interpolated eeprom mesh for raising Z for the next point
Fix LCD countdown during MBL
2023-08-17 07:52:55 +02:00
Alex Voinea
b234560b22
MBL print function optimization
2023-08-17 07:52:55 +02:00
Alex Voinea
f94bc72235
Optimize G80 bed correction argument parsing
2023-08-17 07:52:55 +02:00
Alex Voinea
6c97907507
A bit more cleanup
2023-08-17 07:52:55 +02:00
Alex Voinea
6af5f5e2a2
Some code cleanup around homing_feedrate
2023-08-17 07:52:55 +02:00
Alex Voinea
83879fd10c
Cleanup magnet compensation code
2023-08-17 07:52:55 +02:00
Alex Voinea
46710c4b4e
G80 code cleanup
2023-08-17 07:52:55 +02:00
Alex Voinea
07b9447ee1
Fix correction nMeasPoints
2023-08-17 07:51:15 +02:00
Alex Voinea
a4ef72b1fc
Use mesh from eeprom during print area MBL
2023-08-17 07:51:15 +02:00
Alex Voinea
7b9f2086f4
MBL print area initial implementation
2023-08-17 07:51:15 +02:00
Alex Voinea
11e1806e0c
Gcode documentation
2023-08-17 07:51:15 +02:00
Guðni Már Gilbert
c4f48a6606
MMU: Disable FINDA runout during Homing and MBL
...
If for some reason a user added a extrusion move in the firmware. Prevent FINDA runout
from triggering.
Change in memory:
Flash: +16 bytes
SRAM: 0 bytes
2023-08-17 07:43:59 +02:00
Guðni Már Gilbert
61ec6b8ae7
G80: Don't unretract unless retracting first
...
temp_compensation_start() is only called when
PINDA_THERMISTOR is not defined.
Additionally make sure the retraction or unretraction cannot happen
twice in case MBL fails.
For MK3S users with MMU this extrusion move could
cause a FINDA runout event.
Change in memory:
Flash: -130 bytes
SRAM: 0 bytes
2023-08-17 07:43:59 +02:00
dawidpieper
14306e59c8
Try immediate EEPROM writes for flash size optimization
2023-08-16 20:36:24 +02:00
dawidpieper
1dada5ba81
Revert optimizations of bIsActive
2023-08-16 20:18:16 +02:00
dawidpieper
91cb01b12f
Code optimization
2023-08-16 20:08:53 +02:00
dawidpieper
b2f6b77cf3
Add separators between blocks
2023-08-16 19:46:57 +02:00
dawidpieper
58014156a0
Fix code formatting
2023-08-16 19:18:33 +02:00
dawidpieper
11d8c157f6
M850 add possibility to set sheet as active
2023-08-15 22:19:55 +02:00
Alex Voinea
ef63b57dfd
Remove unimplemented M407 from list of gcodes
2023-08-11 09:02:11 +02:00
3d-gussner
500a6558a5
Rebase, fix and update doxygen
2023-08-11 09:02:11 +02:00
Michael Greene
f449b06bb2
reprocess patch so I don't have 1200 lines of whitespace changes to review
2023-08-11 09:02:11 +02:00
Guðni Már Gilbert
02332018ec
tmc2130: Fix bug with vSense bit and current values
...
If vSense changes at runtime due to Run current
being changed. Then we must always shift the Hold current
correctly. Whether the vSense is changing 1 -> 0 or 0 ->1
Change in memory (with TMC2130_SERVICE_CODES_M910_M918):
Flash: +76 bytes
SRAM: 0 bytes
2023-08-05 10:41:21 +02:00
3d-gussner
2ab9cbcd83
Merge pull request #923 from cwei/patch-1
...
Fix upper limit for x
2023-08-02 12:05:38 +02:00
Guðni Már Gilbert
a96ee9da62
m600: power panic: unset isPartialBackupAvailable on M600 exit
...
If no power panic occurred during M600 we should
clear isPartialBackupAvailable to let the power panic
code know to not use the partial backup. We want the
partial backup ONLY when the extruder is parked after a print is saved.
Change in memory:
Flash: +4 bytes
SRAM: 0 bytes
2023-07-27 16:55:08 +00:00
vintagepc
a2eafc587a
Merge branch 'MK3' into 2477-redux
2023-07-26 12:34:38 -04:00
3d-gussner
ce141a2fa1
Merge pull request #3564 from wavexx/fil_loading_state
...
Filament loading state fixes
2023-07-26 16:38:29 +02:00
3d-gussner
6feab85252
Rebase update REVO and solve @wavexx comments
2023-07-25 17:24:02 +02:00
3d-gussner
8ae0e1952e
Rename `temp_model.h` to `thermal_model.h`
...
`/temp_model` to `/thermal_model`
`Temperature_model` to `Thermal_model`
minor format in eeprom.h
2023-07-25 17:13:07 +02:00
3d-gussner
a6b209d36d
Rename `Temperature Model` to `Thermal Model`
...
`Temperature model` to `Thermal model`
`temperature model` to `thermal model`
2023-07-25 17:13:07 +02:00
3d-gussner
44ae8033eb
Rename upper case `TEMP_MODEL` to `THERMAL_MODEL`
2023-07-25 17:13:07 +02:00
3d-gussner
dac07d11ba
Rename lower case `temp_model` to `thermal_model`
2023-07-25 17:13:07 +02:00
Guðni Már Gilbert
f40defd2a9
Rename minsegmenttime --> min_segment_time_us
...
Also fixed wrong unit in Configuration prinout (M500)
should be us and not ms
Also used %lu format for uint32_t instead of %.2f
2023-07-25 17:10:44 +02:00
Guðni Már Gilbert
6c95d340c1
Remove dead code axis_travel_steps_per_sqr_second
2023-07-25 17:10:44 +02:00
Guðni Már Gilbert
8689a28776
Rename max_acceleration_units_per_sq_second to max_acceleration_mm_per_s2
2023-07-25 17:10:44 +02:00
Guðni Már Gilbert
21faa52aab
Rename axis_steps_per_unit to axis_steps_per_mm
2023-07-25 17:10:44 +02:00
Guðni Már Gilbert
fa6aae60db
optimisation: use SERIAL_PROTOCOLLN
...
Change in memory:
Flash: -12 bytes
SRAM: 0 bytes
2023-07-25 15:02:49 +00:00
Guðni Már Gilbert
9d15a4e63b
optimisation: reduce code size in M916, M917, M918
...
Change in memory:
Flash: -148 bytes
SRAM: 0 bytes
2023-07-25 15:02:49 +00:00
Guðni Már Gilbert
c090868fa2
optimisation: reduce code size in M907
...
Change in memory:
Flash: -4 bytes
SRAM: 0 bytes
2023-07-25 15:02:49 +00:00
Guðni Már Gilbert
5288d615f8
optimisation: lcd avoid streams
...
Author: leptun
Change in memory:
Flash: -124 bytes
SRAM: 0 bytes
2023-07-25 15:02:49 +00:00
Yuri D'Elia
074b5d380f
Consistently replace loading_flag with eFilamentAction
...
Remove loading_flag and check for eFilamentAction instead which already
flags both load/unload (in addition to mmu actions).
Correctly transition from AutoLoad to Load as soon as the operation
cannot be cancelled anymore as opposed to resetting it.
2023-07-25 14:30:20 +00:00
Yuri D'Elia
dece5d268f
Consider any lcd_custom_command to be "ACTIVE"
...
All custom commands are transitory and eventually switch back to Idle
state by themselves.
It doesn't make any sense to explicitly check for Layer1Cal: any
non-idle state is active by design.
Fix this check in the main menu. This is probably incomplete (Layer1Cal
is incorrectly used in several other places).
2023-07-25 14:27:00 +00:00
Guðni Már Gilbert
1984091c10
Rename axis_steps_per_sqr_second to max_acceleration_steps_per_s2
2023-07-25 09:00:47 +02:00
Guðni Már Gilbert
3819f7a473
tmc2130: Refactor code for setting/changing currents
...
- Always re-calculate the Vsense flag when the currents are changed
- Make sure Hold current is not larger than Run current
- Added SetCurrents() function from MMU FW
- Added MotorCurrents structure from MMU FW
- Various code size optimisations e.g. in power panic
Change in memory:
Flash: -10 bytes
SRAM: +4 bytes
2023-07-25 08:56:43 +02:00
Guðni Már Gilbert
2cd5ab2349
power panic: add readable flags and optimise ISR(INT4_vect)
...
Add more readable names for the EEPROM_UVLO values
Change in memory:
Flash: -14 bytes
SRAM: 0 bytes
2023-07-18 11:29:03 +02:00
Guðni Már Gilbert
fa843a4a9b
power panic: implement partial back up in RAM
...
A partial backup is needed in scenarios where the extruder may be
parked after a print is saved. For example during a blocking wait for the user in M600
Or during a MMU error screen.
A sudden power panic at this point would previously save the parked position
into EEPROM. When the print is recovered it would print in mid air.
2023-07-18 11:29:03 +02:00
Guðni Már Gilbert
6ccd12c7e8
power panic: re-use saved_pos
...
This allows us to restore the position of all axis saved in RAM
If the extruder had been parked to the side for example
due to filament runout. Then the original position (before parking)
should now be restored
Change in memory:
Flash: +40 bytes
SRAM: 0 bytes
2023-07-18 11:29:03 +02:00
Guðni Már Gilbert
97c27525d4
power panic: re-use saved_extruder_relative_mode
...
Change in memory:
Flash: +8 bytes
SRAM: 0 bytes
2023-07-18 11:29:03 +02:00
Guðni Már Gilbert
a2ac513794
power panic: re-use target temps from RAM
...
If a print has been saved to RAM such as during a filament runout,
do not overwrite these saved values if a sudden
power panic appears.
Additionally, change the saved types to be the same as power panic when saving to RAM:
- Bed target temperature is uint8_t (0 to 255) instead of float
- Extruder target temperature is uint16_t instead of float
Doing this change allows us to re-use the same global variables and
avoid creating local variables during power panic.
Change in memory:
Flash: -246 bytes
SRAM: -5 bytes
2023-07-18 11:29:03 +02:00
Guðni Már Gilbert
a45e432030
power panic: Re-use code to save feedrate, segment index, and start position
...
Saves ~80B of Flash
2023-07-18 11:29:03 +02:00
Guðni Már Gilbert
67403603ed
power panic: Re-use saving print file state
...
This also adds the Gcode position into EEPROM
for Octoprint/PrusaLink prints.
Though the recovery part doesn't support that yet.
2023-07-18 11:29:03 +02:00
Guðni Már Gilbert
2902fcaa71
power panic: Add two functions
...
These functions should be able to be re-used during a power panic
- save_print_file_state
- restore_print_file_state
No functional change at the moment.
2023-07-18 11:29:03 +02:00
Guðni Már Gilbert
526a1dcc63
power panic: Move code into a separate file
2023-07-18 11:29:03 +02:00
RoboMagus
2d461572dd
Fix command parameters offset
2023-07-13 11:05:29 +02:00
RoboMagus
4450dbe4dd
Update serial echo macro to print from PGM
2023-07-13 11:05:29 +02:00
RoboMagus
d9e6dd4efe
Update usage comment
2023-07-13 11:05:29 +02:00
RoboMagus
5baa74a425
Add M118 Gcode support
2023-07-13 11:05:29 +02:00
3d-gussner
7f95c54305
Move `Language update` to first row
2023-07-13 10:08:09 +02:00
3d-gussner
9421785190
Update doxygen and po files
2023-06-29 08:23:13 +02:00
3d-gussner
10e2357cc5
Change MMU2 to MMU3
2023-06-27 11:41:09 +02:00
Guðni Már Gilbert
02859a37c8
optimisation: use CHECK_ALL_HEATERS in more places
...
Change in memory:
Flash: -162 bytes
SRAM: 0 bytes
2023-05-31 20:39:38 +00:00
Guðni Már Gilbert
7dc370a7e1
Move ISR7 code to fancheck.cpp
2023-05-23 07:43:40 +02:00
Guðni Már Gilbert
963bd508a4
Fix MK25 compiler warning
...
warning: 't_fan_rising_edge' defined but not used [-Wunused-variable]
2023-05-23 07:43:40 +02:00
Alex Voinea
0612a38885
Fix stepper inactivity timeout
2023-05-13 08:18:39 +02:00
3d-gussner
0c453b53cd
Merge pull request #4193 from gudnimg/unload-sequence-improvements
...
Fix unload sequence for users without MMU
2023-05-10 07:29:16 +02:00
Guðni Már Gilbert
e24c2200f1
Set FILAMENTCHANGE_FINALRETRACT instead of hardcoded 0
2023-05-08 19:33:42 +00:00
Guðni Már Gilbert
71180ac284
Cleanup M600 init
...
Instead of removing FILAMENTCHANGE_FINALRETRACT
just set it to 0
No change in memory
2023-05-06 15:24:54 +00:00
Guðni Már Gilbert
8556336185
Fix unload sequence for users without MMU
...
Restores 3.12 sequence which was working well before.
M600 "L" parameter now works like M702 "U" parameter.
Removed a lot of the unused parameters which were copied
from Marlin 2.
Change in memory:
Flash: +96 bytes
2023-05-06 15:24:54 +00:00
VintagePC
e336e2ad08
Fix merge conflict/resync
2023-05-06 11:22:31 -04:00
Guðni Már Gilbert
462535ef7f
Restore 3.12 live Z-adjust menu behavior
...
Code size increases a bit but keep in mind the PR
that broke the behavior "saved" 182 bytes:
https://github.com/prusa3d/Prusa-Firmware/pull/4063
So I think this code size increase is OK
Change in memory:
Flash: +84 bytes
SRAM: 0 bytes
2023-05-06 12:08:06 +00:00
3d-gussner
bf6c0919e1
Merge pull request #4166 from gudnimg/gudnimg-patch-1
...
M701/M702: Set default Z value to 0
2023-05-05 12:38:37 +02:00
3d-gussner
fd2184801f
Merge pull request #4168 from gudnimg/next_feedrate_remove
...
Cleanup: Remove `next_feedrate` from global scope
2023-05-05 12:36:04 +02:00
Guðni Már Gilbert
9cf1f7871e
Minor fix to M701 when MMU slot is out of range
...
If MMU slot is outside of range, then we rather the printer
not do anything. Currently it would accidentally assume
the MMU is disabled. This may have undesireable results.
No change in memory
2023-05-02 22:32:18 +00:00
Guðni Már Gilbert
92e5747469
M600: remove dead code
...
The if statement doesn't do anything useful
so I propose it be removed before 3.13 release
Change in memory:
Flash: -30 bytes
SRAM: 0 bytes
2023-04-29 23:43:27 +00:00
Guðni Már Gilbert
26369ac540
Restore old M701/M702 behavior
...
If the new Z parameter is not given,
assume that the old Z-lift behavior is desired.
Change in memory:
Flash: -28 bytes
SRAM: 0 bytes
2023-04-29 16:22:28 +00:00
Guðni Már Gilbert
228250f050
Cleanup: Remove next_feedrate from global scope
...
No change in memory
2023-04-24 21:33:07 +00:00
Guðni Már Gilbert
78614f5670
M701/M702: Set default Z value to 0
...
Set default Z value to 0 to maintain backwards compatibility with older gcodes.
2023-04-24 09:09:43 +00:00
Guðni Már Gilbert
c7f0ee13be
Missed these macros disable_e1/2
2023-04-22 15:15:21 +00:00
Guðni Már Gilbert
4935191335
Cleanup remove unused macros
...
enable_e1
enable_e2
disable_e1
disable_e2
The firmware doesn't support multiple extruders
No change in memory
2023-04-22 15:15:21 +00:00
Guðni Már Gilbert
7889d54cfd
Merge pull request #4160 from gudnimg/cleanup-tcode-description
...
Rewrite the Tcodes description
2023-04-22 14:43:33 +00:00
Guðni Már Gilbert
76a76de7ea
Rewrite the Tcodes description
...
The old description had typos and was a bit confusing for new users
The new text is a suggestion from David Buzek at Prusa Research
2023-04-22 14:27:01 +00:00
Guðni Már Gilbert
51da6065c8
Merge pull request #4159 from gudnimg/cleanup-gudni-comments
...
Remove random `//-//` comments
2023-04-22 13:53:13 +00:00
Guðni Már Gilbert
ccabf1fa31
Remove random //-// comments
2023-04-22 13:39:08 +00:00
Alex Voinea
e516d8a0c4
Merge pull request #4156 from leptun/lcd_status_screen_block
...
Fix `M0` click not consumed
2023-04-22 15:01:16 +02:00
Guðni Már Gilbert
4ce3fa53a1
Optimise M0/M1 code size
...
Replace two bool variables with one.
It's not obvious but (!hasP && !hasS) is equal to
!(hasP || hasS)
Note: expiration_time_set = hasP || hasS
Truth table:
|--------------------------------------------------|
| hasP| hasS| (!hasP && !hasS)| !(hasP || hasS) |
|------|-----|--------------------|-----------------|
| 0 | 0 | 1 | 1 |
| 0 | 1 | 0 | 0 |
| 1 | 0 | 0 | 0 |
| 1 | 1 | 0 | 0 |
|--------------------------------------------------|
Change in memory:
Flash: -36 bytes
SRAM: 0 bytes
2023-04-21 17:42:55 +00:00
Alex Voinea
91b913e997
Fix `M0` click not consumed
...
Fix the need to click the knob twice to dismiss `M0`.
Flash: -54B
SRAM: -2B
2023-04-21 12:59:40 +02:00
Guðni Már Gilbert
18c389543b
Fix lcd_update() FW crashes
...
Change in memory:
Flash: +10 bytes
SRAM: 0 bytes
2023-04-19 15:41:36 +00:00
Alex Voinea
2dcaae80d5
Merge pull request #4027 from gudnimg/minor-optimisation-gudni
...
Many minor optimisations for 3.13/3.14
2023-04-17 21:27:48 +02:00
Alex Voinea
ea97ca7920
Use `EXTRUDERS` instead of hardcoded value in string
2023-04-17 21:12:59 +02:00
Alex Voinea
b67063f14a
Remove empty lines
2023-04-17 21:10:20 +02:00
Guðni Már Gilbert
43d41ddd2b
cleanup: static variables in Marlin_main.cpp
2023-04-16 23:23:31 +00:00
Guðni Már Gilbert
01df65882f
cleanup: remove commented code
2023-04-16 15:25:43 +00:00
Guðni Már Gilbert
9b6e1babcb
many more lcd_putc_at optimisations
...
Changes in
lcd_implementation_drawmenu_sdfile
and
lcd_implementation_drawmenu_sddirectory
seem to save the most.
Change in memory:
Flash: -72 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
583c46a63f
Simplify two fan_check_error checks
...
There are only 3 possible values. No need to check for two of them
to rule of the last value. Instead simply check for the last value only.
Change in memory:
Flash: -16 bytes
SRAM: 0 bytes
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
b67c359129
Move fan_state to fancheck.cpp and make it static
...
No change in memory
2023-04-15 13:45:10 +00:00
Guðni Már Gilbert
7c23d8b00c
cleanup: make cancel_heatup static in Marlin_main
2023-04-15 13:45:10 +00:00
Alex Voinea
d148c08991
Remove dead code from get_coordinates()
2023-04-15 13:45:10 +00:00
Alex Voinea
c7de1b1416
optimize get_coordinates() axis mask
2023-04-15 13:45:10 +00:00
Alex Voinea
ea7b395852
Remove useless parantheses
...
Found these a few months ago when I was trying some other optimization. Don't want to make a PR just for this, so I'll just slide it here in this existing PR.
2023-04-15 13:45:09 +00:00
Guðni Már Gilbert
70dadc4202
M115: Extruder count is always 1
...
Change in memory:
Flash: -8 bytes
SRAM: 0 bytes
2023-04-15 13:45:09 +00:00